[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 updated this revision to Diff 261742. n1tram1 added a comment. Have the File first check if it is the current stack frame being displayed and check if it needs an update that way. Else, iteratively look for it's belonging module and check if it needs an update. Also fix the SourceCache:

[Lldb-commits] [PATCH] D79251: Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/test/API/lang/cpp/operators/main.cpp:12 bool custom_new = false; B b; This can also go as it's now unused. CHA

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

labath added a comment. I'm not sure this new version is for the better :(. Error and Expected objects have a contract where you're supposed to "consume" each object before you destroy or reassign it. The complex control flow in that function makes it very hard to see that this is really the ca

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

labath accepted this revision. labath added a comment. Yeah, I think this looks good too. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:42-43 + llvm_unreachable("unsupported length"); +memcpy(reinterpret_cast(m_data), + reinterpret_cast(bytes), siz

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

labath added a comment. In D78825#2015326 , @JDevlieghere wrote: > Greg, you requested changes to this revision, I guess because of the > dependencies. Anything here you'd like to see changed? I'm guessing the answer is no, but it would certainly help

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 261775. mib added a comment. Add error "consumption" following @labath comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 Files: lldb/source/Commands/CommandObject

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

labath added a comment. The test setup here seems unnecessarily complex. Wouldn't an inferior like this work better? void thread1() { pseudo_barrier_wait(g_barrier); // See other tests how this works. g_foo = 0; // break_here } int main() { pseudo_barrier_init(g_barrier1, 2);

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin added a comment. In D79308#2017348 , @labath wrote: > The test setup here seems unnecessarily complex. Wouldn't an inferior like > this work better? > > void thread1() { > pseudo_barrier_wait(g_barrier); // See other tests how this works. >

[Lldb-commits] [lldb] 283658c - [lldb/DWARF] Remove dead code in DWARFDebugInfoEntry

Author: Pavel Labath Date: 2020-05-04T15:37:22+02:00 New Revision: 283658c978bbac433b41c3d0ca2a3290bd7da0a4 URL: https://github.com/llvm/llvm-project/commit/283658c978bbac433b41c3d0ca2a3290bd7da0a4 DIFF: https://github.com/llvm/llvm-project/commit/283658c978bbac433b41c3d0ca2a3290bd7da0a4.diff

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin updated this revision to Diff 261805. jarin added a comment. Simplify the test based on the suggestion from labath@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files: lldb/source/Plugins/Proces

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 261815. mib added a comment. As agreed on IRC with @labath, the changes done to `PlatformPOSIX::ResolveExecutable` will be removed from this patch and submitted separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek created this revision. phosek added reviewers: smeenai, compnerd. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, cfe-commits, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMa

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

labath accepted this revision. labath added a comment. Yeah, as I said, I think this is already an improvement, which I am not sure that could be said of the other version, because of the expected-handling complexities. LGTM, modulo the overzealous conversion to AppendError.

[Lldb-commits] [lldb] 0151174 - [lldb/Host] Improve error messages on unowned read files

Author: Med Ismail Bennani Date: 2020-05-04T17:33:55+02:00 New Revision: 015117411e11458f9816ba4359246132164a4297 URL: https://github.com/llvm/llvm-project/commit/015117411e11458f9816ba4359246132164a4297 DIFF: https://github.com/llvm/llvm-project/commit/015117411e11458f9816ba4359246132164a4297.

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere added a comment. In D78825#2017204 , @labath wrote: > In D78825#2015326 , @JDevlieghere > wrote: > > > Greg, you requested changes to this revision, I guess because of the > > dependencies. Anything h

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere updated this revision to Diff 261844. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78825/new/ https://reviews.llvm.org/D78825 Files: lldb/source/Interpreter/CommandInterpreter.cpp lldb/test/Shell/Commands/command-source.test lldb/test/Shell/Driver/TestProcessAttach.te

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib closed this revision. mib added a comment. Landed in 015117411e11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 ___

[Lldb-commits] [lldb] 6b8d6f4 - [lldb/test] Fix wrong target command failure message on Windows

Author: Med Ismail Bennani Date: 2020-05-04T19:22:34+02:00 New Revision: 6b8d6f44592cd975919d535483c2aca7cd7857b8 URL: https://github.com/llvm/llvm-project/commit/6b8d6f44592cd975919d535483c2aca7cd7857b8 DIFF: https://github.com/llvm/llvm-project/commit/6b8d6f44592cd975919d535483c2aca7cd7857b8.

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

jankratochvil added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:579 + + const Address pc_addr(stackframe_sp->GetFrameCodeAddress()); + Please do not consider this as some requirement for LLDB project. But I do not like much this guessing what

[Lldb-commits] [lldb] 4ad5317 - [LLDB] Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

Author: shafik Date: 2020-05-04T13:57:42-07:00 New Revision: 4ad53177db756849d0be70643aee77fed13a00e1 URL: https://github.com/llvm/llvm-project/commit/4ad53177db756849d0be70643aee77fed13a00e1 DIFF: https://github.com/llvm/llvm-project/commit/4ad53177db756849d0be70643aee77fed13a00e1.diff LOG: [

[Lldb-commits] [PATCH] D79251: Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

shafik updated this revision to Diff 261920. shafik marked an inline comment as done. shafik added a comment. Removing `custom_new` since it is now unused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79251/new/ https://reviews.llvm.org/D79251 Files: lldb/test/API/lang/cpp/operators

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. Herald added a subscriber: fedor.sergeev. aprantl added a parent revision: D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units. When debugging a remote platform, the platform you get from

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the inline comment. Comment at: lldb/include/lldb/Host/HostInfoBase.h:96 /// Return the directory containing a specific Xcode SDK. - static std::s

[Lldb-commits] [PATCH] D79251: Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad53177db75: [LLDB] Fix overloaded operator new cases in TestCppOperators.py which currently… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 88d9e43 - [lldb/Expression] Make Language() const, NFC

Author: Vedant Kumar Date: 2020-05-04T14:02:43-07:00 New Revision: 88d9e4326f48041056c4db3506d30574c6e1d83c URL: https://github.com/llvm/llvm-project/commit/88d9e4326f48041056c4db3506d30574c6e1d83c DIFF: https://github.com/llvm/llvm-project/commit/88d9e4326f48041056c4db3506d30574c6e1d83c.diff

[Lldb-commits] [lldb] 47e9fd4 - Revert "[lldb/Expression] Make Language() const, NFC"

Author: Vedant Kumar Date: 2020-05-04T14:03:22-07:00 New Revision: 47e9fd47c71830e7a8987ef633f827cf4aff38fc URL: https://github.com/llvm/llvm-project/commit/47e9fd47c71830e7a8987ef633f827cf4aff38fc DIFF: https://github.com/llvm/llvm-project/commit/47e9fd47c71830e7a8987ef633f827cf4aff38fc.diff

[Lldb-commits] [lldb] a37caeb - [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

Author: Vedant Kumar Date: 2020-05-04T14:06:55-07:00 New Revision: a37caebc2d2d93573075633493e104e8664cf9e9 URL: https://github.com/llvm/llvm-project/commit/a37caebc2d2d93573075633493e104e8664cf9e9 DIFF: https://github.com/llvm/llvm-project/commit/a37caebc2d2d93573075633493e104e8664cf9e9.diff

[Lldb-commits] [lldb] 6951fe3 - [arm64] Remove an old special case that's not needed anymore.

Author: Davide Italiano Date: 2020-05-04T14:18:51-07:00 New Revision: 6951fe3989343c6605c397ac427acea4e39d2132 URL: https://github.com/llvm/llvm-project/commit/6951fe3989343c6605c397ac427acea4e39d2132 DIFF: https://github.com/llvm/llvm-project/commit/6951fe3989343c6605c397ac427acea4e39d2132.dif

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:42-43 + llvm_unreachable("unsupported length"); +memcpy(reinterpret_cast(m_data), + reinterpret_cast(bytes), size); + } l

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37caebc2d2d: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D77843?vs=261558&id=261934#toc Repository: rG LLVM Githu

[Lldb-commits] [lldb] 97db238 - [lldb] Fix -Wdtor-name warnings

Author: Jonas Devlieghere Date: 2020-05-04T14:32:28-07:00 New Revision: 97db238c17020678c61d7874fb92729c7c9d3cab URL: https://github.com/llvm/llvm-project/commit/97db238c17020678c61d7874fb92729c7c9d3cab DIFF: https://github.com/llvm/llvm-project/commit/97db238c17020678c61d7874fb92729c7c9d3cab.d

[Lldb-commits] [lldb] 9e35498 - [lldb/Expression] Make Language() const, NFC

Author: Vedant Kumar Date: 2020-05-04T14:42:01-07:00 New Revision: 9e3549804672c79d64eececab39019f4dfd2b7ea URL: https://github.com/llvm/llvm-project/commit/9e3549804672c79d64eececab39019f4dfd2b7ea DIFF: https://github.com/llvm/llvm-project/commit/9e3549804672c79d64eececab39019f4dfd2b7ea.diff

[Lldb-commits] [lldb] 58c7bf2 - Update LLDB filespec tests for remove_dots change

Author: Reid Kleckner Date: 2020-05-04T17:27:16-07:00 New Revision: 58c7bf246ec4056ca40ea37f16cb3314161863f7 URL: https://github.com/llvm/llvm-project/commit/58c7bf246ec4056ca40ea37f16cb3314161863f7 DIFF: https://github.com/llvm/llvm-project/commit/58c7bf246ec4056ca40ea37f16cb3314161863f7.diff

[Lldb-commits] [lldb] 3618381 - Clarify comment

Author: Adrian Prantl Date: 2020-05-04T18:15:30-07:00 New Revision: 36183811fb5455ea18cf7d9cd03748076f20573b URL: https://github.com/llvm/llvm-project/commit/36183811fb5455ea18cf7d9cd03748076f20573b DIFF: https://github.com/llvm/llvm-project/commit/36183811fb5455ea18cf7d9cd03748076f20573b.diff

[Lldb-commits] [PATCH] D79384: RFC: Add an API that allows iterating over a debug map's OSO's Modules

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda, teemperor, friss. Herald added a reviewer: jdoerfert. For Swift LLDB (but potentially also for module support in Clang-land) I need a way to accumulate the path remappings produced by `Module::RegisterXcodeSDK()`. Un

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM now. Pavel? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78825/new/ https://reviews.llvm.org/D78825 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

clayborg added a comment. Interesting approach to DWARF expression evaluation, though it might be simpler to leave the DWARFExpression as it is, and have the plug-in part only handle unknown opcodes. Right now if you want to add just one opcode, you must subclass and make a plug-in instance whe