[Lldb-commits] [lldb] 29bb046 - [LLDB] Remove xfail aarch64/linux from TestThreadPlanCommands.py

Author: Muhammad Omair Javaid Date: 2020-04-13T14:30:50+05:00 New Revision: 29bb046fe91ba13ddcbb0765e27f3164368b7c26 URL: https://github.com/llvm/llvm-project/commit/29bb046fe91ba13ddcbb0765e27f3164368b7c26 DIFF: https://github.com/llvm/llvm-project/commit/29bb046fe91ba13ddcbb0765e27f3164368b7c

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

teemperor closed this revision. teemperor added a comment. Somehow Phab forget to close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77214/new/ https://reviews.llvm.org/D77214 ___ lldb-commi

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. From what I understand the whole idea here is to just ask the external AST source to complete the record before we import them? If yes, then this seems like the right idea to m

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

teemperor added a subscriber: kkleine. teemperor added a comment. @kkleine yes, that's correct. So what should happen with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mail

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

vsk added a comment. The change looks reasonable to me. @davide? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk added reviewers: teemperor, labath. vsk added a comment. + Raphael, I suppose this is in a similar direction as D68691 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77843/new/ https://reviews.llvm.org/D77843

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

JDevlieghere updated this revision to Diff 257057. JDevlieghere added a comment. Add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77602/new/ https://reviews.llvm.org/D77602 Files: lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/ReproducerInstrumentation

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

aprantl added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:126 case 0: -retval = {"\\0", 2}; -break; +return {"\\0", 2}; case '\a': We have a lot of implementations of this function all over our projects (`git grep

[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).

JDevlieghere updated this revision to Diff 257068. JDevlieghere added a comment. Rebase + add unit tests Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77759/new/ https://reviews.llvm.org/D77759 Files: lldb/include/lldb/Utility/ReproducerInstrumentation.h l

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:126 case 0: -retval = {"\\0", 2}; -break; +return {"\\0", 2}; case '\a': aprantl wrote: > We have a lot of implementations

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

JDevlieghere added a comment. This looks great, especially with the extra unit tests. Thanks Vedant. Have you asked the foundation people about the ASCII support in NSString? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77843/new/ https://reviews

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

shafik added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:50 + StringPrinterBufferPointer(StringPrinterBufferPointer &&rhs) + : m_data(rhs.m_data), m_size(rhs.m_size), m_deleter(rhs.m_deleter) { +rhs.m_data = nullptr; `m_del

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

shafik added inline comments. Comment at: lldb/unittests/DataFormatter/StringPrinterTests.cpp:109 + EXPECT_TRUE(matches({"\0", 1}, QUOTE(""))); + EXPECT_TRUE(matches("\a", QUOTE("\\a"))); + EXPECT_TRUE(matches("\b", QUOTE("\\u{8}"))); We have [raw string lite

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. Herald added a reviewer: herhut. Herald added subscribers: frgossen, grosul1, Joonsoo. Hi @lenary, I added a PoC patch D78035 to complete ThinLTO based on this patch. There is also a missed hook in `ParallelCG.cpp` @@ -28,6 +28,7 @@ st

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 257138. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm-c/Core.h

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, labath. jasonmolenda added a project: LLDB. Herald added subscribers: danielkiss, kristof.beyls. I found this on an AAarch64 target, where we use a frame pointer register on Darwin. UnwindAssemblyInstEmulation iterates o