[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/dylib.h:50 + FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, + NULL, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (char

[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

labath updated this revision to Diff 255916. labath added a comment. Cleaning up the patch. It should be ready now, I'm just going to give it one more spin on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77662/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:190-195 +const_iterator left = llvm::lower_bound(m_map, unique_cstr, Compare()); +if (left != m_map.end() && left->cstring != unique_

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255923. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

labath updated this revision to Diff 255921. labath edited the summary of this revision. labath added a comment. Remove bogus runCmd. Everything should check out now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77662/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 256022. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testca

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 256027. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h lldb/source/AP

[Lldb-commits] [lldb] e796c77 - [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

Author: Walter Erquinigo Date: 2020-04-08T09:52:59-07:00 New Revision: e796c77b26acab0b530ac6516f1dda21b8494733 URL: https://github.com/llvm/llvm-project/commit/e796c77b26acab0b530ac6516f1dda21b8494733 DIFF: https://github.com/llvm/llvm-project/commit/e796c77b26acab0b530ac6516f1dda21b8494733.di

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

This revision was automatically updated to reflect the committed changes. Closed by commit rGe796c77b26ac: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints… (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [lldb] 8e40987 - Fix e796c77b26acab0b530ac6516f1dda21b8494733

Author: Walter Erquinigo Date: 2020-04-08T10:48:01-07:00 New Revision: 8e40987e1897276308728d28484fbe93f0a7a1e0 URL: https://github.com/llvm/llvm-project/commit/8e40987e1897276308728d28484fbe93f0a7a1e0 DIFF: https://github.com/llvm/llvm-project/commit/8e40987e1897276308728d28484fbe93f0a7a1e0.di

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 _

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide updated this revision to Diff 256063. davide added a comment. Herald added a reviewer: jdoerfert. Added test, updated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77698/new/ https://reviews.llvm.org/D77698 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEnt

[Lldb-commits] [lldb] be3f8a8 - [commands] Support autorepeat in SBCommands

Author: Walter Erquinigo Date: 2020-04-08T10:54:14-07:00 New Revision: be3f8a8e1b95db1a8bdcc7a66ba27f8a6ea65469 URL: https://github.com/llvm/llvm-project/commit/be3f8a8e1b95db1a8bdcc7a66ba27f8a6ea65469 DIFF: https://github.com/llvm/llvm-project/commit/be3f8a8e1b95db1a8bdcc7a66ba27f8a6ea65469.di

[Lldb-commits] [lldb] d51b38f - [DWARF] Not all the constant variables are "static".

Author: Davide Italiano Date: 2020-04-08T11:07:19-07:00 New Revision: d51b38f1b3a34c2a8e1869af6434ebd743ce7a5e URL: https://github.com/llvm/llvm-project/commit/d51b38f1b3a34c2a8e1869af6434ebd743ce7a5e DIFF: https://github.com/llvm/llvm-project/commit/d51b38f1b3a34c2a8e1869af6434ebd743ce7a5e.dif

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The code looks good to me. I'll defer to Adrian as to whether the test is robust, though it also seems reasonable to deal with a failure caused by llvm changes when it happens. CHANGES SI

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide closed this revision. davide added a comment. commit d51b38f1b3a34c2a8e1869af6434ebd743ce7a5e (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Apr 8 11:06:00 2020 -0700 [DWARF] Not al

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe3f8a8e1b95: [commands] Support autorepeat in SBCommands (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7744

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau added a comment. In D77587#1965604 , @efriedma wrote: > If I'm following correctly, this should apply on its own. Then you're > expecting the following API changes: > > 1. getNumElements() will move from VectorType to FixedVectorType. Existing

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256100. ctetreau added a comment. Herald added subscribers: lldb-commits, frgossen, grosul1, Joonsoo, kerbowa, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, nhaehnle, jve

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256101. ctetreau added a comment. Fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. I don't have commit access, can someone with access commit all three approved CLs in this stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___

[Lldb-commits] [lldb] ff1658b - Fix -Wdeprecated-copy warning in XcodeSDK.

Author: Eric Christopher Date: 2020-04-08T15:12:53-07:00 New Revision: ff1658b167c835ca55f554a3ad5aac444a6f9c9c URL: https://github.com/llvm/llvm-project/commit/ff1658b167c835ca55f554a3ad5aac444a6f9c9c DIFF: https://github.com/llvm/llvm-project/commit/ff1658b167c835ca55f554a3ad5aac444a6f9c9c.di

[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix inline replay for functions returning string as (char*, size_t).

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: abidh. JDevlieghere added a parent revision: D77602: [lldb/Reproducers] Support inline replay. Several SB API functions return strings a `(char*, size_t)` pair. During capture, we serialize an e

[Lldb-commits] [lldb] b0bdaf9 - [lldb/Python] Add lldbconfig module to make the lldb module configurable

Author: Jonas Devlieghere Date: 2020-04-08T15:59:24-07:00 New Revision: b0bdaf9ba2bfa9e099c7cb650650133f6ea2024f URL: https://github.com/llvm/llvm-project/commit/b0bdaf9ba2bfa9e099c7cb650650133f6ea2024f DIFF: https://github.com/llvm/llvm-project/commit/b0bdaf9ba2bfa9e099c7cb650650133f6ea2024f.d

[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0bdaf9ba2bf: [lldb/Python] Add lldbconfig module to make the lldb module configurable (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D77661?

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

amccarth added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:477 ifeq (1,$(USE_LIBDL)) - ifneq ($(OS),NetBSD) + ifeq (,$(filter $(OS), NetBSD Windows_NT)) LDFLAGS += -ldl I'm no expert in makefil

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

jarin created this revision. jarin added reviewers: labath, clayborg. jarin added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. jarin retitled this revision from "Fix incorrect L1 cache flushing" to "Fix incorrect L1 inferior memory cache flushing". As discussed in https://revi

[Lldb-commits] [lldb] e7db1ae - [lldb/Docs] Elaborate on reproducer testing

Author: Jonas Devlieghere Date: 2020-04-08T20:10:52-07:00 New Revision: e7db1aec3bdb833832056894f5eba2f359a7c384 URL: https://github.com/llvm/llvm-project/commit/e7db1aec3bdb833832056894f5eba2f359a7c384 DIFF: https://github.com/llvm/llvm-project/commit/e7db1aec3bdb833832056894f5eba2f359a7c384.d

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere added a comment. In D77588#1968700 , @labath wrote: > I think the code looks ok now, though I have to say I am still somewhat fuzzy > on what exactly will this patch enable. I think I understand the capture > part, but what happens during re

[Lldb-commits] [PATCH] D77771: [lldb/Docs] Document driver and inline replay.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Repository: rLLDB LLDB https://reviews.llvm.org/D1 Files: lldb/docs/resources/reproducers.rst Index: lldb/docs/resources/reproducers.rst === --- ll

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

clayborg added a comment. I am not a pro at the gtest stuff, but this was very hard to follow and figure out what these tests are doing. Comment at: lldb/source/Target/Memory.cpp:23-24 // MemoryCache constructor -MemoryCache::MemoryCache(Process &process) +MemoryCache::Memory