[Lldb-commits] [lldb] f13ce15 - [DebugInfo] Rename getOffset() to getContribution(). NFC.

2020-04-03 Thread Igor Kudrin via lldb-commits
Author: Igor Kudrin Date: 2020-04-03T14:15:53+07:00 New Revision: f13ce15d441095493030404ab31eddb0fc08ca42 URL: https://github.com/llvm/llvm-project/commit/f13ce15d441095493030404ab31eddb0fc08ca42 DIFF: https://github.com/llvm/llvm-project/commit/f13ce15d441095493030404ab31eddb0fc08ca42.diff L

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

2020-04-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D77287#1957472 , @compnerd wrote: > Thanks for the hint about the string conversion, however, I think that it's > going to complicate things as the string is going to be a mixture of UTF-8 > and UTF-16 content. That's true. O

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

2020-04-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me, though I can't say I'm much of a thread plan expert (but then again, I don't know if anyone except you is). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

2020-04-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, I think we've done what we can here. In D76471#1958814 , @aprantl wrote: > > Yeah, it seems acceptable. The "sdk type" argument still seems somewha

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

2020-04-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. looks good Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:22 +output = response['body']['result'] +self.assertTrue(contains_string in output, +("""Verify %s by checking the command output

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

2020-04-03 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. No need to split this into multiples revisions. It is just a rewrite of some odd nesting. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943 +// Mak

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

2020-04-03 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. Could you explain, why this was done please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ https://reviews.llvm.org/D77336 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D77336#1959094 , @kwk wrote: > Could you explain, why this was done please? As D77327 removes `num_die_matches` as now it is a callback so one cannot use it anymore after D77327

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

2020-04-03 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These three `SearchFilter` methods all return `true` by their default implementation: virtual bool ModulePasses(const FileSpec &spec); virtual bool ModulePasses(const lldb::ModuleSP &module_sp);

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

2020-04-03 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit just tries to invert some `if`'s logic to `return`/`continue` early. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77377 Files: lldb/source/Breakpoint/BreakpointRes

[Lldb-commits] [lldb] 107200a - [lldb][nfc] early exit/continue

2020-04-03 Thread Konrad Kleine via lldb-commits
Author: Konrad Kleine Date: 2020-04-03T14:50:08+02:00 New Revision: 107200ae0a032f2e6024f45d665a0f2b7c732a62 URL: https://github.com/llvm/llvm-project/commit/107200ae0a032f2e6024f45d665a0f2b7c732a62 DIFF: https://github.com/llvm/llvm-project/commit/107200ae0a032f2e6024f45d665a0f2b7c732a62.diff

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

2020-04-03 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG107200ae0a03: [lldb][nfc] early exit/continue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77377/new/ https://reviews.llvm.org/D77377 F

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true. virtual bool ModulePasses(const FileSpec &spec); I am not against it but FYI in a paragraph

[Lldb-commits] [lldb] d144087 - [lldb/Support] Treat empty FileSpec as an invalid file.

2020-04-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-04-03T09:29:22-07:00 New Revision: d144087c963d8189bb4aeaa7800dcb9f93ac84db URL: https://github.com/llvm/llvm-project/commit/d144087c963d8189bb4aeaa7800dcb9f93ac84db DIFF: https://github.com/llvm/llvm-project/commit/d144087c963d8189bb4aeaa7800dcb9f93ac84db.d

[Lldb-commits] [lldb] 63bfb3a - [lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS

2020-04-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-04-03T09:29:22-07:00 New Revision: 63bfb3a81ba2aef8d0444b58aafc868af38a623c URL: https://github.com/llvm/llvm-project/commit/63bfb3a81ba2aef8d0444b58aafc868af38a623c DIFF: https://github.com/llvm/llvm-project/commit/63bfb3a81ba2aef8d0444b58aafc868af38a623c.d

[Lldb-commits] [PATCH] D77337: [lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS

2020-04-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG63bfb3a81ba2: [lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D77337?

[Lldb-commits] [PATCH] D77351: [lldb/Support] Treat empty FileSpec as an invalid file.

2020-04-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd144087c963d: [lldb/Support] Treat empty FileSpec as an invalid file. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Why did you abandon this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61548/new/ https://reviews.llvm.org/D61548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:524 DIEInfoArray die_info_array; - if (FindByName(name, die_info_array)) -DWARFMappedHash::ExtractDIEArray(die_info_ar

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

2020-04-03 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added a comment. Okay, thanks to some help from @JDevlieghere I was able to get a test going for this. I think that the basic test is sufficient for this. I think that the path sanitizing and conversion should be a subsequent change. CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

2020-04-03 Thread Raul Tambre via Phabricator via lldb-commits
tambre added a comment. In D61548#1960310 , @JDevlieghere wrote: > Why did you abandon this? It's been lingering for a long time, so I wanted to get it off my dashboard. The patch also requires updating as the file has moved. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

2020-04-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl -o %t.exe -- %s We should probably have a `lit.local.cfg` in the Windows directory with ``` if

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

2020-04-03 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 254883. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h lldb/test/Shell/Process/Win

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

2020-04-03 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd marked an inline comment as done. compnerd added inline comments. Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl -o %t.exe -- %s JDevlieghere wrote: > We should probably h

[Lldb-commits] [lldb] 8023752 - [nfc] [lldb] Unindent code - obvious part

2020-04-03 Thread Jan Kratochvil via lldb-commits
Author: Jan Kratochvil Date: 2020-04-03T21:58:11+02:00 New Revision: 80237523193d1311e8744b84faa077a1295d80da URL: https://github.com/llvm/llvm-project/commit/80237523193d1311e8744b84faa077a1295d80da DIFF: https://github.com/llvm/llvm-project/commit/80237523193d1311e8744b84faa077a1295d80da.diff

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 254900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 254898. jankratochvil marked an inline comment as done. jankratochvil added a comment. I have checked in the really obvious parts as rG80237523193d . The remainder is left here - altho

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D76814#1958988 , @labath wrote: > Looks fine to me, though I can't say I'm much of a thread plan expert (but > then again, I don't know if anyone except you is). That's not a great situation, but it is where we currently are.

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

2020-04-03 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ https://reviews.llvm.org/D77336

[Lldb-commits] [lldb] 2c1c57a - Make ThreadPlanTracers use TID & Process rather than Thread *.

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 2c1c57a1df8187870df114af666bacbd413699f7 URL: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7 DIFF: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7.diff LO

[Lldb-commits] [lldb] 61e8e68 - Move thread plan stacks into the Process, indexed by TID.

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 61e8e6882de7c89933d3cc4c4d44719679e4b4f0 URL: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0 DIFF: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0.diff LO

[Lldb-commits] [lldb] 1893065 - Allow the ThreadPlanStackMap to hold the thread plans for threads

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 1893065d7bf5c41fbd0dbbee0a39933d3a99806b URL: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b DIFF: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b.diff LO

[Lldb-commits] [lldb] e4598dc - Make ThreadPlans use TID and Process, rather than Thread *.

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: e4598dc04a1f582e18b6721ae8ad15cad3ddd48b URL: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b DIFF: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b.diff LO

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe4598dc04a1f: Make ThreadPlans use TID and Process, rather than Thread *. (authored by jingham). Changed prior to commit:

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG61e8e6882de7: Move thread plan stacks into the Process, indexed by TID. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75880/new/ http

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

2020-04-03 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Does anyone know why harbormaster is useless? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2014 -if (!method_die_offsets.empty()) { - DWARFDebugInfo &debug_info = dwarf->DebugInfo(); kwk w

[Lldb-commits] [PATCH] D75720: Make ThreadPlanTracer use {Process, TID} rather than Thread to find it's underlying thread...

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c1c57a1df81: Make ThreadPlanTracers use TID & Process rather than Thread *. (authored by jingham). Repository: rG LLVM

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1893065d7bf5: Allow the ThreadPlanStackMap to hold the thread plans for threads that were not… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] fcab66d - [lldb] Findtypes -gmodules fix for too many matches

2020-04-03 Thread Jan Kratochvil via lldb-commits
Author: Jan Kratochvil Date: 2020-04-04T00:15:06+02:00 New Revision: fcab66d5fe53fc3c318b0d0c4ef1bb4a43a7744f URL: https://github.com/llvm/llvm-project/commit/fcab66d5fe53fc3c318b0d0c4ef1bb4a43a7744f DIFF: https://github.com/llvm/llvm-project/commit/fcab66d5fe53fc3c318b0d0c4ef1bb4a43a7744f.diff

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2387 // dsymutil. - if (num_die_matches < max_matches) { + if (types.GetSize() < max_matches) { UpdateExternalModule

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 254931. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

2020-04-03 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfcab66d5fe53: [lldb] Findtypes -gmodules fix for too many matches (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ http

[Lldb-commits] [lldb] 2d658c5 - Disable two new tests on Windows. They are failing but the logs are not helpful.

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T17:14:56-07:00 New Revision: 2d658c56d57c4b355635b2bab38ba97a598c7393 URL: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393 DIFF: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393.diff LO

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds support for commands created through the API to support autorepeat. This covers the case of single word and multiword commands. Comprehensive

[Lldb-commits] [lldb] 7255793 - [intel-mpx] Delete an unnecessary license header

2020-04-03 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-04-03T17:27:37-07:00 New Revision: 725579379deea21bb4201731fe6d6e70ed98961d URL: https://github.com/llvm/llvm-project/commit/725579379deea21bb4201731fe6d6e70ed98961d DIFF: https://github.com/llvm/llvm-project/commit/725579379deea21bb4201731fe6d6e70ed98961d.di

[Lldb-commits] [PATCH] D77328: [intel-mpx] Delete an unnecessary license header

2020-04-03 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG725579379dee: [intel-mpx] Delete an unnecessary license header (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 3ccd454 - Fix unused variable, format, and format string warnings.

2020-04-03 Thread Eric Christopher via lldb-commits
Author: Eric Christopher Date: 2020-04-03T17:58:59-07:00 New Revision: 3ccd454c102b069d2230a18cfe16b84a5f005fc8 URL: https://github.com/llvm/llvm-project/commit/3ccd454c102b069d2230a18cfe16b84a5f005fc8 DIFF: https://github.com/llvm/llvm-project/commit/3ccd454c102b069d2230a18cfe16b84a5f005fc8.di

[Lldb-commits] [lldb] 48ba745 - This test is failing on the Ubuntu bot but the bot log doesn't

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T18:04:02-07:00 New Revision: 48ba745eacf883080152fe16b5b1305657d001ca URL: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca DIFF: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca.diff LO

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

2020-04-03 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D77450: Fix LLDB debug builds

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: clayborg, labath, jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A recent change in ThreadPlans introduced this little compilation error. Seems to be related to the work around https://reviews.llvm.org/D76814.

[Lldb-commits] [lldb] ca47ac3 - [source maps] Fix remove, insert-after and replace

2020-04-03 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-04-03T19:15:56-07:00 New Revision: ca47ac3d5f6f8483d330c96a63f1cd862e667856 URL: https://github.com/llvm/llvm-project/commit/ca47ac3d5f6f8483d330c96a63f1cd862e667856 DIFF: https://github.com/llvm/llvm-project/commit/ca47ac3d5f6f8483d330c96a63f1cd862e667856.di

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 254981. wallace added a comment. address comments` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77324/new/ https://reviews.llvm.org/D77324 Files: lldb/source/Interpreter/OptionValuePathMappings.cpp lldb/t

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

2020-04-03 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca47ac3d5f6f: [source maps] Fix remove, insert-after and replace (authored by Walter Erquinigo , committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 9661225 - Fix LLDB debug builds

2020-04-03 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-04-03T19:49:38-07:00 New Revision: 966122524b562aab42e7afc8f44c23ea105b27f3 URL: https://github.com/llvm/llvm-project/commit/966122524b562aab42e7afc8f44c23ea105b27f3 DIFF: https://github.com/llvm/llvm-project/commit/966122524b562aab42e7afc8f44c23ea105b27f3.di

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description @labath raised

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 254990. wallace edited the summary of this revision. wallace added a comment. improve description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/bindings

[Lldb-commits] [PATCH] D77450: Fix LLDB debug builds

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ah, great, thanks. Looks like the standalone Xcode debug build doesn't pass LDB_CONFIGURATION_DEBUG. That's a little odd, but the patch is fine. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. It's great to add this capability. But if you pass a nullptr, then the exact previous command will be repeated. That's sometimes what you want, but often not. For instance: (lldb) source list -f foo -l 10 ... (lldb) You DON'T want those same source lines to be dumpe

[Lldb-commits] [PATCH] D77450: Fix LLDB debug builds

2020-04-03 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG966122524b56: Fix LLDB debug builds (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77450/new/ https://review

[Lldb-commits] [lldb] 3270748 - The thread plan list test is failing at least on Ubuntu Linux.

2020-04-03 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-04-03T20:06:11-07:00 New Revision: 327074812707d41f492a0e23940430422a9cd237 URL: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237 DIFF: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237.diff LO

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

2020-04-03 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. For instance, maybe instead of passing in a bool, you could pass in the repeat command? So when you create the command, if you pass in None, you get no repeat, if you pass in "" you get the exact command line repeated, and if you pass in anything else, that will be the

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

2020-04-03 Thread walter erquinigo via Phabricator via lldb-commits
wallace planned changes to this revision. wallace added a comment. Very good idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 ___ lldb-commits mailing list