[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248404. tatyana-krasnukha added a comment. Removed TestFixIts.py as those changes relate to the parent revision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: l

[Lldb-commits] [lldb] 7a11cc0 - [lldb][test] TestFileHandle: flush the output after write

Author: Tatyana Krasnukha Date: 2020-03-05T11:45:28+03:00 New Revision: 7a11cc06a4fd057f66a33830880ed567eb6d5eab URL: https://github.com/llvm/llvm-project/commit/7a11cc06a4fd057f66a33830880ed567eb6d5eab DIFF: https://github.com/llvm/llvm-project/commit/7a11cc06a4fd057f66a33830880ed567eb6d5eab.d

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

labath added a comment. Thanks for splitting this up. This seems fine to me. I'll leave the approval to the type system folks. I don't know how much we care about the size of the Type class. If we did, there are ways this could be optimized. But I guess the fact that we stored `m_is_complete_o

[Lldb-commits] [lldb] aafd65a - [lldb][test] Replace HandleCommand with runCmd to check that a command succeeded

Author: Tatyana Krasnukha Date: 2020-03-05T12:37:08+03:00 New Revision: aafd65ad9ff0def1e79889074687f7d0b05313e2 URL: https://github.com/llvm/llvm-project/commit/aafd65ad9ff0def1e79889074687f7d0b05313e2 DIFF: https://github.com/llvm/llvm-project/commit/aafd65ad9ff0def1e79889074687f7d0b05313e2.d

[Lldb-commits] [lldb] d2e397f - [lldb][test] These tests don't fail on Windows anymore

Author: Tatyana Krasnukha Date: 2020-03-05T12:37:08+03:00 New Revision: d2e397f15616ef998663e2c6ef698528bd69e189 URL: https://github.com/llvm/llvm-project/commit/d2e397f15616ef998663e2c6ef698528bd69e189 DIFF: https://github.com/llvm/llvm-project/commit/d2e397f15616ef998663e2c6ef698528bd69e189.d

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

labath added a comment. Thanks for splitting this up. This does make things much easier to understand. I don't have any real objections to this, but I have some "thoughts" in inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:214-215

[Lldb-commits] [lldb] c6a3895 - [lldb] Delete two overloads of Disassembler::Disassemble

Author: Pavel Labath Date: 2020-03-05T11:00:37+01:00 New Revision: c6a38957a7e5e2ec837470a62aff25abfbf6d397 URL: https://github.com/llvm/llvm-project/commit/c6a38957a7e5e2ec837470a62aff25abfbf6d397 DIFF: https://github.com/llvm/llvm-project/commit/c6a38957a7e5e2ec837470a62aff25abfbf6d397.diff

[Lldb-commits] [lldb] ea68462 - [lldb] Make Disassembler::PrintInstructions a method

Author: Pavel Labath Date: 2020-03-05T12:07:49+01:00 New Revision: ea68462ed11cb70b40543059007a328edd26aea6 URL: https://github.com/llvm/llvm-project/commit/ea68462ed11cb70b40543059007a328edd26aea6 DIFF: https://github.com/llvm/llvm-project/commit/ea68462ed11cb70b40543059007a328edd26aea6.diff

[Lldb-commits] [lldb] ef38283 - [lldb][test] Temporarily X-fail TestPtrRefs.py and TestPtrRefsObjC.py

Author: Tatyana Krasnukha Date: 2020-03-05T14:38:44+03:00 New Revision: ef38283a0980c0ca3d4e866eceec189807eec7f9 URL: https://github.com/llvm/llvm-project/commit/ef38283a0980c0ca3d4e866eceec189807eec7f9 DIFF: https://github.com/llvm/llvm-project/commit/ef38283a0980c0ca3d4e866eceec189807eec7f9.d

[Lldb-commits] [lldb] 04592d5 - [lldb] s/ExecutionContext/Target in Disassembler

Author: Pavel Labath Date: 2020-03-05T14:46:39+01:00 New Revision: 04592d5b23178cfacfd0817f58fca8a0a24a71c7 URL: https://github.com/llvm/llvm-project/commit/04592d5b23178cfacfd0817f58fca8a0a24a71c7 DIFF: https://github.com/llvm/llvm-project/commit/04592d5b23178cfacfd0817f58fca8a0a24a71c7.diff

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

labath created this revision. labath added reviewers: jasonmolenda, JDevlieghere, xiaobai. Herald added subscribers: fedor.sergeev, krytarowski, mgorny, jyknight. Herald added a project: LLDB. It isn't used anywhere (except on imaginary triples like sparc-apple-ios) and it also violates plugin sep

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. The only time this plugin gets activated is when there's been some problem with the arch triple and we end up defaulting to this unwinder, which never works anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

aprantl created this revision. aprantl added reviewers: jasonmolenda, friss. Herald added subscribers: aheejin, sbc100. This patch detects when an ios process runs on a macOS host and updates the target triple with the "simulator" environment. This is part of https://bugs.swift.org/browse/SR-1197

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

aemerson updated this revision to Diff 248567. aemerson added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @omjavaid can you look over the lldb changes? I don't have the hardware to be able to actually run this test but I've tried to relax the checks. Reposi

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

xiaobai accepted this revision. xiaobai added a comment. LGTM. If UnwindLLDB is //the// unwinder, that makes things a little easier for plugin separation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75680/new/ https://reviews.llvm.org/D75680

[Lldb-commits] [PATCH] D75294: [lldb][NFC] Minor code cleanup in Editline.cpp

teemperor added a comment. Actually this LGTM (Jonas already caught the thing I wanted to complain about) but the commit message needs some improvements: - The title should contain "[NFC]" (which is short for "No functional change" and just means that you didn't change any functionality here. M

[Lldb-commits] [lldb] d0e8abc - [lldb] Fix more typos in log statements in ClangASTSource

Author: Raphael Isemann Date: 2020-03-05T14:13:09-08:00 New Revision: d0e8abc4381b3a656cde07a7844628535b8d864c URL: https://github.com/llvm/llvm-project/commit/d0e8abc4381b3a656cde07a7844628535b8d864c DIFF: https://github.com/llvm/llvm-project/commit/d0e8abc4381b3a656cde07a7844628535b8d864c.dif

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham created this revision. jingham added reviewers: friss, clayborg. Herald added subscribers: lldb-commits, danielkiss, kristof.beyls. Herald added a project: LLDB. This is the first part of a multi-part commit. This change makes the ThreadPlans use the process & TID to specify which thread

[Lldb-commits] [lldb] 4679691 - [lldb/Core] Minor code cleanup in Editline.cpp (NFC)

Author: Shu Anzai Date: 2020-03-05T16:15:26-08:00 New Revision: 467969161d94336cb0f091dff22bee403de71ffa URL: https://github.com/llvm/llvm-project/commit/467969161d94336cb0f091dff22bee403de71ffa DIFF: https://github.com/llvm/llvm-project/commit/467969161d94336cb0f091dff22bee403de71ffa.diff LOG

[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

aprantl created this revision. aprantl added reviewers: shafik, teemperor. aprantl added a child revision: D75488: Preserve the owning module information from DWARF in the synthesized AST. Based on a suggestion from Richard Smith, this switches TypeSystemClang over to Decl*::CreateDeserialized()

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham added a comment. Another point to make clear here. You might wonder whether ThreadPlan::GetThread should return an Optional or something like that, since there might not be a Thread associated with the ThreadPlan. I tried that out but it made the code really ugly. When I thought about

[Lldb-commits] [PATCH] D75294: [lldb][NFC] Minor code cleanup in Editline.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG467969161d94: [lldb/Core] Minor code cleanup in Editline.cpp (NFC) (authored by gedatsu217, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D75294?vs=247953&id=248628#toc

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

aprantl updated this revision to Diff 248634. aprantl added a comment. Here is a more principled variant of the patch. I pushed the logic down to debugserver, so we don't need to guess or fixup anything in LLDB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75696/new/ https://reviews.l

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

friss added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:601-607 +static bool IsMacOSHost() { + static uint32_t g_host_cputype = 0; + size_t len = sizeof(uint32_t); + if (!g_host_cputype) +::sysctlbyname("hw.cputype", &g_host_cputype, &l

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham updated this revision to Diff 248638. jingham added a comment. Attempt to appease clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75711/new/ https://reviews.llvm.org/D75711 Files: lldb/include/lldb/Target/ThreadPlan.h lldb/

[Lldb-commits] [PATCH] D75720: Make ThreadPlanTracer use {Process, TID} rather than Thread to find it's underlying thread...

jingham created this revision. jingham added reviewers: friss, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next patch in the sequence started by: https://reviews.llvm.org/D75711 though it isn't formally dependent on it. See the summary of that pa

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Overall looks fine, Fred's comment is correct, nb you want to test it with `#if TARGET_OS_OSX == 1`, it's always defined either to 0 or 1. Comment at: lldb/test/

[Lldb-commits] [lldb] 226d52b - [lldb/DWARF] Replace C style casts with static_cast<> (NFC)

Author: Jonas Devlieghere Date: 2020-03-05T21:24:51-08:00 New Revision: 226d52b1faadbe4a770d5738ac9d2c5bbc110d3d URL: https://github.com/llvm/llvm-project/commit/226d52b1faadbe4a770d5738ac9d2c5bbc110d3d DIFF: https://github.com/llvm/llvm-project/commit/226d52b1faadbe4a770d5738ac9d2c5bbc110d3d.d

[Lldb-commits] [lldb] 621d969 - [lldb/DWARF] Fix 80 col formatting (NFC)

Author: Jonas Devlieghere Date: 2020-03-05T21:28:23-08:00 New Revision: 621d969a964107612906e00820d20ddbb46d736f URL: https://github.com/llvm/llvm-project/commit/621d969a964107612906e00820d20ddbb46d736f DIFF: https://github.com/llvm/llvm-project/commit/621d969a964107612906e00820d20ddbb46d736f.d

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

labath added a comment. In D75680#1908368 , @xiaobai wrote: > If UnwindLLDB is //the// unwinder, that makes things a little easier for > plugin separation. Yep, I think that after this we can just move UnwindLLDB into the core libraries. But that is a

[Lldb-commits] [lldb] 71c1c18 - [lldb] Delete UnwindMacOSXFrameBackchain

Author: Pavel Labath Date: 2020-03-06T08:27:13+01:00 New Revision: 71c1c184744c072a32c0d7f4341525821dd459dc URL: https://github.com/llvm/llvm-project/commit/71c1c184744c072a32c0d7f4341525821dd459dc DIFF: https://github.com/llvm/llvm-project/commit/71c1c184744c072a32c0d7f4341525821dd459dc.diff