[Lldb-commits] [lldb] d4eca12 - [lldb/gdb-remote] Add support for the qOffsets packet

Author: Pavel Labath Date: 2020-02-26T10:18:58+01:00 New Revision: d4eca120ac0af2a805c19301412bf843a71c14b5 URL: https://github.com/llvm/llvm-project/commit/d4eca120ac0af2a805c19301412bf843a71c14b5 DIFF: https://github.com/llvm/llvm-project/commit/d4eca120ac0af2a805c19301412bf843a71c14b5.diff

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4eca120ac0a: [lldb/gdb-remote] Add support for the qOffsets packet (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://r

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. > Who is the owner of this MemoryCache code I should ask for a review? It sounds like the fix will be fairly straightforward. I think anyone on this thread should be able to review that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

teemperor abandoned this revision. teemperor added a comment. Herald added a subscriber: JDevlieghere. This was fixed/tested in D73024 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65872/new/ https://reviews.llvm.org/D65872

[Lldb-commits] [PATCH] D75164: [lldb][cmake] Move remove_modue_flags macro to AddLLDB.cmake

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This is currently hidden in the Host CMakeLists but we should also use this macro in other parts of LLDB where we have ObjC++ sources. Reposit

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

teemperor updated this revision to Diff 246673. teemperor added a comment. - rebased on top of D75164 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74891/new/ https://reviews.llvm.org/D74891 Files: lldb/tools/debugserver/CM

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246679. unnar marked 5 inline comments as done. unnar added a comment. In D74759#1880499 , @labath wrote: > Have you done a proper complexity analysis here? I doubt the `O(log n)` claim > is true in general. It would ha

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:642 + B ComputeUpperBounds(int lo, int hi) { +if (lo > hi) return B(); + jarin wrote: > Here, B() should be the min value of type B, no? Perhaps this should be > `std::numeric_lim

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246681. unnar added a comment. Added reference to Wikipedia article. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h lldb/unittests/Utility/RangeMapTest.cpp Ind

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. Thanks for adding the tests. They look good. Could you split them off into a separate patch? I believe @teemperor wanted (and I do agree it's a good idea) to check them in first in order to demonstrate that this patch does not change the behavior (or to make it what exac

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246716. unnar marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h Index: lldb/include/lldb/Utility/RangeMap.h

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar created this revision. unnar added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere, arphaman. Herald added a project: LLDB. This adds unit tests for FindEntryIndexesThatContain, this is done in preparation for changing the logic of the function. Reposito

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. In D74759#1893186 , @unnar wrote: > In D74759#1880499 , @labath wrote: > > > Have you done a proper complexity analysis here? I doubt the `O(log n)` > > claim is true in general. It would ha

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Sure, removed tests from this patch. They are now at D75180 Comment at: lldb/unittests/Utility/RangeMapTest.cpp:22 +const std::vector FindEntryIndexes(uint32_t address, + Ran

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. Are you able to commit this yourself ? Comment at: lldb/unittests/Utility/RangeMapTest.cpp:23 +std::vector FindEntryIndexes(uint32_t address, +

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. In D74759#1893450 , @labath wrote: > In D74759#1893186 , @unnar wrote: > > > In D74759#1880499 , @labath wrote: > > > > > Have you done a proper comple

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar updated this revision to Diff 246721. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75180/new/ https://reviews.llvm.org/D75180 Files: lldb/unittests/Utility/RangeMapTest.cpp Index: lldb/unittests/Utility/RangeMapTest.cpp =

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar marked 2 inline comments as done. unnar added a comment. No, I can't. If you could submit this for me it would be great. Comment at: lldb/unittests/Utility/RangeMapTest.cpp:23 +std::vector FindEntryIndexes(uint32_t address, + Ra

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

labath added inline comments. Comment at: lldb/unittests/Utility/RangeMapTest.cpp:23 +std::vector FindEntryIndexes(uint32_t address, + RangeDataVectorT map) { + std::vector result; unnar wrote: > labath wrote: > > This

[Lldb-commits] [lldb] 594130d - Add unit tests for RangeDataVector::FindEntryIndexesThatContain

Author: Unnar Freyr Erlendsson Date: 2020-02-26T16:47:42+01:00 New Revision: 594130db0a56c3c3d889f750c5c971fac6f33594 URL: https://github.com/llvm/llvm-project/commit/594130db0a56c3c3d889f750c5c971fac6f33594 DIFF: https://github.com/llvm/llvm-project/commit/594130db0a56c3c3d889f750c5c971fac6f33

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

This revision was automatically updated to reflect the committed changes. Closed by commit rG594130db0a56: Add unit tests for RangeDataVector::FindEntryIndexesThatContain (authored by unnar, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 7822c8c - [lldb/test] Skip running a test under ASan, it intentionally double-frees

Author: Vedant Kumar Date: 2020-02-26T10:11:39-08:00 New Revision: 7822c8c03e9fe8c857da21c4ccbe28396b43130d URL: https://github.com/llvm/llvm-project/commit/7822c8c03e9fe8c857da21c4ccbe28396b43130d DIFF: https://github.com/llvm/llvm-project/commit/7822c8c03e9fe8c857da21c4ccbe28396b43130d.diff

[Lldb-commits] [lldb] 34312ed - Remove unneeded Compiler.h and DataTypes.h includes, NFC

Author: Reid Kleckner Date: 2020-02-26T10:36:17-08:00 New Revision: 34312ed24e17a0e8269611b954e489fa7759f115 URL: https://github.com/llvm/llvm-project/commit/34312ed24e17a0e8269611b954e489fa7759f115 DIFF: https://github.com/llvm/llvm-project/commit/34312ed24e17a0e8269611b954e489fa7759f115.diff

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev created this revision. paolosev added reviewers: labath, vsk, JDevlieghere, clayborg. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin. The original discussion for this issues is here . The lldb sanitized b

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. In D72751#1892925 , @labath wrote: > > Who is the owner of this MemoryCache code I should ask for a review? > > It sounds like the fix will be fairly straightforward. I think anyone on this > thread should be able to review that.

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

clayborg added a comment. Not sure this is the right fix. The calling code should listen to how many bytes were actually read from memory and avoid touching any bytes. So we should fix Module::GetMemoryObjectFile to resize its buffer back to only the size that was read. Something like: const

[Lldb-commits] [lldb] 34ee941 - [ObjectFileMachO] Fix a build error on embedded.

Author: Davide Italiano Date: 2020-02-26T14:31:48-08:00 New Revision: 34ee941f6d04454838456f0dc692f4abab5cdd19 URL: https://github.com/llvm/llvm-project/commit/34ee941f6d04454838456f0dc692f4abab5cdd19 DIFF: https://github.com/llvm/llvm-project/commit/34ee941f6d04454838456f0dc692f4abab5cdd19.dif

[Lldb-commits] [PATCH] D74892: [lldb][cmake] Also use local submodule visibility on Darwin

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74892/new/ https://reviews.llvm.org/D74892 ___ lldb-c

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev updated this revision to Diff 246868. paolosev added a comment. In D75200#1894162 , @clayborg wrote: > Not sure this is the right fix. The calling code should listen to how many > bytes were actually read from memory and avoid touching any bytes.

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

paolosev added a comment. The Harbormaster errors don't seem to be real failures: /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lldb/source/Core/Module.cpp:9:10: error: 'lldb/Core/Module.h' file not found [clang-diagnostic-error] #include "lldb/Core/Module.h" ^ /