[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

tatyana-krasnukha added a comment. I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [lldb] 0e5ed1b - [lldb][NFC] Split up ClangASTSource::FindExternalVisibleDecls

Author: Raphael Isemann Date: 2020-02-21T09:47:52+01:00 New Revision: 0e5ed1b26264f7eee32b23c533371c18ce1cdec0 URL: https://github.com/llvm/llvm-project/commit/0e5ed1b26264f7eee32b23c533371c18ce1cdec0 DIFF: https://github.com/llvm/llvm-project/commit/0e5ed1b26264f7eee32b23c533371c18ce1cdec0.dif

[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

teemperor created this revision. teemperor added reviewers: labath, shafik, JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Remove all the`current_id` logging counters from the lookup code." to "[lldb] Remove

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

JDevlieghere added a comment. In D73067#1884970 , @krytarowski wrote: > Autogeneration of the code puts extra burden on us for tracking what is > defined where and for repackaging LLDB with custom build rules (we need plain > Makefile in the distribution

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor created this revision. teemperor added reviewers: jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently the test suite runs with enabled automatically applied Clang fix-its for expressions. This is causing that sometimes incorrect expres

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

labath added a subscriber: jingham. labath added a comment. We (mostly me and @jingham) discussed that idea (very) briefly a couple of weeks ago, and my impression was that this (reinitializing SBDebugger for every test) would be a good way to go. There are just too many things that can leak fr

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

labath added a comment. In D74657#1885361 , @JDevlieghere wrote: > A few small nits inline, but this LGTM if Pavel is on board. We're getting close, but I still see some room for improvement. :) Comment at: lldb/bindings/interface/SB

[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

grandinj added a comment. Just a drive-by suggestion: Logging the pointer value of the relevant root object in the callees would provide similar benefit to anyone needing to do log tracing Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74951/new/ https://revie

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM outside of my comments Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2404 +# Disable fix-its that tests don't pass by accident. +options.Se

[Lldb-commits] [lldb] de8793b - [lldb/DWARF] Add support for type units in dwp files

Author: Pavel Labath Date: 2020-02-21T16:01:17+01:00 New Revision: de8793b9184ece0d24f46bc2d86711092848f938 URL: https://github.com/llvm/llvm-project/commit/de8793b9184ece0d24f46bc2d86711092848f938 DIFF: https://github.com/llvm/llvm-project/commit/de8793b9184ece0d24f46bc2d86711092848f938.diff

[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I have struggled to understand the real use of those counters, they may have been helpful to someone at one point but the rationale is lost in the sands of time. LGTM but lets see if someone

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor updated this revision to Diff 245846. teemperor added a comment. - Revert dummy change that set auto-apply fixits to true (thanks Shafik!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74957/new/ https://reviews.llvm.org/D74957 Files: lldb/packages/Python/lldbsuite/test/lld

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2404 +# Disable fix-its that tests don't pass by accident. +options.SetAutoApplyFixIts(True) + shafik wrote: >

[Lldb-commits] [PATCH] D74964: [lldb/DWARF] Don't index dwp file multiple times

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: arphaman. Herald added a project: LLDB. When we added support for type units in dwo files, we changed the "manual" dwarf index to index _all_ dwarf units in the dwo file instead of jus

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. Thanks for the guidance! When there are no additional concerns, would someone mind committing this change for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://review

[Lldb-commits] [lldb] c47e0e2 - [lldb-vscode] Use libOption with tablegen to parse command line options.

Author: Ivan Hernandez Date: 2020-02-21T08:15:06-08:00 New Revision: c47e0e2d37d32ec56c760f1a2c9740d69c370b57 URL: https://github.com/llvm/llvm-project/commit/c47e0e2d37d32ec56c760f1a2c9740d69c370b57 DIFF: https://github.com/llvm/llvm-project/commit/c47e0e2d37d32ec56c760f1a2c9740d69c370b57.diff

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

JDevlieghere added a comment. In D74798#1886477 , @ivanhernandez13 wrote: > Thanks for the guidance! > > When there are no additional concerns, would someone mind committing this > change for me? I don't have commit access. Done! To github.com:llvm/

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc47e0e2d37d3: [lldb-vscode] Use libOption with tablegen to parse command line options. (authored by ivanhernandez13, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D74798

[Lldb-commits] [lldb] 07d2cda - [lldb/cmake] Enable more verbose find_package output.

Author: Matt Davis Date: 2020-02-21T10:37:02-08:00 New Revision: 07d2cdae11633139947f105888163adfd5646ce7 URL: https://github.com/llvm/llvm-project/commit/07d2cdae11633139947f105888163adfd5646ce7 DIFF: https://github.com/llvm/llvm-project/commit/07d2cdae11633139947f105888163adfd5646ce7.diff LO

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Enable more verbose find_package output.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07d2cdae1163: [lldb/cmake] Enable more verbose find_package output. (authored by mattd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74917/new/ https://re

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

mib updated this revision to Diff 245939. mib marked 6 inline comments as done. mib edited the summary of this revision. mib added a comment. Addressed Pavel's comments. Add "negative" tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

mib updated this revision to Diff 245952. mib added a comment. Removed old revision artifacts Renamed `test_on_launch` to `test_before_launch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657 Files: lldb/b

[Lldb-commits] [lldb] 0bb9062 - Allow customized relative PYTHONHOME

Author: Haibo Huang Date: 2020-02-21T12:49:10-08:00 New Revision: 0bb90628b5f7c170689d2d3f019af773772fc649 URL: https://github.com/llvm/llvm-project/commit/0bb90628b5f7c170689d2d3f019af773772fc649 DIFF: https://github.com/llvm/llvm-project/commit/0bb90628b5f7c170689d2d3f019af773772fc649.diff L

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb90628b5f7: Allow customized relative PYTHONHOME (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D747

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

stella.stamenova added a comment. It looks like this broke the Windows LLDB Buildbot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://rev

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM'ing for Pavel by proxy as discussed on IRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657

[Lldb-commits] [lldb] d7c403e - [lldb/Plugins] Add ability to fetch crash information on crashed processes

Author: Med Ismail Bennani Date: 2020-02-21T22:44:36+01:00 New Revision: d7c403e64043281b9c5883e3e034da5ebaf4985a URL: https://github.com/llvm/llvm-project/commit/d7c403e64043281b9c5883e3e034da5ebaf4985a DIFF: https://github.com/llvm/llvm-project/commit/d7c403e64043281b9c5883e3e034da5ebaf4985a.

[Lldb-commits] [lldb] 1f04d1b - [lldb/test] Move `platform process list` tests to its own directory (NFC)

Author: Med Ismail Bennani Date: 2020-02-21T22:44:36+01:00 New Revision: 1f04d1b7069bf6c513526f36b8c7327c8dec6604 URL: https://github.com/llvm/llvm-project/commit/1f04d1b7069bf6c513526f36b8c7327c8dec6604 DIFF: https://github.com/llvm/llvm-project/commit/1f04d1b7069bf6c513526f36b8c7327c8dec6604.

[Lldb-commits] [PATCH] D74836: [lldb/test] Move `platform process list` tests to its own directory (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f04d1b7069b: [lldb/test] Move `platform process list` tests to its own directory (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7483

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd7c403e64043: [lldb/Plugins] Add ability to fetch crash information on crashed processes (authored by mib). Repository:

[Lldb-commits] [lldb] 215a311 - Revert "Allow customized relative PYTHONHOME"

Author: Stella Stamenova Date: 2020-02-21T14:57:00-08:00 New Revision: 215a31115f89c851331a822e67aa4528ba5c21e6 URL: https://github.com/llvm/llvm-project/commit/215a31115f89c851331a822e67aa4528ba5c21e6 DIFF: https://github.com/llvm/llvm-project/commit/215a31115f89c851331a822e67aa4528ba5c21e6.di

[Lldb-commits] [lldb] 8a0f0e2 - [lldb/test] Tweak libcxx string test on Apple+ARM devices

Author: Vedant Kumar Date: 2020-02-21T15:54:38-08:00 New Revision: 8a0f0e2656abf76b771037c6543caf9a31744120 URL: https://github.com/llvm/llvm-project/commit/8a0f0e2656abf76b771037c6543caf9a31744120 DIFF: https://github.com/llvm/llvm-project/commit/8a0f0e2656abf76b771037c6543caf9a31744120.diff

[Lldb-commits] [PATCH] D74998: Allow customized relative PYTHONHOME (Attemp 1)

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This is another attempt of 0bb90628b5f7c170689d2d3f019af773772fc649 . The difference is that g_python_home is not declared

Re: [Lldb-commits] [lldb] 8a0f0e2 - [lldb/test] Tweak libcxx string test on Apple+ARM devices

> On Feb 21, 2020, at 3:54 PM, Vedant Kumar via lldb-commits > wrote: > > > Author: Vedant Kumar > Date: 2020-02-21T15:54:38-08:00 > New Revision: 8a0f0e2656abf76b771037c6543caf9a31744120 > > URL: > https://github.com/llvm/llvm-project/commit/8a0f0e2656abf76b771037c6543caf9a31744120 > DIFF:

[Lldb-commits] [lldb] 3ec3f62 - Allow customized relative PYTHONHOME (Attemp 1)

Author: Haibo Huang Date: 2020-02-21T16:25:30-08:00 New Revision: 3ec3f62f0a0b1ac13230922c91ffc988c1b1e8d5 URL: https://github.com/llvm/llvm-project/commit/3ec3f62f0a0b1ac13230922c91ffc988c1b1e8d5 DIFF: https://github.com/llvm/llvm-project/commit/3ec3f62f0a0b1ac13230922c91ffc988c1b1e8d5.diff L

[Lldb-commits] [PATCH] D74998: Allow customized relative PYTHONHOME (Attemp 1)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec3f62f0a0b: Allow customized relative PYTHONHOME (Attemp 1) (authored by hhb). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D74964: [lldb/DWARF] Don't index dwp file multiple times

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Seems straightforward. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66 /// Non-null value means we haven't built the index yet. + Sym

[Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

jingham created this revision. jingham added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The debugserver profile thread used to suspend itself between samples with a usleep. When you detach or kill, MachProcess::Clear would delay replying to the in

[Lldb-commits] [lldb] ebee131 - [lldb][test] Fix sh_type of .debug_cu_index and .debug_tu_index

Author: Fangrui Song Date: 2020-02-21T17:38:39-08:00 New Revision: ebee131259719fa9c06cd346e21ace3fa8ac0888 URL: https://github.com/llvm/llvm-project/commit/ebee131259719fa9c06cd346e21ace3fa8ac0888 DIFF: https://github.com/llvm/llvm-project/commit/ebee131259719fa9c06cd346e21ace3fa8ac0888.diff

[Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

clayborg added a comment. Lots of change for something that might be fixed much easier: Alt way: Why not just set m_profile_enabled to false in StopProfileThread() and let loop exit on next iteration? Code changes would be much smaller. All comments above are marked with "alt way:" for this sol

[Lldb-commits] [lldb] e29065a - [lldb][test] Fix sh_flags and sh_entsize of .debug_str.dwo

Author: Fangrui Song Date: 2020-02-21T18:51:05-08:00 New Revision: e29065a105342a904871437d18a4e6fab09e5bc1 URL: https://github.com/llvm/llvm-project/commit/e29065a105342a904871437d18a4e6fab09e5bc1 DIFF: https://github.com/llvm/llvm-project/commit/e29065a105342a904871437d18a4e6fab09e5bc1.diff

[Lldb-commits] [PATCH] D75007: When unwinding out of a trap handler, fetch the saved pc even if there's a return address register defined

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. On targets with a return address register (e.g. $lr on arm), when the unwinder is asked to fetch the caller's pc, we rewrite that to fetch the return address value. However, when we