[Lldb-commits] [lldb] ea2af72 - [lldb] Refactored TestCallOverriddenMethod.py to general virtual function test

Author: Raphael Isemann Date: 2020-02-10T09:40:40+01:00 New Revision: ea2af727a5c38906e3d1321de51aaa126b4efc69 URL: https://github.com/llvm/llvm-project/commit/ea2af727a5c38906e3d1321de51aaa126b4efc69 DIFF: https://github.com/llvm/llvm-project/commit/ea2af727a5c38906e3d1321de51aaa126b4efc69.dif

[Lldb-commits] [lldb] d2e0fee - [lldb] [doc] Change sample commands prefix from > to $

Author: Jan Kratochvil Date: 2020-02-10T09:50:37+01:00 New Revision: d2e0fee77bc82a54bcc11ce778ce12f068f9e326 URL: https://github.com/llvm/llvm-project/commit/d2e0fee77bc82a54bcc11ce778ce12f068f9e326 DIFF: https://github.com/llvm/llvm-project/commit/d2e0fee77bc82a54bcc11ce778ce12f068f9e326.diff

[Lldb-commits] [PATCH] D74296: [lldb] [doc] Sample commands prefix from > to $

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e0fee77bc8: [lldb] [doc] Change sample commands prefix from > to $ (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74296/new/ h

[Lldb-commits] [lldb] 6115bd9 - [LLDB] Fix GCC warnings about extra semicolons. NFC.

Author: Martin Storsjö Date: 2020-02-10T11:20:44+02:00 New Revision: 6115bd9ba2851469d372d0d7b36d87a3e1d8094b URL: https://github.com/llvm/llvm-project/commit/6115bd9ba2851469d372d0d7b36d87a3e1d8094b DIFF: https://github.com/llvm/llvm-project/commit/6115bd9ba2851469d372d0d7b36d87a3e1d8094b.diff

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

mib added a comment. Hello Jan, Has the latest version of this patch landed yet or does it need some extra work ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new/ https://reviews.llvm.org/D74252

[Lldb-commits] [lldb] 1a39f1b - [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux

Author: Jan Kratochvil Date: 2020-02-10T10:29:32+01:00 New Revision: 1a39f1b966a8d8f15ed0d5a832d5097cccefe93b URL: https://github.com/llvm/llvm-project/commit/1a39f1b966a8d8f15ed0d5a832d5097cccefe93b DIFF: https://github.com/llvm/llvm-project/commit/1a39f1b966a8d8f15ed0d5a832d5097cccefe93b.diff

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a39f1b966a8: [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1866476 , @mib wrote: > Has the latest version of this patch landed yet or does it need some extra > work ? I was giving some time to other reviewers but it is checked-in now. Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 0ed233c - [lldb][NFC] Don't construct a ConstString twice in LibCxxVariant

Author: Raphael Isemann Date: 2020-02-10T12:23:01+01:00 New Revision: 0ed233c85134e5e1581c5ef73edd1e746f6f0d0f URL: https://github.com/llvm/llvm-project/commit/0ed233c85134e5e1581c5ef73edd1e746f6f0d0f DIFF: https://github.com/llvm/llvm-project/commit/0ed233c85134e5e1581c5ef73edd1e746f6f0d0f.dif

[Lldb-commits] [lldb] 9721212 - [lldb][NFC] Fix code style of LibcxxVariantIndexValidity

Author: Raphael Isemann Date: 2020-02-10T12:37:51+01:00 New Revision: 97212121c504aa9e028b1b4f2778696cc741e982 URL: https://github.com/llvm/llvm-project/commit/97212121c504aa9e028b1b4f2778696cc741e982 DIFF: https://github.com/llvm/llvm-project/commit/97212121c504aa9e028b1b4f2778696cc741e982.dif

[Lldb-commits] [lldb] 1a77955 - [lldb][NFC] Don't call call formatv for no reason in LibCxxOptional

Author: Raphael Isemann Date: 2020-02-10T12:39:42+01:00 New Revision: 1a779550aa1d94f1c0ea8a22c98a850600be6144 URL: https://github.com/llvm/llvm-project/commit/1a779550aa1d94f1c0ea8a22c98a850600be6144 DIFF: https://github.com/llvm/llvm-project/commit/1a779550aa1d94f1c0ea8a22c98a850600be6144.dif

[Lldb-commits] [lldb] 2a3ef37 - [lldb][NFC] Don't hide a bool in LibCxxOptional's OptionalFrontend::m_size

Author: Raphael Isemann Date: 2020-02-10T13:03:06+01:00 New Revision: 2a3ef377ec00e7c7d3f4c47614ab6baee727cd82 URL: https://github.com/llvm/llvm-project/commit/2a3ef377ec00e7c7d3f4c47614ab6baee727cd82 DIFF: https://github.com/llvm/llvm-project/commit/2a3ef377ec00e7c7d3f4c47614ab6baee727cd82.dif

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

tatyana-krasnukha added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp:938 + .Case("R8", LLDB_REGNUM_GENERIC_ARG5) + .Case("r9", LLDB_REGNUM_GENERIC_ARG6) + .Default(LLDB_INVALID_REGNUM); Typo? It should be uppercase, I

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

teemperor created this revision. teemperor added reviewers: JDevlieghere, jingham. Herald added subscribers: lldb-commits, abidh, jfb, christof. Herald added a project: LLDB. Currently the data formatter is treating `std::atomic` variables as transparent wrappers around their underlying value typ

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:966 name = "(internal)"; result.GetOutputStream().Printf( + "%d: %s, module %s, function %s{%s}%s\n", recognizer_id, We should stream

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

vsk updated this revision to Diff 243608. vsk retitled this revision from "[Host.mm] Check for the right macro instead of inlining it." to "[Host.mm] Check for the right macro instead of inlining it". vsk added a comment. - Check TARGET_OS_EMBEDDED. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

vsk commandeered this revision. vsk edited reviewers, added: davide; removed: vsk. vsk added a comment. This just came up again as the watchOS/tvOS build breaks without the TARGET_OS_EMBEDDED check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73938/new/ https://reviews.llvm.org/D7393

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM =) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73938/new/ https://reviews.llvm.org/D73938 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] 936d142 - [Host.mm] Check for the right macro instead of inlining it

Author: Vedant Kumar Date: 2020-02-10T10:06:40-08:00 New Revision: 936d1427da1432d724dfa5851097347bcdf7c521 URL: https://github.com/llvm/llvm-project/commit/936d1427da1432d724dfa5851097347bcdf7c521 DIFF: https://github.com/llvm/llvm-project/commit/936d1427da1432d724dfa5851097347bcdf7c521.diff

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

This revision was automatically updated to reflect the committed changes. Closed by commit rG936d1427da14: [Host.mm] Check for the right macro instead of inlining it (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D73938?vs=243608&id=243613#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] eaeb561 - debugserver: Rely on mig architectures being specified externally

Author: Vedant Kumar Date: 2020-02-10T10:13:05-08:00 New Revision: eaeb5610ced23404f2c799d6e0c46c05f06ac3b5 URL: https://github.com/llvm/llvm-project/commit/eaeb5610ced23404f2c799d6e0c46c05f06ac3b5 DIFF: https://github.com/llvm/llvm-project/commit/eaeb5610ced23404f2c799d6e0c46c05f06ac3b5.diff

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

shafik accepted this revision. shafik added a comment. Thank you fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73946/new/ https://reviews.llvm.org/D73946 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

teemperor added a comment. I think this is now causing a warning: 1600⧐952 ( 37%) Building CXX object tools/lldb/source/Host/macosx/objcxx/CMakeFiles/lldbHostMacOSXObjCXX.dir/Host.mm.o /Users/teemperor/2llvm/llvm-project/lldb/source/Host/macosx/objcxx/Host.mm:139:14: warning: unused functi

[Lldb-commits] [lldb] 6fd818c - Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Author: Ted Woodward Date: 2020-02-10T13:40:44-06:00 New Revision: 6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c URL: https://github.com/llvm/llvm-project/commit/6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c DIFF: https://github.com/llvm/llvm-project/commit/6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c.diff

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fd818c5a9c5: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513

[Lldb-commits] [lldb] d23c15a - Do not define AcceptPIDFromInferior when it will not be used

Author: Vedant Kumar Date: 2020-02-10T12:06:46-08:00 New Revision: d23c15a687ff15327b88fa64da3184395012c2dc URL: https://github.com/llvm/llvm-project/commit/d23c15a687ff15327b88fa64da3184395012c2dc DIFF: https://github.com/llvm/llvm-project/commit/d23c15a687ff15327b88fa64da3184395012c2dc.diff

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

vsk added a comment. Fixed in d23c15a687ff15327b88fa64da3184395012c2dc . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73938/new/ https://reviews.llvm.org/D73938 _

[Lldb-commits] [lldb] 6b2979c - Revert "[lldb] Fix+re-enable Assert StackFrame Recognizer on Linux"

Author: Davide Italiano Date: 2020-02-10T13:27:35-08:00 New Revision: 6b2979c12300b90a1e69791d43ee9cff14f4265e URL: https://github.com/llvm/llvm-project/commit/6b2979c12300b90a1e69791d43ee9cff14f4265e DIFF: https://github.com/llvm/llvm-project/commit/6b2979c12300b90a1e69791d43ee9cff14f4265e.dif

Re: [Lldb-commits] [lldb] 1a39f1b - [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux

This caused three failures on macOS. I reverted the patch to unbreak the bots. http://lab.llvm.org:8080/green/job/lldb-cmake/8565/console Thanks, — Davide > On Feb 10, 2020, at 01:33, Jan Kratochvil via lldb-commits > wrote: > > >

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a subscriber: davide. jankratochvil added a comment. @davide Sorry for the revert rG6b2979c12300b90a1e69791d43ee9cff14f4265e - I will find some way to test stuff on OSX, I already made too many OSX breakage

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice elimination of duplication. Comment at: lldb/source/Target/ABI.cpp:249 + int eh = -1; + int dwarf = -1; + for (unsigned reg = 0; reg < m_mc_register_info_

[Lldb-commits] [lldb] bf65f19 - Revert "[Host.mm] Check for the right macro instead of inlining it"

Author: Vedant Kumar Date: 2020-02-10T14:34:48-08:00 New Revision: bf65f19bce88fd9f1a74154d92afe37193ecd7a5 URL: https://github.com/llvm/llvm-project/commit/bf65f19bce88fd9f1a74154d92afe37193ecd7a5 DIFF: https://github.com/llvm/llvm-project/commit/bf65f19bce88fd9f1a74154d92afe37193ecd7a5.diff

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

vsk reopened this revision. vsk added a comment. This revision is now accepted and ready to land. Reverted in bf65f19bce88fd9f1a74154d92afe37193ecd7a5 . Jason pointed out this breaks macOS, as TARGET_OS_EMBEDDED is always defin

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

shafik added a comment. I will try to look into `dwarfdump --verify` separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new/ https://reviews.llvm.org/D73921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

shafik updated this revision to Diff 243678. shafik marked 5 inline comments as done. shafik added a comment. Herald added a reviewer: jdoerfert. Updated approach based on comments and added test for the new approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new/ https://revi

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

vsk updated this revision to Diff 243679. vsk added a reviewer: jasonmolenda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73938/new/ https://reviews.llvm.org/D73938 Files: lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/macosx/objcxx/Host.mm =

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

JDevlieghere added a comment. Given that this error is non-actionable, I don't see any value in diagnosing this LLDB. It is important to have this in dwarfdump, which does not detect this right now. It might be interesting to have LLDB run in a sort of "pedantic" mode which verifies all the DW

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM otherwise. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py:70 +# This should

[Lldb-commits] [lldb] b7bd35a - [TestKernVerStrLCNOTE] Check the *right* architecture.

Author: Davide Italiano Date: 2020-02-10T15:17:52-08:00 New Revision: b7bd35a8f13fd332fc7d32c0f03b13ef9e2fb2c1 URL: https://github.com/llvm/llvm-project/commit/b7bd35a8f13fd332fc7d32c0f03b13ef9e2fb2c1 DIFF: https://github.com/llvm/llvm-project/commit/b7bd35a8f13fd332fc7d32c0f03b13ef9e2fb2c1.dif

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

jingham added a comment. In D73921#1855961 , @davide wrote: > DWARFASTParserClang looks to me the wrong layer to fix this. Why can't this > be caught in the generic DWARF Parser? > I also believe that it's better if dwarfdump -verify crashes on this, rat

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

JDevlieghere added a comment. In D73921#1868228 , @jingham wrote: > In D73921#1855961 , @davide wrote: > > > DWARFASTParserClang looks to me the wrong layer to fix this. Why can't this > > be caught in the generic

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

davide added a comment. In D73921#1868286 , @JDevlieghere wrote: > In D73921#1868228 , @jingham wrote: > > > In D73921#1855961 , @davide wrote: > > > > > DWARFASTParserClang

[Lldb-commits] [lldb] 9ed9742 - Only perform the login_session_has_gui_access on macOS

Author: Jason Molenda Date: 2020-02-10T18:16:31-08:00 New Revision: 9ed9742ec05091e4c16d93005acbfafc6f801e7d URL: https://github.com/llvm/llvm-project/commit/9ed9742ec05091e4c16d93005acbfafc6f801e7d DIFF: https://github.com/llvm/llvm-project/commit/9ed9742ec05091e4c16d93005acbfafc6f801e7d.diff

[Lldb-commits] [PATCH] D74377: [lldb-vscode] fix logging

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the patch clayborg sent me for fixing logging, which didn't include incoming messages from VSCode. Repository: rG LLVM Github Monorepo https:

[Lldb-commits] [lldb] 14ecbd7 - [lldb][NFC] Refactor TypeSystemClang::GetTypeName

Author: Raphael Isemann Date: 2020-02-11T08:43:57+01:00 New Revision: 14ecbd7b8ded18af6c95f6a9957da541d1ec0e80 URL: https://github.com/llvm/llvm-project/commit/14ecbd7b8ded18af6c95f6a9957da541d1ec0e80 DIFF: https://github.com/llvm/llvm-project/commit/14ecbd7b8ded18af6c95f6a9957da541d1ec0e80.dif