[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

teemperor added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:1 +//===-- DynamicLoaderWasmDYLD.cpp *- C++ +//-*-===// paolosev wrote: > aprantl wrote: > > 1. This hangs over the

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

alok marked 12 inline comments as done. alok added inline comments. Comment at: llvm/docs/SourceLevelDebugging.rst:261 +This intrinsic is identical to `llvm.dbg.value`, except that it is used to +describe dereferenced value of pointer variable. The first argument is metadata. +T

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. In D71498#1786341 , @clayborg wrote: > As I am reading this, I just wanted to send out a note of something else that > can cause crashes in ARM/Thumb code. For anyone working with ARM/Thumb on > systems that don't use the ARM an

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. I think this is good, and it has been sitting a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

alok updated this revision to Diff 234356. alok added a comment. This version is updated to rebase and to incorporate comments from @jmorse and @StephenTozer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70644/new/ https://reviews.llvm.org/D7064

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 234471. paolosev retitled this revision from "[LLDB] Add initial support for WebAssembly debugging" to "[LLDB] Add ObjectFileWasm plugin for WebAssembly debugging". paolosev edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 234474. paolosev set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71575/new/ https://reviews.llvm.org/D71575 Files: lldb/include/lldb/Utility/Arch

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. Another bug report for this: https://bugs.llvm.org/show_bug.cgi?id=44331 Please close when landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 ___ lldb-commits m

[Lldb-commits] [lldb] d8a3194 - [lldb][NFC] Add unit test for persistent variable lookup with ClangExpressionDeclMap

Author: Raphael Isemann Date: 2019-12-18T13:50:05+01:00 New Revision: d8a3194987301672fbd50f4e5703952381f0157c URL: https://github.com/llvm/llvm-project/commit/d8a3194987301672fbd50f4e5703952381f0157c DIFF: https://github.com/llvm/llvm-project/commit/d8a3194987301672fbd50f4e5703952381f0157c.dif

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere updated this revision to Diff 234568. JDevlieghere added a comment. Implement Pavel's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig.cma

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lldb/cmake/modules/LLDBConfig.cmake:30 + string(TOUPPER "${${variable}}" ${variable}) + if ("${${variable}}" STREQUAL "OFF") +set(${variable}

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere updated this revision to Diff 234584. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza added a comment. Great point! Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71633/new/ https://reviews.llvm.org/D71633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza updated this revision to Diff 234586. lanza added a comment. fixup according to Greg's requests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71633/new/ https://reviews.llvm.org/D71633 Files: lldb/tools/lldb-vscode/lldb-vscode.cpp Index:

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:33 +set(maybe_required) + elseif("${${variable}}" STREQUAL "ON") +set(maybe_required REQUIRED) Now you broke it the other way around. Is there any reason you can't just `${${v

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

clayborg added a comment. It would be nice if we could test this works as well. We would need to spawn the lldb-vscode manually and specify a socket, connect with a socket with the vscode.py test stuff, and get able to get some output from it once the session is up and running. Something like s

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:33 +set(maybe_required) + elseif("${${variable}}" STREQUAL "ON") +set(maybe_required REQUIRED) mgorny wrote: > Now you brok

[Lldb-commits] [lldb] e194d89 - [lldb/MachO] "Fix" intentional out-of-bounds error (NFC)

Author: Jonas Devlieghere Date: 2019-12-18T12:54:04-08:00 New Revision: e194d890126007bc8e5acb655f007ef76002edb7 URL: https://github.com/llvm/llvm-project/commit/e194d890126007bc8e5acb655f007ef76002edb7 DIFF: https://github.com/llvm/llvm-project/commit/e194d890126007bc8e5acb655f007ef76002edb7.d

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:33 +set(maybe_required) + elseif("${${variable}}" STREQUAL "ON") +set(maybe_required REQUIRED) JDevlieghere wrote: > mgorny wrote: > > Now you broke it the other way around. Is

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk planned changes to this revision. rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:653 template DynTypedNodeList getParents(const NodeT &Node) { return getParents(ast_type_traits::DynTypedNode::create(N

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

We're seeing some odd test failures internally caused by this patch. For whatever reason (test ordering based on hashing, I guess), we're running the tests in a different order than upstream, and TestClangASTContext crashes when TestClangASTImporter runs first. By default, it seems like TestClangA

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

I’m actually already investigating that because I see the same failure when I moved the ::Initialize and ::Terminate calls to SetUp and TearDown as part of D71630. I’ll reply here when I have a fix, thanks! > On Dec 18, 2019, at 10:54 PM, Jordan Rupprecht wrote: > > We're seeing some odd test

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik updated this revision to Diff 234619. shafik marked 3 inline comments as done. shafik added a comment. - Fix typo - Adjust error handing - clang-format test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 Files: clang/lib/AST/ASTImporte

[Lldb-commits] [lldb] 997bc8b - Add prototype for a function we call.

Author: Jason Molenda Date: 2019-12-18T14:18:52-08:00 New Revision: 997bc8b2e6b973dd8c9b17414310cac822543f79 URL: https://github.com/llvm/llvm-project/commit/997bc8b2e6b973dd8c9b17414310cac822543f79 DIFF: https://github.com/llvm/llvm-project/commit/997bc8b2e6b973dd8c9b17414310cac822543f79.diff

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere updated this revision to Diff 234624. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Accept usual constant in addition to auto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 Files: lldb/cmake/module

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:33 +set(maybe_required) + elseif("${${variable}}" STREQUAL "ON") +set(maybe_required REQUIRED) mgorny wrote: > JDevlieghere wrote: > > mgorny wrote: > > > Now you broke i

[Lldb-commits] [lldb] 48999eb - [lldb/test] Move script interpreter tests

Author: Jonas Devlieghere Date: 2019-12-18T15:44:07-08:00 New Revision: 48999eb398ebec72fdf7194f5d2605dd3c799caf URL: https://github.com/llvm/llvm-project/commit/48999eb398ebec72fdf7194f5d2605dd3c799caf DIFF: https://github.com/llvm/llvm-project/commit/48999eb398ebec72fdf7194f5d2605dd3c799caf.d

[Lldb-commits] [lldb] 7026b34 - make err msg in MachSymtabSectionInfo::GetSection clear about the file

Author: Jason Molenda Date: 2019-12-18T16:13:17-08:00 New Revision: 7026b34702f3f71ff157876831f29c76b3cb8bb1 URL: https://github.com/llvm/llvm-project/commit/7026b34702f3f71ff157876831f29c76b3cb8bb1 DIFF: https://github.com/llvm/llvm-project/commit/7026b34702f3f71ff157876831f29c76b3cb8bb1.diff

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

JDevlieghere updated this revision to Diff 234637. JDevlieghere added a comment. - Rebase - Add test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71234/new/ https://reviews.llvm.org/D71234 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Core/IOHandler.h lldb/so

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

JDevlieghere updated this revision to Diff 234638. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Rebase - Move wrapper to API - Add test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71235/new/ https://reviews.llvm.org/D71235 Files: lldb/CMakeLis

[Lldb-commits] [lldb] 56ab485 - [lldb/Scripting] Simplify code by removing the #if.

Author: Jonas Devlieghere Date: 2019-12-18T16:46:38-08:00 New Revision: 56ab485a311d065f9417e0cff903e1f33495f4cc URL: https://github.com/llvm/llvm-project/commit/56ab485a311d065f9417e0cff903e1f33495f4cc DIFF: https://github.com/llvm/llvm-project/commit/56ab485a311d065f9417e0cff903e1f33495f4cc.d