[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG068325012796: [lldb][NFC] Remove unnecessary includes in source/Commands (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71489/new/ h

[Lldb-commits] [lldb] 64678ef - [lldb][NFC] Remove ClangASTImporter::ResolveDeclOrigin

Author: Raphael Isemann Date: 2019-12-16T09:16:33+01:00 New Revision: 64678ef9f289e9c1951fee5dbcacde583f3d6576 URL: https://github.com/llvm/llvm-project/commit/64678ef9f289e9c1951fee5dbcacde583f3d6576 DIFF: https://github.com/llvm/llvm-project/commit/64678ef9f289e9c1951fee5dbcacde583f3d6576.dif

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() JDevlieghere wrote: > mgorny wrote: > > JDevlieghere wrote: > > > mgorny wrote: > > > > JDevlieghere wrote: > > > > > mgorny w

[Lldb-commits] [lldb] 959ed0e - [lldb][NFC] Fix file header of TestClangASTContext.cpp

Author: Raphael Isemann Date: 2019-12-16T09:34:16+01:00 New Revision: 959ed0e2944c454a3df3aa3bc8ab551c8b587e9b URL: https://github.com/llvm/llvm-project/commit/959ed0e2944c454a3df3aa3bc8ab551c8b587e9b DIFF: https://github.com/llvm/llvm-project/commit/959ed0e2944c454a3df3aa3bc8ab551c8b587e9b.dif

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

labath added a comment. This definitely needs a more targeted fix. Requiring a symbol is not good, and it will be particularly problematic on windows, as there we don't have the equivalent of a .symtab (only .dynsym). Looking at your example, I'm pretty sure that the DW_AT_object_pointer busine

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. @jankratochvil I have verified both D71498 and D71514 . They **do not fix** the issues introduced by D63540 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] f49d15b - [lldb][NFC] Move definition of ClangASTMetadata out of ClangExternalASTSourceCommon.h

Author: Raphael Isemann Date: 2019-12-16T10:52:31+01:00 New Revision: f49d15b3f8ccd7737a62d40adfe5ff1e710788d4 URL: https://github.com/llvm/llvm-project/commit/f49d15b3f8ccd7737a62d40adfe5ff1e710788d4 DIFF: https://github.com/llvm/llvm-project/commit/f49d15b3f8ccd7737a62d40adfe5ff1e710788d4.dif

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

labath added a comment. Yeah, this looks like it was fun to track down. I'm going to comment on both patches here, since they are really similar... Overall, I'm not very enthusiastic about the addr_t wrapper -- I'm not sure it would be even possible because that's a part of the public API. It m

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

labath added a comment. In D71372#1785241 , @mossberg wrote: > I wanted to also mention that this patch won't address buggy behavior if, for > example, the stub takes a function pointer on the stack (vs a normal data > pointer). In this case, the executa

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. I still seem to get the same issue after applying this patch and D63540 . echo -e '#include \nint main(void){\nsync();return 0;}'|./bin/clang -g -x c -;./bin/lldb -o 'file ./a.out' -o 'b main' -o r -o 'p (void)sync()' (lldb) file ./a.ou

[Lldb-commits] [PATCH] D71405: [lldb] Centralize desugaring of decltype-like types in ClangASTContext

labath added a comment. The unit test sounds like a good idea. I'll do that instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71405/new/ https://reviews.llvm.org/D71405 ___ lldb-commits mailing li

[Lldb-commits] [lldb] ea2805a - [lldb] Centralize desugaring of decltype-like types in ClangASTContext

Author: Pavel Labath Date: 2019-12-16T12:02:32+01:00 New Revision: ea2805a04b65331ca568ff76761ef8a52337e42b URL: https://github.com/llvm/llvm-project/commit/ea2805a04b65331ca568ff76761ef8a52337e42b DIFF: https://github.com/llvm/llvm-project/commit/ea2805a04b65331ca568ff76761ef8a52337e42b.diff

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1785486 , @omjavaid wrote: > error: Can't run the expression locally: Interpreter doesn't handle one of > the expression's opcodes OK, I see it is a different error. I will try to reproduce also that one. Repo

[Lldb-commits] [PATCH] D71405: [lldb] Centralize desugaring of decltype-like types in ClangASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGea2805a04b65: [lldb] Centralize desugaring of decltype-like types in ClangASTContext (authored by labath). Changed prior to commit: https://reviews.llvm.org/D71405?vs=233556&id=234015#toc Repository:

[Lldb-commits] [lldb] 75e8a91 - [lldb][NFC] Remove all overloads of Copy/DeportType in ClangASTImporter

Author: Raphael Isemann Date: 2019-12-16T12:09:05+01:00 New Revision: 75e8a91cf84fce2432f70949ab9e353ff2322a5f URL: https://github.com/llvm/llvm-project/commit/75e8a91cf84fce2432f70949ab9e353ff2322a5f DIFF: https://github.com/llvm/llvm-project/commit/75e8a91cf84fce2432f70949ab9e353ff2322a5f.dif

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. This issue is being caused by wrong address being written to memory somewhere while single stepping though i have reached the exact problem but the logs seem to suggest it. LLDB Log without D63540 https://paste.ubuntu.com/p/zdXFrfN4M

[Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

Author: Raphael Isemann Date: 2019-12-16T12:43:55+01:00 New Revision: 22caa3cfbcf5762a47acc40c425d9fe0c40da621 URL: https://github.com/llvm/llvm-project/commit/22caa3cfbcf5762a47acc40c425d9fe0c40da621 DIFF: https://github.com/llvm/llvm-project/commit/22caa3cfbcf5762a47acc40c425d9fe0c40da621.dif

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. Could you check symtabs what symbols are located at: th1/fr0 with pc value of 0x102f0, symbol name is '_start' vs. th1/fr0 with pc value of 0xfe52, no symbol/function name is known. ? Or maybe just attached the main executable as `_start=0x102f0` is there I

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. Symbols sizes are being zeroed out Correct without D63540 : https://pastebin.ubuntu.com/p/fKGxFfwyxV/ Incorrect with D63540 : https://pastebin.ubuntu.com/p/XBTScYYkhq/ Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 755a66e - [lldb] Use file-based synchronization in TestVSCode_attach

Author: Pavel Labath Date: 2019-12-16T14:10:42+01:00 New Revision: 755a66ebdeda38669f5498565cbc6af331b47bad URL: https://github.com/llvm/llvm-project/commit/755a66ebdeda38669f5498565cbc6af331b47bad DIFF: https://github.com/llvm/llvm-project/commit/755a66ebdeda38669f5498565cbc6af331b47bad.diff

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

clayborg added a comment. Seems like it might be nice to have a macro defined in a LLDB header file like lldb-defines.h. Something like: #define PTR_TO_U64(x) ((uint64_t)(uintptr_t)(x)) Then we can make a unit test to verify it works on all systems. Seem like this issue will pop up all over

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

clayborg added a comment. > In other places you're replacing a reinterpret_cast with two c casts. > I guess this was done because two c++ casts were too long (?). In these cases > the second cast is not really needed, as uintptr_t->addr_t should convert > automatically. I think I'd prefer that

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil added a comment. In D71498#1786319 , @clayborg wrote: > For the printf style statement, we can't use just one cast to "uintptr_t" > because on 32 bit systems it won't be converted to 64 bit. That pointer-to-`uint64_t` is now used for `prin

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

clayborg added a comment. As I am reading this, I just wanted to send out a note of something else that can cause crashes in ARM/Thumb code. For anyone working with ARM/Thumb on systems that don't use the ARM and Thumb BKPT instruction when setting software breakpoints (like all lldb linux and

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

clayborg added a comment. In D71498#1786343 , @jankratochvil wrote: > In D71498#1786319 , @clayborg wrote: > > > For the printf style statement, we can't use just one cast to "uintptr_t" > > because on 32 bit syst

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor added a comment. @martong I added you as a reviewer because I assume you were interested in that development. I'm curious what you think should happen to the clang-import-test. We could either rewrite the tests as unit tests in the ASTImporterTest you guys are already using or we move

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor created this revision. teemperor added reviewers: shafik, martong. Herald added subscribers: lldb-commits, usaxena95, JDevlieghere, arphaman, christof, rnkovacs. Herald added a project: LLDB. teemperor added a comment. @martong I added you as a reviewer because I assume you were interes

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

jingham added a comment. In D71440#1783197 , @labath wrote: > This looks like a tricky bug. Thanks for tracking it down. > > I have two questions though: :D > > - could you use c++11 locking primitives in the test? pthreads do not work on > windows I co

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes updated this revision to Diff 234134. johannes retitled this revision from "[LLDB] Fix address computation for member function linked with lld" to "[LLDB] Fix address computation for inline function". johannes edited the summary of this revision. johannes added a comment. different appr

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes added a comment. Thanks for the very useful feedback! Now I can finally see why this is happening. Below is the relevant excerpt of the input DWARF: one of the DW_AT_low_pc attributes is NULL, which does not happen when I link with GNU ld. clang lldb/test/Shell/Expr/Inputs/function-

[Lldb-commits] [lldb] 3fbe518 - [lldb] Respect previously set values of LLDB_TABLEGEN_EXE

Author: Alex Langford Date: 2019-12-16T14:31:42-08:00 New Revision: 3fbe518a102a344abbd837e364a404c0c695d183 URL: https://github.com/llvm/llvm-project/commit/3fbe518a102a344abbd837e364a404c0c695d183 DIFF: https://github.com/llvm/llvm-project/commit/3fbe518a102a344abbd837e364a404c0c695d183.diff

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

paolosev created this revision. paolosev added reviewers: jasonmolenda, clayborg. paolosev added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits, sunfish, aheejin, jgravelle-google, sbc100, aprantl, mgorny, dschuff. Current versions of Clang emit (partial) DWARF debug i

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

aprantl added a comment. Sounds exciting. My comments are all about formatting and coding style, if someone has something technical to say, too that would be appreciated. Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:1 +//===-- DynamicLoade

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

sbc100 added a comment. I don't know the lldb codebase, but from a webassembly perspective this looks promising. I suppose we are long way from having a webassebly VM that exports that correct wire protocol to actually test this? Comment at: lldb/include/lldb/Utility/ArchSpe

[Lldb-commits] [lldb] 434905b - Run all threads when extending a next range over a call.

Author: Jim Ingham Date: 2019-12-16T17:45:21-08:00 New Revision: 434905b97d961531286d4b49c7ee1969f7cbea0e URL: https://github.com/llvm/llvm-project/commit/434905b97d961531286d4b49c7ee1969f7cbea0e DIFF: https://github.com/llvm/llvm-project/commit/434905b97d961531286d4b49c7ee1969f7cbea0e.diff LO

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

This revision was automatically updated to reflect the committed changes. Closed by commit rG434905b97d96: Run all threads when extending a next range over a call. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D71440?vs=234206&id=234207#toc Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

jingham updated this revision to Diff 234206. jingham added a comment. Changed the test case from locking.c - using pthreads directly - to locking.cpp using std::thread & Co. I also changed the test I cobbed this one from to use std::thread as well. I prospectively removed the expected fail Wi

[Lldb-commits] [lldb] 9e9c5f0 - Explicitly specify -std=c++11 and include and .

Author: Jim Ingham Date: 2019-12-16T18:09:24-08:00 New Revision: 9e9c5f0a6346ef02e31d5e8b91e6aab16a2e9370 URL: https://github.com/llvm/llvm-project/commit/9e9c5f0a6346ef02e31d5e8b91e6aab16a2e9370 DIFF: https://github.com/llvm/llvm-project/commit/9e9c5f0a6346ef02e31d5e8b91e6aab16a2e9370.diff LO

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. In D69309#1763454 , @v.g.vassilev wrote: > https://reviews.llvm.org/D41416 could be relevant. I am not an expert but I > think when reading the DWARF you could only register 'lazy' specializations > which will be imported only whe

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. In D69309#1752738 , @friss wrote: > Basically, today the debug info will describe an entity named "Foo". The > accelerator tables all reference this name. So when Clang asks us if we know > "Foo" (which is what happens when instant

[Lldb-commits] [lldb] 3c6554b - [lldb] Fix unused variable warning in ThreadPlanStepRange.cpp

Author: Raphael Isemann Date: 2019-12-17T08:53:06+01:00 New Revision: 3c6554be2e3c1500f825df5f7c186f2e58d6a33a URL: https://github.com/llvm/llvm-project/commit/3c6554be2e3c1500f825df5f7c186f2e58d6a33a DIFF: https://github.com/llvm/llvm-project/commit/3c6554be2e3c1500f825df5f7c186f2e58d6a33a.dif