[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

2019-10-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'm at the airport, so I haven't had a chance to look over the full set of changes you made, but here's my responses to your comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:778 + const char *script; + const char

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

2019-10-20 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

2019-10-20 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna updated this revision to Diff 225800. lawrence_danna added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/sc

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

2019-10-20 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna updated this revision to Diff 225799. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/incl

[Lldb-commits] [PATCH] D69226: [LLDB] [Windows] Initial support for ARM register contexts

2019-10-20 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, asmith, amccarth. Herald added subscribers: llvm-commits, JDevlieghere, teemperor, delcypher, kristof.beyls, mgorny. Herald added projects: LLDB, LLVM. Repository: rLLDB LLDB https://reviews.llvm.org/D69226 Files: l