[Lldb-commits] [lldb] r373998 - [lldb] Reverts part of 61f471a

2019-10-07 Thread Haibo Huang via lldb-commits
Author: hhb Date: Mon Oct 7 17:33:26 2019 New Revision: 373998 URL: http://llvm.org/viewvc/llvm-project?rev=373998&view=rev Log: [lldb] Reverts part of 61f471a Seems I wrongly merged an old patch. Reverts the change related to python dir for windows. FileSpec should always contain normalized p

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert created this revision. gmittert added reviewers: compnerd, kwk. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_target which cannot be exp

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

2019-10-07 Thread Haibo Huang via Phabricator via lldb-commits
hhb closed this revision. hhb added a comment. This is merged as 61f471a and 0016b45 . Closing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Alex Langford via Phabricator via lldb-commits
xiaobai added a reviewer: JDevlieghere. xiaobai added a comment. @JDevlieghere has been touching similar things today. You should coordinate with him on this change. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip)

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

2019-10-07 Thread António Afonso via Phabricator via lldb-commits
aadsm updated this revision to Diff 223707. aadsm added a comment. Don't destroy the Breakpad test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 Files: lldb/lit/SymbolFile/Breakpad/Inputs/basic

[Lldb-commits] [lldb] r374000 - [CMake] Add two more uses of add_lldb_test_dependency

2019-10-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Oct 7 17:44:54 2019 New Revision: 374000 URL: http://llvm.org/viewvc/llvm-project?rev=374000&view=rev Log: [CMake] Add two more uses of add_lldb_test_dependency Modified: lldb/trunk/CMakeLists.txt lldb/trunk/lit/CMakeLists.txt lldb/trunk/test/CMakeLists

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) xiaobai wrote: > why not `if(TARGET llvm-strip)`? I think that expresses the intent more > cleanly (and conforms t

[Lldb-commits] [PATCH] D68618: test fix: TestLoadUsingPaths should use realpath

2019-10-07 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TestLoadUsingPaths will fail if the build directory has symlinks in its path, because the real paths reported by the debu

[Lldb-commits] [lldb] r374005 - Fixing missing lldb-scripts rename from D68370

2019-10-07 Thread Antonio Afonso via lldb-commits
Author: aadsm Date: Mon Oct 7 18:10:03 2019 New Revision: 374005 URL: http://llvm.org/viewvc/llvm-project?rev=374005&view=rev Log: Fixing missing lldb-scripts rename from D68370 Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project

[Lldb-commits] [lldb] r374008 - Revert "ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested"

2019-10-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Oct 7 18:16:59 2019 New Revision: 374008 URL: http://llvm.org/viewvc/llvm-project?rev=374008&view=rev Log: Revert "ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested" This breaks TestProcessAttach and TestHelloWorld on Darwi

[Lldb-commits] [lldb] r374007 - test fix: TestLoadUsingPaths should use realpath

2019-10-07 Thread Lawrence D'Anna via lldb-commits
Author: lawrence_danna Date: Mon Oct 7 18:16:29 2019 New Revision: 374007 URL: http://llvm.org/viewvc/llvm-project?rev=374007&view=rev Log: test fix: TestLoadUsingPaths should use realpath Summary: TestLoadUsingPaths will fail if the build directory has symlinks in its path, because the real pat

Re: [Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

2019-10-07 Thread Jonas Devlieghere via lldb-commits
Hey Pavel, I've reverted your change in r374008. This was breaking TestProcessAttach and TestHelloWorld on Darwin. -- Jonas On Mon, Oct 7, 2019 at 1:57 PM Shafik Yaghmour via lldb-commits wrote: > > Pavel, > > It looks like this change breaks a couple of tests: > >http://lab.llvm.org:8080/g

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

2019-10-07 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, lanza. Herald added a project: LLDB. IOHandler needs to read lines of input from a lldb::File. The way it currently does this using, FILE*, which is something we want to avoid now. I'd pr

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

2019-10-07 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, + LookupPooledAddress) + .begin(); -

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

2019-10-07 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373927: [DWARFASTParserClang] Factor out structure-like type parsing, NFC (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D68536: [MachO] Fix symbol merging during symtab parsing.

2019-10-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4bddca306a45: [MachO] Fix symbol merging during symtab parsing. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68536/new/ https:/

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

2019-10-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373996: [CMake] Track test dependencies with add_lldb_test_dependency (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

2019-10-07 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373997: DWIMy filterspecs for dotest.py (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D68618: test fix: TestLoadUsingPaths should use realpath

2019-10-07 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL374007: test fix: TestLoadUsingPaths should use realpath (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

<    1   2