[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg are you on IRC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] r372203 - [lldb] Print better diagnostics for user expressions and modules

Author: teemperor Date: Wed Sep 18 01:53:35 2019 New Revision: 372203 URL: http://llvm.org/viewvc/llvm-project?rev=372203&view=rev Log: [lldb] Print better diagnostics for user expressions and modules Summary: Currently our expression evaluators only prints very basic errors that are not very us

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions and modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL372203: [lldb] Print better diagnostics for user expressions and modules (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [lldb] r372210 - [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

Author: stefan.graenitz Date: Wed Sep 18 03:20:28 2019 New Revision: 372210 URL: http://llvm.org/viewvc/llvm-project?rev=372210&view=rev Log: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly Summary: If we only get `LLVM_DIR` and find Clang in the same provided build-tree, automatically

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rL372210: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [lldb] r372213 - [lldb][CMake] Build LLDB.framework with -Wdocumentation in Xcode

Author: stefan.graenitz Date: Wed Sep 18 03:41:13 2019 New Revision: 372213 URL: http://llvm.org/viewvc/llvm-project?rev=372213&view=rev Log: [lldb][CMake] Build LLDB.framework with -Wdocumentation in Xcode Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake Modified: lldb/trunk/cmake/mod

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath added a comment. In D67589#1672686 , @jankratochvil wrote: > In D67589#1670966 , @labath wrote: > > > I agree that this approach isn't nice, but probably there isn't a nice > > approach to this at this poin

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked 6 inline comments as done. jankratochvil added a comment. In D67589#1673756 , @labath wrote: > We couldn't use PointerIntPair due to the our abi stability promise > (http://lldb.llvm.org/resources/sbapi.html). Thanks for this docume

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil updated this revision to Diff 220649. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/packages/Py

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. Yeah, that is a problem, though it's not really caused by you, and I am not sure even if your planned changed makes it worse (it looks like it *might* do that, but I'd have to dig deeper to tell for sure). If you found this issue by running the test suite, then I guess i

[Lldb-commits] [lldb] r372222 - Fix command-script-import.test on linux

Author: labath Date: Wed Sep 18 05:58:52 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37&view=rev Log: Fix command-script-import.test on linux The test was expecting the value of "lldb.frame" to be None, because it is cleared after each python interpreter session. Ho

[Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

labath added a comment. Unfortunately, there was a bug here which caused the test to fail on linux and windows. r37 ought to fix that. From the patch description: The test was expecting the value of "lldb.frame" to be None, because it is cleared after each python interpreter session. How

[Lldb-commits] [lldb] r372224 - Fir TestAPILog for gcc

Author: labath Date: Wed Sep 18 06:41:50 2019 New Revision: 372224 URL: http://llvm.org/viewvc/llvm-project?rev=372224&view=rev Log: Fir TestAPILog for gcc different compilers will put different things into __PRETTY_FUNCTION__. For instance gcc will not put a " " in the "const char *" argument, c

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

clayborg added a comment. In D67589#1673771 , @jankratochvil wrote: > In D67589#1673756 , @labath wrote: > > > We couldn't use PointerIntPair due to the our abi stability promise > > (http://lldb.llvm.org/resource

[Lldb-commits] [PATCH] D67727: [lldb] [Process/gdb-remote] Correct more missing LLDB_INVALID_SIGNAL_NUMBER

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Correct more uses of 0 instead of LLDB_INVALID_SIGNAL_NUMBER. https://reviews.llvm.org/D67727 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp Index: lldb/source/Plugins/Process/gdb

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1673356 , @ZeGentzy wrote: > Hello folks, > > These changes break running `ninja install` when building with `-D > LLVM_LIBDIR_SUFFIX=32`. > > [...] > -- Up-to-date: > /build/llvm-git-gentz/pkg/lib32-llvm-git-gentz/opt/

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1674430 , @hhb wrote: > In D67583#1673356 , @ZeGentzy wrote: > > > Hello folks, > > > > These changes break running `ninja install` when building with `-D > > LLVM_LIBDIR_SUFFIX=32`.

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil added a comment. In D67589#1674269 , @clayborg wrote: > We are making all efforts to vend a stable C++ API. IIUC you mean "stable C++ **ABI**" here. Thanks for the clarification. Maybe http://lldb.llvm.org/resources/sbapi.html could say th

Re: [Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

Wow, I really botched that test. How did that even pass locally? Thanks for fixing it! On Wed, Sep 18, 2019 at 6:03 AM Pavel Labath via Phabricator wrote: > > labath added a comment. > > Unfortunately, there was a bug here which caused the test to fail on linux > and windows. r37 ought to fi

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. That's odd > Can you share your full compile command and environment? I'm using this PKGBUILD: https://github.com/ZeGentzy/aur-buildscripts/blob/master/llvm-git-gentz/PKGBUILD#L376 The commands being run are these: export PKG_CONFIG_PATH="/usr/lib32/pkgconfig"

[Lldb-commits] [lldb] r372300 - [lldb] [Process/gdb-remote] Correct more missing LLDB_INVALID_SIGNAL_NUMBER

Author: mgorny Date: Wed Sep 18 22:49:14 2019 New Revision: 372300 URL: http://llvm.org/viewvc/llvm-project?rev=372300&view=rev Log: [lldb] [Process/gdb-remote] Correct more missing LLDB_INVALID_SIGNAL_NUMBER Correct more uses of 0 instead of LLDB_INVALID_SIGNAL_NUMBER. Differential Revision: ht

[Lldb-commits] [PATCH] D67727: [lldb] [Process/gdb-remote] Correct more missing LLDB_INVALID_SIGNAL_NUMBER

This revision was automatically updated to reflect the committed changes. Closed by commit rL372300: [lldb] [Process/gdb-remote] Correct more missing LLDB_INVALID_SIGNAL_NUMBER (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I don't have the right environment to try your command. But I didn't see anything obviously problematic. Can you try the following: cd /src/llvm-project/lldb/scripts/Python Then run the following python program: import sys sys.path.append('/src/llvm-project/lldb/scr

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. +deepak2427 since this behavior is introduced in https://github.com/llvm/llvm-project/commit/9b35cf52d2a88cda5167c9638696adce5b152720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583