[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

teemperor added a comment. Thanks! LGTM, but Jonas probably should also sign this off. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67083/new/ https://reviews.llvm.org/D67083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] r370702 - [lldb][NFC] Remove setup boilerplate from types/ tests

Author: teemperor Date: Tue Sep 3 00:33:32 2019 New Revision: 370702 URL: http://llvm.org/viewvc/llvm-project?rev=370702&view=rev Log: [lldb][NFC] Remove setup boilerplate from types/ tests This code doesn't seem to be necessary anymore. Modified: lldb/trunk/packages/Python/lldbsuite/test/t

[Lldb-commits] [lldb] r370706 - [lldb][NFC] Unify log files in commands/log/basic

Author: teemperor Date: Tue Sep 3 01:30:17 2019 New Revision: 370706 URL: http://llvm.org/viewvc/llvm-project?rev=370706&view=rev Log: [lldb][NFC] Unify log files in commands/log/basic Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py Modified: lldb/trun

[Lldb-commits] [lldb] r370712 - [lldb] Test 'command' commands and fix the found crashes

Author: teemperor Date: Tue Sep 3 02:06:12 2019 New Revision: 370712 URL: http://llvm.org/viewvc/llvm-project?rev=370712&view=rev Log: [lldb] Test 'command' commands and fix the found crashes Added: lldb/trunk/packages/Python/lldbsuite/test/commands/command/invalid-args/ lldb/trunk/pack

[Lldb-commits] [lldb] r370717 - [lldb][NFC] Also test unaliasing in nested_alias test

Author: teemperor Date: Tue Sep 3 02:19:51 2019 New Revision: 370717 URL: http://llvm.org/viewvc/llvm-project?rev=370717&view=rev Log: [lldb][NFC] Also test unaliasing in nested_alias test Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/command/nested_alias/TestNestedAlias.py

[Lldb-commits] [lldb] r370718 - [lldb][NFC] Simplify script_alias test

Author: teemperor Date: Tue Sep 3 02:21:47 2019 New Revision: 370718 URL: http://llvm.org/viewvc/llvm-project?rev=370718&view=rev Log: [lldb][NFC] Simplify script_alias test Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/command/script_alias/TestCommandScriptAlias.py Modified

[Lldb-commits] [lldb] r370719 - [lldb][NFC] Remove unnecessary constructors from invalid-args tests

Author: teemperor Date: Tue Sep 3 02:25:02 2019 New Revision: 370719 URL: http://llvm.org/viewvc/llvm-project?rev=370719&view=rev Log: [lldb][NFC] Remove unnecessary constructors from invalid-args tests Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/expression/invalid-args/Tes

[Lldb-commits] [lldb] r370724 - [lldb][NFC] Test that enabling all log options doesn't crash anything

Author: teemperor Date: Tue Sep 3 02:40:25 2019 New Revision: 370724 URL: http://llvm.org/viewvc/llvm-project?rev=370724&view=rev Log: [lldb][NFC] Test that enabling all log options doesn't crash anything Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py

[Lldb-commits] [lldb] r370733 - [lldb][NFC] Test 'command delete'

Author: teemperor Date: Tue Sep 3 03:13:45 2019 New Revision: 370733 URL: http://llvm.org/viewvc/llvm-project?rev=370733&view=rev Log: [lldb][NFC] Test 'command delete' Added: lldb/trunk/packages/Python/lldbsuite/test/commands/command/delete/ lldb/trunk/packages/Python/lldbsuite/test/co

[Lldb-commits] [lldb] r370734 - [lldb] Test 'frame select -r' and fix that INT32_MIN breaks the option parser

Author: teemperor Date: Tue Sep 3 03:15:45 2019 New Revision: 370734 URL: http://llvm.org/viewvc/llvm-project?rev=370734&view=rev Log: [lldb] Test 'frame select -r' and fix that INT32_MIN breaks the option parser Added: lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/ lld

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

krytarowski added a comment. This breaks NetBSD as it shall be paired with `llvm::call_once`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66566/new/ https://reviews.llvm.org/D66566 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] r370748 - [lldb] Replace std::call_once() with llvm::call_once()

Author: mgorny Date: Tue Sep 3 05:31:24 2019 New Revision: 370748 URL: http://llvm.org/viewvc/llvm-project?rev=370748&view=rev Log: [lldb] Replace std::call_once() with llvm::call_once() Remove the single instance of std::call_once() in lldbTarget library with llvm::call_once(). The former fail

[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

clayborg added a comment. In D67022#1653248 , @guiandrade wrote: > Hey guys, > > This change is more for me to get to know what you think. I've noticed that > the GetDeclForUIDFromDWARF() calls inside > SymbolFileDWARF::ParseDeclsForContext > (https://g

[Lldb-commits] [lldb] r370776 - [lldb][NFC] Disable added frame select and all log option test on windows

Author: teemperor Date: Tue Sep 3 09:21:57 2019 New Revision: 370776 URL: http://llvm.org/viewvc/llvm-project?rev=370776&view=rev Log: [lldb][NFC] Disable added frame select and all log option test on windows Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/TestFram

[Lldb-commits] [lldb] r370777 - [test] Remove print statements and verify that the symbol exists

Author: jdevlieghere Date: Tue Sep 3 09:26:44 2019 New Revision: 370777 URL: http://llvm.org/viewvc/llvm-project?rev=370777&view=rev Log: [test] Remove print statements and verify that the symbol exists This removes some (commented out) print statements and adds a line that verifies that uses im

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks like a very good idea! Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makef

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

JDevlieghere accepted this revision. JDevlieghere added a comment. This has always bothered me, but never enough to look into. Thanks for doing this, Pavel! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67083/new/ https://reviews.llvm.org/D67083 _

Re: [Lldb-commits] [lldb] r370776 - [lldb][NFC] Disable added frame select and all log option test on windows

Does disabling tests really quality a patch for the [NFC] label? Are these buggy tests or is there something that makes the actually not relevant on Windows? On Tue, Sep 3, 2019 at 9:20 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: teemperor > Date: Tue Sep

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makefile.write("include Makefile.rules\n") makefile.write("\ncleanu

[Lldb-commits] [lldb] r370785 - [test] Addres TestConcurrentMany*.py flakiness on macOS

Author: jdevlieghere Date: Tue Sep 3 10:04:04 2019 New Revision: 370785 URL: http://llvm.org/viewvc/llvm-project?rev=370785&view=rev Log: [test] Addres TestConcurrentMany*.py flakiness on macOS On "fast" macOS machines, the TestConcurrentMany*.py tests would fail randomly with different numbers

[Lldb-commits] [PATCH] D67064: [lldb][NFC] Remove lldbcurses.py

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yeah I removed the curses formatter last week. I wasn't sure if this was used by to test the curses GUI, so I wanted to check that before removing this too. Looks like you beat me

[Lldb-commits] [PATCH] D67075: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot

This revision was automatically updated to reflect the committed changes. Closed by commit rL370787: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:116 -makefile.write("include $(LEVEL)/Makefile.rules\n") +makefile.write("include Makefile.rules\n") makefile.write("\ncleanup:\n\trm -f Makefile *.d\n\n") -

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik created this revision. shafik added reviewers: jingham, jasonmolenda, aprantl. Herald added a reviewer: EricWF. Herald added subscribers: ldionne, christof. Performance issues lead to the libc++ `std::function` formatter to be disabled, see D65666 This ch

[Lldb-commits] [PATCH] D67116: [lldb][NFC] Remove unused overload of File::Read

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. It's neither used or tested here and in swift-lldb, so let's get rid of it. Repository: rLLDB LLDB https://reviews.llvm.org/D67116 Files: l

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

friss added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:44-46 +# We are running the lookups twice in some cases because now we are +# caching the results for s

[Lldb-commits] [PATCH] D67116: [lldb][NFC] Remove unused overload of File::Read

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. You can just go ahead with patches like this one. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67116/new/ https://reviews.llvm.org/D67116 ___

[Lldb-commits] [lldb] r370802 - [lldb][NFC] Remove unused overload of File::Read

Author: teemperor Date: Tue Sep 3 11:11:14 2019 New Revision: 370802 URL: http://llvm.org/viewvc/llvm-project?rev=370802&view=rev Log: [lldb][NFC] Remove unused overload of File::Read Summary: It's neither used or tested here and in swift-lldb, so let's get rid of it. Reviewers: #lldb, davide

[Lldb-commits] [lldb] r370804 - [lldb][NFC] Remove lldbcurses.py

Author: teemperor Date: Tue Sep 3 11:11:54 2019 New Revision: 370804 URL: http://llvm.org/viewvc/llvm-project?rev=370804&view=rev Log: [lldb][NFC] Remove lldbcurses.py Summary: This doesn't seem to be used anymore (at least I can't find any reference to this in the LLDB repo and it doesn't seem

[Lldb-commits] [PATCH] D67116: [lldb][NFC] Remove unused overload of File::Read

This revision was automatically updated to reflect the committed changes. Closed by commit rL370802: [lldb][NFC] Remove unused overload of File::Read (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D67064: [lldb][NFC] Remove lldbcurses.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL370804: [lldb][NFC] Remove lldbcurses.py (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D67123: [lldb] Use binary search in RangeDataVector:FindEntryIndexesThatContain

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, arphaman. Herald added a project: LLDB. We currently spend a lot of time in this function (around 27% of the br-by-regex benchmark in lldb-bench) by just iterating over all t

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth added a comment. I'm open to this if we can reduce the code duplication. One of my concerns is that changes in July and August completely broke the build for me for many days. I had to remove all but one version of Python to ensure that it always found the right one. I, too, would ap

[Lldb-commits] [PATCH] D67123: [lldb] Use binary search in RangeDataVector:FindEntryIndexesThatContain

teemperor added a comment. See the br-by-regex flamegraph: F9913466: br-by-regex.svg Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67123/new/ https://reviews.llvm.org/D67123 ___

[Lldb-commits] [PATCH] D67123: [lldb] Use binary search in RangeDataVector:FindEntryIndexesThatContain

amccarth added a comment. This feels very familiar. I think I've reviewed a similar change back when we first implemented minidumps. Comment at: lldb/include/lldb/Utility/RangeMap.h:739 +auto end = std::lower_bound(m_entries.begin(), m_entries.end(), +

[Lldb-commits] [PATCH] D67083: [dotest] Avoid the need for LEVEL= makefile boilerplate

amccarth accepted this revision. amccarth added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67083/new/ https://reviews.llvm.org/D67083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] r370814 - [Driver] Remove duplicate option parsing (NFC)

Author: jdevlieghere Date: Tue Sep 3 13:18:19 2019 New Revision: 370814 URL: http://llvm.org/viewvc/llvm-project?rev=370814&view=rev Log: [Driver] Remove duplicate option parsing (NFC) We were checking OPT_no_use_colors three times, twice to disable colors and once to enable debug mode. This sim

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

amccarth added a comment. This is looking pretty good. I'm wondering whether it needs some "negative" tests. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549 + llvm::Optional record = StackWinRecord::parse(*It); + assert(record.hasValue()); + ---

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

JDevlieghere added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D67022: Cache expanded CompilerDeclContext's to avoid parsing them multiple times

guiandrade updated this revision to Diff 218564. guiandrade marked 6 inline comments as done. guiandrade retitled this revision from "Skip getting declarations for repeated DIEs (WIP)" to "Cache expanded CompilerDeclContext's to avoid parsing them multiple times". guiandrade edited the summary of

[Lldb-commits] [PATCH] D67022: Cache expanded CompilerDeclContext's to avoid parsing them multiple times

guiandrade added a comment. Thank you so much for the thorough explanation and ideas, @labath and @clayborg. I forgot to mention that the initial motivation behind this change was to reduce those find calls as I saw they add up to a lot (10^5 calls debugging a Unreal engine sample at certain br

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade updated this revision to Diff 218581. guiandrade retitled this revision from "Cache expanded CompilerDeclContext's to avoid parsing them multiple times" to "Enhance SymbolFileDWARF::ParseDeclsForContext performance". guiandrade added a comment. Renaming the test Repository: rG LLV

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:48 ASSERT_EQ(2u, die_list.size()); - ASSERT_EQ(die2, die_list[0]); - ASSERT_EQ(die3, die_list[1]); + ASSERT_NE(die_list.end(), std::find(die_list.begin(), die_list.end

[Lldb-commits] [lldb] r370840 - [lldb] [test] Un-mark two commands/register tests XFAIL

Author: mgorny Date: Tue Sep 3 23:10:02 2019 New Revision: 370840 URL: http://llvm.org/viewvc/llvm-project?rev=370840&view=rev Log: [lldb] [test] Un-mark two commands/register tests XFAIL Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/register/register/register_command/TestReg

[Lldb-commits] [lldb] r370842 - [lldb] [test] Mark 'reenabled' tests XFAIL on NetBSD

Author: mgorny Date: Tue Sep 3 23:36:53 2019 New Revision: 370842 URL: http://llvm.org/viewvc/llvm-project?rev=370842&view=rev Log: [lldb] [test] Mark 'reenabled' tests XFAIL on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurren

[Lldb-commits] [PATCH] D67123: [lldb] Use binary search in RangeDataVector:FindEntryIndexesThatContain

labath added a comment. I remember seeing this inefficiency when looking at this class some time ago, but it was not clear to me what should be done about that. This is still an improvement, as it will reduce the time by 50% on average, but it is still going to be O(n). If this is really a perf