[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

teemperor updated this revision to Diff 214315. teemperor edited the summary of this revision. teemperor added a comment. - Now using std::enable_if - Fixed another implicit conversion that seems to be on purpose. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.

[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

labath updated this revision to Diff 214324. labath added a comment. - put back the line entry test input into an external file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65949/new/ https://reviews.llvm.org/D65949 Files: unittests/Core/CMakeLists.txt unittests/Core/Inputs/mangle

[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

labath edited reviewers, added: sgraenitz; removed: espindola, jdoerfert. labath added a subscriber: sgraenitz. labath added a comment. Herald added a reviewer: espindola. Herald added a reviewer: jdoerfert. In D65949#1622241 , @aadsm wrote: > I can see th

[Lldb-commits] [lldb] r368405 - [lldb][NFC] Use range-based for-loops in IRForTarget

Author: teemperor Date: Fri Aug 9 00:59:18 2019 New Revision: 368405 URL: http://llvm.org/viewvc/llvm-project?rev=368405&view=rev Log: [lldb][NFC] Use range-based for-loops in IRForTarget Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/source/

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It seems everybody agrees that this is the way forward. Comment at: llvm/include/llvm/ADT/StringExtras.h:52-53 /// Construct a string ref from a boolean. -inline StringRef t

[Lldb-commits] [lldb] r368406 - [lldb][NFC] Remove last C string uses from IRForTarget

Author: teemperor Date: Fri Aug 9 01:10:02 2019 New Revision: 368406 URL: http://llvm.org/viewvc/llvm-project?rev=368406&view=rev Log: [lldb][NFC] Remove last C string uses from IRForTarget Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

labath added a comment. In D65955#1621400 , @amccarth wrote: > I'm curious, though, where is the matching code? Should "unknown" be treated > as a wildcard when trying to find the matching module? The matching code lives ArchSpec::IsEqualTo, and its be

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. I still don't know much about this, but I am very happy that we're able to fix stuff by deleting code. We can always revisit this decision if we run into problems later on.. CHANGES

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

labath added a comment. This should be no longer relevant, right? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63868/new/ https://reviews.llvm.org/D63868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] r368415 - [lldb][NFC] Clean up logging in IRForTarget

Author: teemperor Date: Fri Aug 9 01:54:01 2019 New Revision: 368415 URL: http://llvm.org/viewvc/llvm-project?rev=368415&view=rev Log: [lldb][NFC] Clean up logging in IRForTarget Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/source/Plugins/E

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

jankratochvil abandoned this revision. jankratochvil added a comment. OK, right, closing it - I no longer see any functionality problem. Maybe one could do some more code refactorization but I do not have time for that now anyway. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [lldb] r368416 - Minidump/Windows: Fix module lookup

Author: labath Date: Fri Aug 9 02:10:50 2019 New Revision: 368416 URL: http://llvm.org/viewvc/llvm-project?rev=368416&view=rev Log: Minidump/Windows: Fix module lookup Summary: When opening a minidump, we were failing to find an executable because we were searching for i386-unknown-windows, wher

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL368416: Minidump/Windows: Fix module lookup (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] r368417 - [lldb] Refactor guard variable checks in IRForTarget

Author: teemperor Date: Fri Aug 9 02:27:04 2019 New Revision: 368417 URL: http://llvm.org/viewvc/llvm-project?rev=368417&view=rev Log: [lldb] Refactor guard variable checks in IRForTarget Not NFC as this will probably fix a wrong guard variable check on Windows. Not sure though what Windows test

[Lldb-commits] [lldb] r368424 - [lldb][NFC] Fix warning about missing switch cases

Author: teemperor Date: Fri Aug 9 02:58:47 2019 New Revision: 368424 URL: http://llvm.org/viewvc/llvm-project?rev=368424&view=rev Log: [lldb][NFC] Fix warning about missing switch cases These types were recently added in D62960 but it seems the patch didn't consider LLDB which causes a bunch of

[Lldb-commits] [lldb] r368425 - [lldb][NFC] Unify InstrList typedef in IRForTarget

Author: teemperor Date: Fri Aug 9 03:01:51 2019 New Revision: 368425 URL: http://llvm.org/viewvc/llvm-project?rev=368425&view=rev Log: [lldb][NFC] Unify InstrList typedef in IRForTarget Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/source/Pl

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor marked 2 inline comments as done. teemperor added a comment. In D65932#1621309 , @friss wrote: > I only have distant notions of what this code does, so this question might be > completely off: Is this the code that decides whether we need to rew

[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

fjricci abandoned this revision. fjricci added a comment. Didn’t realize I still had open revisions, haven’t worked on lldb in quite some time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44041/new/ https://reviews.llvm.org/D44041 ___ lld

[Lldb-commits] [lldb] r368442 - [lldb][NFC] Remove unused IRForTarget::BuildRelocation

Author: teemperor Date: Fri Aug 9 07:21:27 2019 New Revision: 368442 URL: http://llvm.org/viewvc/llvm-project?rev=368442&view=rev Log: [lldb][NFC] Remove unused IRForTarget::BuildRelocation Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r368444 - [lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest

Author: teemperor Date: Fri Aug 9 07:32:50 2019 New Revision: 368444 URL: http://llvm.org/viewvc/llvm-project?rev=368444&view=rev Log: [lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest Before we just triggered undefined behavior on invalid positions. Modified:

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

dblaikie added inline comments. Comment at: lldb/source/Symbol/TypeSystem.cpp:331 "TypeSystem for language " + - llvm::toStringRef(Language::GetNameForLanguageType(language)) + + llvm::StringRef(Language::GetNameForLanguageType(language)) +

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

clayborg added a comment. So I am confused. Are we keeping SymbolVendor around for locating symbols files or are we getting rid of it entirely? Comment at: include/lldb/Core/Module.h:989-996 + /// A pointer to the symbol file for this module. + std::unique_ptr m_symfile_up;

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

amccarth added a comment. It looks like the code changes landed (probably as part of another patch) but not the tests. I'll look and see if the tests should to be revived. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 _

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

jingham added a comment. In D56010#1623762 , @amccarth wrote: > It looks like the code changes landed (probably as part of another patch) but > not the tests. I'll look and see if the tests should to be revived. I can't see that any of these tests test

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

JDevlieghere updated this revision to Diff 214464. JDevlieghere added a comment. Herald added a reviewer: jdoerfert. Rebase and fix a bug in the support file implementation. I'm not sure why this didn't manifest itself earlier. I have a plan to benchmark this (using `image dump line-table`) but

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

hhb created this revision. hhb added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. hhb added a subscriber: kongyi. This fixes lldb build on macOS SDK prior to 10.12. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66034 Files:

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66034/new/ https://reviews.llvm.org/D66034 ___

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368496: Detects whether RESOURCE_TYPE_IO is defined. (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

amccarth added a comment. Just closing the loop. Regarding the "Python memory allocator called without holding the GIL" bugs: this is not a "just me" problem. It's for anyone who enables debug mode. This appears to be a test infrastructure problem, but it might be harmless. If I run in "re

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

aprantl added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:29 + typedef std::vector collection; + typedef collection::iterator iterator; + typedef collection::const_iterator const_iterator; JDevlieghere wrote: > grimar wrote: > > Seems yo