[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty created this revision. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, christof, delcypher. Herald added projects: LLDB, libc++, LLVM. On AIX psutil can run into problems with permissions to read the process tree, which causes problems for python tests. This patch a

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere added a project: LLDB. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Mention that LLVM 9 is the last release we'll ship lldb-mi as part of LLDB. Repository: rL LLVM https://reviews.l

[Lldb-commits] [PATCH] D64255: Remove lldb-mi

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: teemperor, jfb, abidh, mgorny, ki.stfu. Herald added a reviewer: jfb. Herald added a project: LLDB. This is the patch to remove `lldb-mi`, once LLVM 9 has branched. Repository: rLLDB LLDB https:

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

teemperor added a comment. +1 Nit pick: I think in 8.0.0 we actually gave LLDB it's own small section: https://releases.llvm.org/8.0.0/docs/ReleaseNotes.html#changes-to-lldb I guess we have some other stuff we could add to that section that it is not just "removed lldb-mi". Repository: rL

[Lldb-commits] [lldb] r365226 - Change LaunchThread interface to return an expected.

Author: jdevlieghere Date: Fri Jul 5 10:42:08 2019 New Revision: 365226 URL: http://llvm.org/viewvc/llvm-project?rev=365226&view=rev Log: Change LaunchThread interface to return an expected. Change the interface to return an expected, instead of taking a Status pointer. Differential revision: h

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide added a comment. I thought about this a little more, and we discussed offline, but these are my two comments (we should understand what's the behaviour and add tests). We can address some of them as follow-up but I would like to understand what happens here. 1. For C++, lldb names expre

[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365226: Change LaunchThread interface to return an expected. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

JDevlieghere updated this revision to Diff 208209. JDevlieghere added a comment. Move note into LLDB section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64254/new/ https://reviews.llvm.org/D64254 Files: llvm/docs/ReleaseNotes.rst Index: llvm/docs/ReleaseNotes.rst ===

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:98 +self.fatal("Setting a timeout per test requires the" +" Python psutil module but it could not be" +" found. Tr

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64254/new/ https://reviews.llvm.org/D64254 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365231: Add lldb-mi deprecation to the release notes (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D64254?vs=208209&id=208214#toc Repository: rL LLVM C

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

davide created this revision. davide added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64265 Files: lldb/include/lldb/Target/CPPLanguageRuntime.h lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/It

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64265/new/ https://reviews.llvm.org/D64265 __

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added a comment. @daltenty The "This removes our dependency on psutil." text sounds broader than it actually is. Looking at the implementation the removal of the dependency is only for AIX. All other platforms still depends on the `psutil` module. I think the commit message should be

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

teemperor accepted this revision. teemperor added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64265/new/ https://reviews.llvm.org/D64265 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] r365243 - [CplusPlus] ISVTableName is unused. NFCI.

Author: davide Date: Fri Jul 5 13:45:57 2019 New Revision: 365243 URL: http://llvm.org/viewvc/llvm-project?rev=365243&view=rev Log: [CplusPlus] ISVTableName is unused. NFCI. Reviewers: teemperor, JDevlieghere Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.or

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365243: [CplusPlus] ISVTableName is unused. NFCI. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:93 # See lit.util.killProcessAndChildren() -try: -import psutil # noqa: F401 -except ImportError: -self.fatal("Setting a timeout per

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, teemperor. Herald added a subscriber: abidh. Herald added a project: LLDB. We had a long discussion in D59911 about lldb_assert and what it means. The result was the //assert manifesto// on

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

JDevlieghere updated this revision to Diff 208235. JDevlieghere added a comment. Add comments with the exact wording from the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64267/new/ https://reviews.llvm.org/D64267 Files: lldb/source/Utility/LLDBAssert.cpp Index: lldb/source/

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

teemperor added a comment. Would it be possible to assert after the printing the stack trace? Having stack traces in bug reports is always nice to have and displaying the "Assertion failed: ..." message seems also useful for the user. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64267

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

JDevlieghere added a comment. In D64267#1571960 , @teemperor wrote: > Would it be possible to assert after the printing the stack trace? Having > stack traces in bug reports is always nice to have and displaying the > "Assertion failed: ..." message seem

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D64267#1571962 , @JDevlieghere wrote: > In D64267#1571960 , @teemperor wrote: > > > Would it be possi

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

davide added inline comments. Comment at: lldb/source/Utility/LLDBAssert.cpp:25-26 + // In a Debug configuration lldb_assert() behaves like assert(). + assert(false && "lldb_assert failed"); + + // In a Release configuration it will print a warning and encourage the user -

[Lldb-commits] [lldb] r365246 - lldb_assert: abort when assertions are enabled.

Author: jdevlieghere Date: Fri Jul 5 14:22:54 2019 New Revision: 365246 URL: http://llvm.org/viewvc/llvm-project?rev=365246&view=rev Log: lldb_assert: abort when assertions are enabled. We had a long discussion in D59911 about lldb_assert and what it means. The result was the assert manifesto on

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365246: lldb_assert: abort when assertions are enabled. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [lldb] r365247 - [lldb] Added assert to VerifyDecl

Author: teemperor Date: Fri Jul 5 14:32:39 2019 New Revision: 365247 URL: http://llvm.org/viewvc/llvm-project?rev=365247&view=rev Log: [lldb] Added assert to VerifyDecl We could VerifyDecl sometimes with a nullptr. It would be nice if we could get an actual assert here instead of triggering UB.

[Lldb-commits] [lldb] r365250 - [LLDBAssert] Use unreachable instead of assert(0)

Author: jdevlieghere Date: Fri Jul 5 14:54:20 2019 New Revision: 365250 URL: http://llvm.org/viewvc/llvm-project?rev=365250&view=rev Log: [LLDBAssert] Use unreachable instead of assert(0) As per Davide's suggestion offline. Modified: lldb/trunk/source/Utility/LLDBAssert.cpp Modified: lldb/