[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

labath added a reviewer: aprantl. labath added a comment. + Adrian, as I believe we touched this code recently... Comment at: include/lldb/Target/LanguageRuntime.h:160-162 + /// Identify whether a name is a runtime value that should not be hidden by + /// from the user interf

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added a comment. In D62503#1540959 , @aadsm wrote: > Yeah, that's a good question and I did think about it at the time I wrote > D62715 . Here's my rationale: > Regarding the chunk reading in the ReadMemory I was n

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, with the following comment taken into account. The ProcessFreeBSD parts are definitely wrong, as ProcessFreeBSD does not use lldb-server yet (it uses local only path). Just revert that p

[Lldb-commits] [lldb] r363250 - DWARF: Don't create lldb CompileUnits for DWARF type units

Author: labath Date: Thu Jun 13 04:22:47 2019 New Revision: 363250 URL: http://llvm.org/viewvc/llvm-project?rev=363250&view=rev Log: DWARF: Don't create lldb CompileUnits for DWARF type units Summary: Type units don't represent actual compilations and a lot of the operations that we do with lldb

[Lldb-commits] [PATCH] D63005: DWARF: Don't create lldb CompileUnits for DWARF type units

This revision was automatically updated to reflect the committed changes. Closed by commit rL363250: DWARF: Don't create lldb CompileUnits for DWARF type units (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

krytarowski added a comment. I would leave the NetBSD version as it is in this patch and let us to fix/test it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 _

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

labath created this revision. labath added reviewers: JDevlieghere, sgraenitz. Herald added subscribers: aprantl, mgorny. The motivation for this was me wanting to make the validity of dwarf DIERefs explicit (via llvm::Optional). This meant that the class would no longer have a default constructor

[Lldb-commits] [lldb] r363271 - [CMake] Add fallbacks for copying clang-resource-headers to LLDB.framework in standalone builds

Author: stefan.graenitz Date: Thu Jun 13 08:07:56 2019 New Revision: 363271 URL: http://llvm.org/viewvc/llvm-project?rev=363271&view=rev Log: [CMake] Add fallbacks for copying clang-resource-headers to LLDB.framework in standalone builds Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

clayborg added inline comments. Comment at: include/lldb/Core/UniqueCStringMap.h:87 T Find(ConstString unique_cstr, T fail_value) const { -Entry search_entry(unique_cstr); -const_iterator end = m_map.end(); -const_iterator pos = std::lower_bound(m_map.begin(), end,

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Core/ValueObject.cpp:1702-1724 + return runtime->IsRuntimeSupportValue(*this) && + !runtime->IsWhitelistedRuntimeValue(G

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Core/UniqueCStringMap.h:87 T Find(ConstString unique_cstr, T fail_value) const { -Entry search_entry(unique_cstr); -const_iterator end = m_map.end(); -const_iterator pos

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg updated this revision to Diff 204553. clayborg added a comment. Let compiler hoist "cu_language == eLanguageTypeObjC || cu_language == eLanguageTypeObjC_plus_plus" by inlining it into if statement so it is more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

clayborg added a comment. In D63165#1540606 , @Hui wrote: > > In D63165#1539118 , @amccarth > > wrote: > > > >> Sorry for the stupid question, but ... > >> > >> What exactly is meant here by "Native"? How is a Na

[Lldb-commits] [lldb] r363279 - [CMake] Fix lldb-dotest for single-config generators in standalone builds

Author: stefan.graenitz Date: Thu Jun 13 10:35:43 2019 New Revision: 363279 URL: http://llvm.org/viewvc/llvm-project?rev=363279&view=rev Log: [CMake] Fix lldb-dotest for single-config generators in standalone builds Differential Revision: https://reviews.llvm.org/D62859 Modified: lldb/trunk/

[Lldb-commits] [lldb] r363280 - [CMake] Fix generated Xcode-project ignoring output directory setting for LLDB.framework

Author: stefan.graenitz Date: Thu Jun 13 10:35:50 2019 New Revision: 363280 URL: http://llvm.org/viewvc/llvm-project?rev=363280&view=rev Log: [CMake] Fix generated Xcode-project ignoring output directory setting for LLDB.framework Other generators honor the `LIBRARY_OUTPUT_DIRECTORY` target prop

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm marked an inline comment as done. aadsm added a comment. I see what you mean, this is a good point. Yes, like you say I'm assuming the string I want to read is in a page that I can read using the fast method. And in this situation I prefer to minimize the number of calls to ReadMemory than

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked 3 inline comments as done. xiaobai added inline comments. Comment at: include/lldb/Target/LanguageRuntime.h:160-162 + /// Identify whether a name is a runtime value that should not be hidden by + /// from the user interface. + virtual bool IsWhitelistedRuntimeVa

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added inline comments. Comment at: lldb/unittests/Host/NativeProcessProtocolTest.cpp:128-133 + EXPECT_THAT_ERROR( + Process.ReadCStringFromMemory(0x0, &string[0], sizeof(string), bytes_read) + .ToError(), + llvm::Succeeded()); + EXPECT_STREQ(string, "

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks like the fallout of reflowing the comments. LGTM, Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63241/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/ https://reviews.llvm.org/D63171 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai updated this revision to Diff 204615. xiaobai added a comment. Simplify ValueObject::IsRuntimeSupportValue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRu

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

JDevlieghere added a comment. Let me know if you want me to commit this for you. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63241/new/ https://reviews.llvm.org/D63241 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai updated this revision to Diff 204648. xiaobai added a comment. Herald added a subscriber: mgorny. Implement suggestion Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63181/new/ https://reviews.llvm.org/D63181 Files: include/lldb/Breakpoint/Breakpoint.h inclu

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

amccarth added a comment. It's been a while for me, so I'm not super-familiar with the code being changed, but I'm okay with factoring out common code. I agree with labath's open points and will try to look at it in more detail tomorrow. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] r363338 - [NFC] Replace a plugin header with a non-plugin header

Author: xiaobai Date: Thu Jun 13 16:40:34 2019 New Revision: 363338 URL: http://llvm.org/viewvc/llvm-project?rev=363338&view=rev Log: [NFC] Replace a plugin header with a non-plugin header Modified: lldb/trunk/source/API/SBFrame.cpp Modified: lldb/trunk/source/API/SBFrame.cpp URL: http://ll

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

ziita added a comment. I have no access to commit. Could you please commit this patch? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63241/new/ https://reviews.llvm.org/D63241 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D63310: Make crashlog.py less noisy

aprantl created this revision. aprantl added reviewers: davide, jasonmolenda. Herald added a project: LLDB. For end-users there is no point in printing dSYM load errors for system frameworks, since they will all fail and there's nothing they can do about it. This patch hides them by default and

[Lldb-commits] [PATCH] D63310: Make crashlog.py less noisy

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63310/new/ https://reviews.llvm.org/D63310 __

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

aprantl created this revision. aprantl added reviewers: davide, JDevlieghere. Herald added a project: LLDB. Side question: do we need to do this on every subprocess.check_output() in this file? rdar://problem/51464644 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63311 File

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

davide added a comment. yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63311/new/ https://reviews.llvm.org/D63311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204695. kusmour added a comment. Added support for XMM registers. Now the step out on a function returns floating point number should have the right value. To play with it, define a function float getFloat(float value) { return value; } set a brea

[Lldb-commits] [lldb] r363356 - Fixed typos in Log.h

Author: jdevlieghere Date: Thu Jun 13 23:06:47 2019 New Revision: 363356 URL: http://llvm.org/viewvc/llvm-project?rev=363356&view=rev Log: Fixed typos in Log.h Patch by: Yuya Fujita Differential revision: https://reviews.llvm.org/D63241 Modified: lldb/trunk/include/lldb/Utility/Log.h Modif

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL363356: Fixed typos in Log.h (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63241?vs

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Yep, we should decode all the check_output results, as they may contain unicode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] r363357 - Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

Author: labath Date: Thu Jun 13 23:33:31 2019 New Revision: 363357 URL: http://llvm.org/viewvc/llvm-project?rev=363357&view=rev Log: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups Summary: The motivation for this was me wanting to make the validit

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rL363357: Make UniqueCStringMap work with non-default-constructible types and other… (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior