[Lldb-commits] [lldb] r361463 - Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

Author: jankratochvil Date: Thu May 23 01:00:49 2019 New Revision: 361463 URL: http://llvm.org/viewvc/llvm-project?rev=361463&view=rev Log: Simplify `GetName`+`AppendTypeName` by `DWARFDIE` In D61502#1503247 @clayborg suggested that DWARFUnit *+dw_offset_t can be now replaced by DWARFDIE. It is

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361463: Simplify `GetName`+`AppendTypeName` by `DWARFDIE` (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D62211?vs=200769&id=200883#toc Repository: r

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:585 + +def g_returns_correct_data(self): +procs = self.prep_debug_monitor_and_inferior() guiandrade wrote: > @labath, is it something

[Lldb-commits] [lldb] r361465 - DWARF: Don't compute address ranges for type units

Author: labath Date: Thu May 23 02:07:51 2019 New Revision: 361465 URL: http://llvm.org/viewvc/llvm-project?rev=361465&view=rev Log: DWARF: Don't compute address ranges for type units Summary: Type units don't describe any code, so they should never be the result of any address lookup queries. P

[Lldb-commits] [PATCH] D62178: DWARF: Don't compute address ranges for type units

This revision was automatically updated to reflect the committed changes. Closed by commit rL361465: DWARF: Don't compute address ranges for type units (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r361481 - Add REQUIRES: lld to debug-types-address-ranges.s

Author: labath Date: Thu May 23 03:46:35 2019 New Revision: 361481 URL: http://llvm.org/viewvc/llvm-project?rev=361481&view=rev Log: Add REQUIRES: lld to debug-types-address-ranges.s This should fix the green dragon bots. Modified: lldb/trunk/lit/SymbolFile/DWARF/debug-types-address-ranges.s

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

labath updated this revision to Diff 200934. labath marked 7 inline comments as done. labath added a comment. - implement the sugested changes (except the DenseMap part) - fix a bug where we would enter an infinite recursion in case the type in the type unit ended up referring back to itself (and

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:255 TypeList *type_list = dwarf->GetTypeList(); if (type_ptr == NULL) { + aprantl wrote: > Not your code, but it would be easier to follow the logic if we

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:706-713 - case DW_AT_ranges: { -lldb::offset_t ra

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:706-713 - case DW_AT_ranges: { -lldb::offset_t ranges_offset = -GetRangesOffset(dwarf2Data->DebugRanges(), form_value); -dw_

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I've made this change because a windows build bot fails with this error: FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Debugger.cpp.obj C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

labath added a comment. returning `lldb::thread_result_t()` is probably the best thing to do here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 ___ lldb-co

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200951. kwk added a comment. Fixed second place where nullptr couldn't be converted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk added a comment. In D62305#1513642 , @labath wrote: > returning `lldb::thread_result_t()` is probably the best thing to do here... @labath I've followed your advice. Running tests for linux now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200953. kwk added a comment. Return lldb::thread_result_t() instead of NULL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.cpp ll

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

jankratochvil added a comment. In D62305#1513642 , @labath wrote: > returning `lldb::thread_result_t()` is probably the best thing to do here... I would say `return {};` is the best one, it has 118 uses in `lldb/`. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

labath added a comment. In D62305#1513793 , @jankratochvil wrote: > In D62305#1513642 , @labath wrote: > > > returning `lldb::thread_result_t()` is probably the best thing to do here... > > > I would say `return {}

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

probinson added a comment. Drive-by: For the "dead code" did you check whether gcc emits DW_AT_start_scope? LLDB should support more than just what Clang emits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62302/new/ https://reviews.llvm.org/D62302

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath added a comment. In D62302#1513824 , @probinson wrote: > Drive-by: For the "dead code" did you check whether gcc emits > DW_AT_start_scope? LLDB should support more than just what Clang emits. I agree with that, but the fact that clang does not

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

labath added a comment. (and no, I didn't check whether gcc emits the attribute) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62302/new/ https://reviews.llvm.org/D62302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D62302: DWARF: Fix address range support in mixed 4+5 scenario

clayborg added a comment. Nice patch. See inlined comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:435-448 + llvm::Expected expected_ranges = + (form_value.Form() == DW_FORM_rnglistx) + ? cu->FindRnglistFromInd

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath created this revision. labath added reviewers: aprantl, JDevlieghere, clayborg. Herald added a subscriber: arphaman. SymbolFileDWARF used to load debug sections in a thread-safe manner. When we moved to DWARFContext, we dropped the thread-safe part, because we thought it was not necessary.

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200969. kwk added a comment. - Return empty lldb::thread_result_t as {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.cpp lldb/s

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath added a comment. Two other options I see are: - initialize the sections immediately after creating the dwarf context. The main advantage of that would that it alings to code more with llvm (which also loads the sections up-front), and slighly faster subsequent accesses to the debug info

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.h:25 + struct SectionData { +llvm::once_flag flag; +DWARFDataExtractor data; is llv

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

clayborg added a comment. In D62316#1513894 , @labath wrote: > Two other options I see are: > > - initialize the sections immediately after creating the dwarf context. The > main advantage of that would that it alings to code more with llvm (which > also

[Lldb-commits] [lldb] r361503 - [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

Author: kwk Date: Thu May 23 08:17:39 2019 New Revision: 361503 URL: http://llvm.org/viewvc/llvm-project?rev=361503&view=rev Log: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t' Summary: On Windows `lldb::thread_result_t` resolves to `typedef unsigned thread_result_t;` and on

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361503: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t' (authored by kwk, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D623

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

stella.stamenova added a comment. It looks like this was not enough and the build is still broken. Please revert your change or fix it and then keep an eye on the Buildbot to make sure it turns to green again. Once it's broken, it won't continue sending failure emails, so you have to monitor it

Re: [Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

That should have been a separate commit, I was rushing to get the build unbroken. But this is a good change, we shouldn't silently fail to load the history file, that's pretty confusing. Dumping to the edit line output file is not great but we're not running commands at this point so there's n

[Lldb-commits] [lldb] r361528 - [HostNativeThreadBase] Undo nullptr changes

Author: jdevlieghere Date: Thu May 23 11:15:43 2019 New Revision: 361528 URL: http://llvm.org/viewvc/llvm-project?rev=361528&view=rev Log: [HostNativeThreadBase] Undo nullptr changes The thread result type is an unsigned instead of a pointer on windows, so we shouldn't replace 0 with nullptr here

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

jgorbe created this revision. jgorbe added reviewers: clayborg, zturner. Herald added a subscriber: jdoerfert. The copy constructor of RegularExpression doesn't initialize m_comp_err. This causes an use-of-initialized-value error when a RegularExpression is copied: the copy constructor calls Com

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

jgorbe updated this revision to Diff 201029. jgorbe added a comment. Fixed indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62334/new/ https://reviews.llvm.org/D62334 Files: lldb/source/Utility/RegularExpression.cpp Index: lldb/source/Utility/RegularExpression.cpp ===

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing this error on windows build bot: E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'nu

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

stella.stamenova added a comment. This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62337/new/ https://reviews.llvm.org/D62337 __

[Lldb-commits] [lldb] r361539 - [gdb-remote] Fix more issues with thread_result_t

Author: jdevlieghere Date: Thu May 23 12:32:46 2019 New Revision: 361539 URL: http://llvm.org/viewvc/llvm-project?rev=361539&view=rev Log: [gdb-remote] Fix more issues with thread_result_t More fixes needed to un-break the Windows bot. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/G

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

JDevlieghere added a comment. I already pushed a fix for this. There were additional errors in the gdb remote code. Since I don't have a Windows I'm waiting on the Windows bot to see what else needs to be fixed :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. nvm my previous comment, I didn't check the left hand side... LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62337/new/ https:

[Lldb-commits] [lldb] r361544 - [Utility] Avoid a few unnecessary copies (NFC)

Author: jdevlieghere Date: Thu May 23 13:05:21 2019 New Revision: 361544 URL: http://llvm.org/viewvc/llvm-project?rev=361544&view=rev Log: [Utility] Avoid a few unnecessary copies (NFC) Avoid unnecessary copies by either passing by const-reference or moving the argument. Modified: lldb/trunk

[Lldb-commits] [lldb] r361546 - [lldb] Make sure RegularExpression constructors always initialize member variables

Author: jgorbe Date: Thu May 23 13:11:17 2019 New Revision: 361546 URL: http://llvm.org/viewvc/llvm-project?rev=361546&view=rev Log: [lldb] Make sure RegularExpression constructors always initialize member variables The copy constructor of RegularExpression doesn't initialize m_comp_err. This c

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361546: [lldb] Make sure RegularExpression constructors always initialize member… (authored by jgorbe, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [lldb] r361548 - [Process] Fix another thread_result_t & nullptr incompatibility.

Author: jdevlieghere Date: Thu May 23 13:25:49 2019 New Revision: 361548 URL: http://llvm.org/viewvc/llvm-project?rev=361548&view=rev Log: [Process] Fix another thread_result_t & nullptr incompatibility. Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Proces

[Lldb-commits] [lldb] r361555 - [NFC] Add blank line (test commit)

Author: jryans Date: Thu May 23 14:13:50 2019 New Revision: 361555 URL: http://llvm.org/viewvc/llvm-project?rev=361555&view=rev Log: [NFC] Add blank line (test commit) Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361565: [lldb] followup fix for https://reviews.llvm.org/D62305 (authored by kwk, committed by ). Changed prior to commit: https://reviews.llvm.org/D62337?vs=201032&id=201082#toc Repository: rLLDB

[Lldb-commits] [lldb] r361565 - [lldb] followup fix for https://reviews.llvm.org/D62305

Author: kwk Date: Thu May 23 15:39:13 2019 New Revision: 361565 URL: http://llvm.org/viewvc/llvm-project?rev=361565&view=rev Log: [lldb] followup fix for https://reviews.llvm.org/D62305 Summary: Fixing this error on windows build bot: ``` E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\sou

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

shafik created this revision. shafik added reviewers: martong, teemperor, jasonmolenda, friss. Herald added a subscriber: rnkovacs. https://reviews.llvm.org/D51633 added error handling to the `ASTNodeImporter::VisitRecordDecl` for the conflicting names case. This could lead to erroneous return o

[Lldb-commits] [PATCH] D62284: Replace integer literals which are cast to bool

davide accepted this revision as: LLDB. davide added a comment. Herald added a subscriber: rnkovacs. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62284/new/ https://reviews.llvm.org/D62284 ___ lldb-commits ma

[Lldb-commits] [lldb] r361580 - Fix integer literals which are cast to bool

Author: jdevlieghere Date: Thu May 23 17:44:33 2019 New Revision: 361580 URL: http://llvm.org/viewvc/llvm-project?rev=361580&view=rev Log: Fix integer literals which are cast to bool This change replaces built-in types that are implicitly converted to booleans. Differential revision: https://rev

[Lldb-commits] [PATCH] D62284: Replace integer literals which are cast to bool

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361580: Fix integer literals which are cast to bool (authored by JDevlieghere, committed by ). Changed prior to commit

[Lldb-commits] [lldb] r361583 - Revert "[lldb] followup fix for https://reviews.llvm.org/D62305"

Author: jdevlieghere Date: Thu May 23 18:08:54 2019 New Revision: 361583 URL: http://llvm.org/viewvc/llvm-project?rev=361583&view=rev Log: Revert "[lldb] followup fix for https://reviews.llvm.org/D62305"; This fails on the Windows bot: cannot convert from 'initializer list' to 'lldb::thread_resu

Re: [Lldb-commits] [lldb] r361565 - [lldb] followup fix for https://reviews.llvm.org/D62305

On Thu, 23 May 2019 at 15:39, Konrad Kleine via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: kwk > Date: Thu May 23 15:39:13 2019 > New Revision: 361565 > > URL: http://llvm.org/viewvc/llvm-project?rev=361565&view=rev > Log: > [lldb] followup fix for https://reviews.llvm.org/D62305

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

omjavaid added a comment. Hi This change breaks arm/aarch64 linux builds. http://147.75.106.138:32769/builders/lldb-aarch64-ubuntu/builds/47 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62337/new/ https://reviews.llvm.org/D62337 __

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

JDevlieghere added a comment. I reverted this because it broke the Windows bot again :( E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'initializer list' to 'lldb::thread_result_t' E:\

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

JDevlieghere added a comment. In D62337#1515041 , @omjavaid wrote: > Hi > > This change breaks arm/aarch64 linux builds. > > http://147.75.106.138:32769/builders/lldb-aarch64-ubuntu/builds/47 Always great to see more lldb bots! Is there any reason this b

Re: [Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

On Fri, 24 May 2019 at 06:15, Jonas Devlieghere via Phabricator wrote: > > JDevlieghere added a comment. > > In D62337#1515041 , @omjavaid wrote: > > > Hi > > > > This change breaks arm/aarch64 linux builds. > > > > http://147.75.106.138:32769/builders/lldb

[Lldb-commits] [lldb] r361597 - [Utility] Small improvements to the Broadcaster class (NFC)

Author: jdevlieghere Date: Thu May 23 21:41:47 2019 New Revision: 361597 URL: http://llvm.org/viewvc/llvm-project?rev=361597&view=rev Log: [Utility] Small improvements to the Broadcaster class (NFC) I touched the Broadcaster class earlier today (r361544) and noticed a few things that could be imp