[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL359281: Allow direct comparison of ConstString against StringRef (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [lldb] r359281 - Allow direct comparison of ConstString against StringRef

Author: teemperor Date: Fri Apr 26 00:21:36 2019 New Revision: 359281 URL: http://llvm.org/viewvc/llvm-project?rev=359281&view=rev Log: Allow direct comparison of ConstString against StringRef Summary: When we want to compare a ConstString against a string literal (or any other non-ConstString),

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D61074#1479304 , @mgorny wrote: > Added a 32-bit version of the test, and constexpr. > > I propose to keep the dotest tests until I reimplement ZMM a

[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter

labath added a comment. Seems like a good change to me, but Jim should have a look as he requested that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61172/new/ https://reviews.llvm.org/D61172 ___ lldb-commits mai

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

labath added a comment. In D61090#1479049 , @jingham wrote: > I really thought there was one at the SB layer, because in terms of design > that is what makes sense. I guess we never really needed it until now, so we > didn't add it. Once there's more t

[Lldb-commits] [lldb] r359288 - PostfixExpression: move DWARF generator out of NativePDB internals

Author: labath Date: Fri Apr 26 01:52:04 2019 New Revision: 359288 URL: http://llvm.org/viewvc/llvm-project?rev=359288&view=rev Log: PostfixExpression: move DWARF generator out of NativePDB internals Summary: The new dwarf generator is pretty much a verbatim copy of the one in PDB. In order to w

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359288: PostfixExpression: move DWARF generator out of NativePDB internals (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D61056?

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:242 +// Instantiate the template. +found_decl = ClassTemplateSpecializationDecl::Create( +m_sema->getASTContext(), teemperor wrote: > martong wrote: > > martong wro

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:242 +// Instantiate the template. +found_decl = ClassTemplateSpecializationDecl::Create( +m_sema->getASTContext(), martong wrote: > teemperor wrote: > > martong wro

[Lldb-commits] [PATCH] D61182: DWARFExpression: Fix implementation of DW_OP_pick

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added subscribers: aprantl, mgorny. The DWARF spec states that the DWARF stack arguments are numbered from the top. Our implementation of DW_OP_pick was counting them from the bottom. This bug probably wasn't not

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath added a comment. PS: Although this patch is technically dependency free, for this to work as a part of the bigger picture, we'll need to get lldb's dwarf evaluator to actually push the CFA value to the dwarf stack (D61018 ) and fix its implementation of D

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath created this revision. labath added reviewers: amccarth, clayborg, aleksandr.urakov. Herald added a subscriber: aprantl. This node represents the "Canonical Frame Address" of the current frame, and is used by various DWARF expressions to express adresses of various objects relative to the f

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg w

[Lldb-commits] [lldb] r359304 - [lldb] [lit] Add register read tests for YMM registers (AVX)

Author: mgorny Date: Fri Apr 26 06:21:58 2019 New Revision: 359304 URL: http://llvm.org/viewvc/llvm-project?rev=359304&view=rev Log: [lldb] [lit] Add register read tests for YMM registers (AVX) Differential Revision: https://reviews.llvm.org/D61074 Added: lldb/trunk/lit/Register/Inputs/x86-y

[Lldb-commits] [lldb] r359303 - [lldb] [lit] Add feature flags for native CPU features

Author: mgorny Date: Fri Apr 26 06:21:46 2019 New Revision: 359303 URL: http://llvm.org/viewvc/llvm-project?rev=359303&view=rev Log: [lldb] [lit] Add feature flags for native CPU features Add a new lit-cpuid tool that detects CPU features used by some of the tests, and use it to populate availabl

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

This revision was automatically updated to reflect the committed changes. Closed by commit rL359303: [lldb] [lit] Add feature flags for native CPU features (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359304: [lldb] [lit] Add register read tests for YMM registers (AVX) (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

labath created this revision. labath added reviewers: christos, krytarowski, davide. Despite the documentation for the el_get(EL_GETTC) function claiming the vararg part is (const char *name, void *value), in reality the function expects the vararg list to be terminated by a null pointer, which ca

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

labath added a comment. You can see the relevant part of the source code here https://github.com/cdesjardins/libedit/blob/master/src/eln.c#L310 (not the canonical source, but at least it's easy to link to). @christos, any chance of getting this fixed (either the docs, or the source code)? CH

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM but this should really be fixed upstream (in libedit) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61191/new/ https://reviews.llvm.org/D61191

[Lldb-commits] [lldb] r359319 - Replace local utility class OnExit with llvm::scope_exit (NFC)

Author: tkrasnukha Date: Fri Apr 26 09:41:04 2019 New Revision: 359319 URL: http://llvm.org/viewvc/llvm-project?rev=359319&view=rev Log: Replace local utility class OnExit with llvm::scope_exit (NFC) Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 196874. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

On Apr 26, 3:11pm, revi...@reviews.llvm.org (Pavel Labath via Phabricator) wrote: -- Subject: [PATCH] D61191: Editline: Fix an msan error | | --b1_b299efcc557883c5ff30a5eebc16e12b | Content-Type: text/plain; charset=us-ascii | Content-Transfer-Encoding: quoted-printable | | labath created this

[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter

jingham added a comment. Looks good to me too. The fact that you were mostly eliminating redirections from CommandInterpreter -> Debugger is good evidence this was wrongly structured initially. I'm a little curious that we do: m_debugger.GetCommandInterpreter().GetPythonCommandsFromIOHandle

Re: [Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

> On Apr 26, 2019, at 1:29 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D61090#1479049 , @jingham wrote: > >> I really thought there was one at the SB layer, because in terms of design >> that is what makes sense. I g

[Lldb-commits] [lldb] r359330 - [ScriptInterpreter] Pass the debugger instead of the command interpreter

Author: jdevlieghere Date: Fri Apr 26 10:58:19 2019 New Revision: 359330 URL: http://llvm.org/viewvc/llvm-project?rev=359330&view=rev Log: [ScriptInterpreter] Pass the debugger instead of the command interpreter As discussed in D61090, there's no good reason for the script interpreter to depend o

[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Oops, forgot to do the action part of this... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61172/new/ https://reviews.llvm.org/D61172 _

[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rL359330: [ScriptInterpreter] Pass the debugger instead of the command interpreter (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [lldb] r359346 - [CommandInterpreter] Remove scripting language argument. (NFC)

Author: jdevlieghere Date: Fri Apr 26 13:03:22 2019 New Revision: 359346 URL: http://llvm.org/viewvc/llvm-project?rev=359346&view=rev Log: [CommandInterpreter] Remove scripting language argument. (NFC) The script language argument was passed from the debugger to the command interpreter, only to c

[Lldb-commits] [lldb] r359347 - TestZMMRegister: use an integer division as intended

Author: friss Date: Fri Apr 26 13:23:55 2019 New Revision: 359347 URL: http://llvm.org/viewvc/llvm-project?rev=359347&view=rev Log: TestZMMRegister: use an integer division as intended Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/register/intel_avx/TestZMMRegister.py

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Introduce tests for reading the eight x86 general purpose registers, i.e. RAX/RBX/RCX/RDX/RBP/RSP/RSI/RDI and their shorter counterparts. The test comes in separate 32-bit and 64-bit variant, targeting appropriate processor

[Lldb-commits] [PATCH] D61211: [ScriptInterpreter] Move ownership into debugger (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: LLDB. This is part two of the change started in r359330. This patch moves the ownership of the script interpreter from the command interpreter into the debugger. I would've preferred to remove the

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

clayborg added a comment. FYI: for all DWARF expressions found in EH frame stuff, they expect the CFA address to be pushed onto the stack prior to executing the expression. Do we just want to follow suit with the these expressions and avoid the extra needed node? CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

clayborg added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); anton.kolesov w

[Lldb-commits] [lldb] r359349 - Pass explicit C++ version to test

Author: friss Date: Fri Apr 26 14:16:15 2019 New Revision: 359349 URL: http://llvm.org/viewvc/llvm-project?rev=359349&view=rev Log: Pass explicit C++ version to test stop-hook-threads.cpp uses C++11 features, so ask for C++11 explicitely. This isn't broken on mainstream because clang defaults to

[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a subscriber: delcypher. Disclaimer: I don't have access to any hardware capable of AVX512, so I haven't tested it. https://reviews.llvm.org/D61212 Files: lldb/lit/Register/Inputs/x86-zmm-read.cpp lldb/

[Lldb-commits] [PATCH] D61211: [ScriptInterpreter] Move ownership into debugger (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks nicer! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61211/new/ https://reviews.llvm.org/D61211 _

[Lldb-commits] [lldb] r359354 - [ScriptInterpreter] Move ownership into debugger (NFC)

Author: jdevlieghere Date: Fri Apr 26 15:43:16 2019 New Revision: 359354 URL: http://llvm.org/viewvc/llvm-project?rev=359354&view=rev Log: [ScriptInterpreter] Move ownership into debugger (NFC) This is part two of the change started in r359330. This patch moves the ownership of the script interpr

[Lldb-commits] [PATCH] D61211: [ScriptInterpreter] Move ownership into debugger (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359354: [ScriptInterpreter] Move ownership into debugger (NFC) (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61211?vs=196913&id=196922#toc Repository:

[Lldb-commits] [lldb] r359355 - [Driver] Remove unused functions (NFC)

Author: jdevlieghere Date: Fri Apr 26 15:54:39 2019 New Revision: 359355 URL: http://llvm.org/viewvc/llvm-project?rev=359355&view=rev Log: [Driver] Remove unused functions (NFC) Remove unused from the driver class. I noticed a bunch of small thing while doing this that didn't warrant separate com

[Lldb-commits] [PATCH] D61216: [Docs] Make it possible to generate the python reference without building all of LLDB

JDevlieghere created this revision. JDevlieghere added reviewers: labath, ted. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. As discussed on the mailing list, we should be able to generate the Python reference without building all of LLDB. To make that possible I create a

[Lldb-commits] [PATCH] D61218: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory()

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a project: LLDB. GetSDKVersion expects the number of version fields not their byte size and will happily overwrite later contents of the stack. I just found this by accident while stepping through the fun

[Lldb-commits] [PATCH] D61218: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory()

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61218/new/ https://reviews.llvm.org/D61218 __

[Lldb-commits] [lldb] r359372 - [FormatEntity] Remove unused format type (NFC)

Author: jdevlieghere Date: Fri Apr 26 22:36:57 2019 New Revision: 359372 URL: http://llvm.org/viewvc/llvm-project?rev=359372&view=rev Log: [FormatEntity] Remove unused format type (NFC) The FormatType enum and corresponding field are unused. This patch removes the type, field and simplifies the m

[Lldb-commits] [lldb] r359373 - [CommandObject] Use GetDebugger() helper method (NFC)

Author: jdevlieghere Date: Fri Apr 26 23:19:42 2019 New Revision: 359373 URL: http://llvm.org/viewvc/llvm-project?rev=359373&view=rev Log: [CommandObject] Use GetDebugger() helper method (NFC) In r359354 a GetDebugger() method was added to the CommandObject class, so that we didn't have to go thr

[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

mgorny updated this revision to Diff 196948. mgorny added a comment. Herald added a subscriber: srhines. Included dotest test removal for completeness. I'm going to commit it separately though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61212/new/ https://reviews.llvm.org/D61212 Fi