teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLDB.
When we want to compare a ConstString against a string literal (or any other
non-ConstString),
Author: teemperor
Date: Sun Apr 14 07:01:49 2019
New Revision: 358357
URL: http://llvm.org/viewvc/llvm-project?rev=358357&view=rev
Log:
Prevent unnecessary conversion from StringRef to C-string [NFC]
There is an alternative method to GetConstCStringWithLength that
takes a StringRef. GetConstCStri
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks for doing this, Raphael!
I wonder if there's situations where this could be confusing/not what you'd
expect, but I can't immediately think of anything. If t
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Sorry for the long delay with the response, I had days off. LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60599/new/
https://reviews.llvm.org/D60599