[Lldb-commits] [lldb] r358261 - PDBFPO: Improvements to the AST visitor

Author: labath Date: Fri Apr 12 00:19:00 2019 New Revision: 358261 URL: http://llvm.org/viewvc/llvm-project?rev=358261&view=rev Log: PDBFPO: Improvements to the AST visitor Summary: This patch attempts to solve two issues made this code hard to follow for me. The first issue was that a lot of wh

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358261: PDBFPO: Improvements to the AST visitor (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [lldb] r358265 - [lldb-server] Update tests to use std::thread/mutex for all platforms

Author: asmith Date: Fri Apr 12 00:48:49 2019 New Revision: 358265 URL: http://llvm.org/viewvc/llvm-project?rev=358265&view=rev Log: [lldb-server] Update tests to use std::thread/mutex for all platforms Summary: Some cleanup suggested when bringing up lldb-server on Windows. Thanks to Hui Huang

[Lldb-commits] [lldb] r358266 - Make TestPrintStackTraces deterministic

Author: labath Date: Fri Apr 12 01:02:28 2019 New Revision: 358266 URL: http://llvm.org/viewvc/llvm-project?rev=358266&view=rev Log: Make TestPrintStackTraces deterministic This test contained an incredibly complicated inferior, but in reality, all it was testing was that we can backtrace up to m

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

labath created this revision. labath added reviewers: jasonmolenda, amccarth, clayborg, JDevlieghere, aleksandr.urakov. Herald added a subscriber: aprantl. The NativePDB plugin contains code to convert "programs" describing the layout of function frames into dwarf (for easier interaction with the

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

JDevlieghere added a comment. Makes sense, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60599/new/ https://reviews.llvm.org/D60599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D60608: Make TestVSCode_step pass reliably

labath created this revision. labath added reviewers: clayborg, jgorbe. Herald added a subscriber: jfb. The test was failing occasionally (1% of runs or so), because of unpredictable timings between the two threads spawned by the test. If the second thread hit the breakpoint right as we were stepp

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

teemperor added a comment. I believe this revision introduced a warning when compiling with Clang: 98% [4004/4047] Building CXX object tooldir/PdbFPOProgramToDWARFExpression.cpp.o /home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpres

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath added a comment. In D60410#1464214 , @teemperor wrote: > I believe this revision introduced a warning when compiling with Clang: > >98% [4004/4047] Building CXX object > tooldir/PdbFPOProgramToDWARFExpression.cpp.o > > /home/teemperor/ll

[Lldb-commits] [lldb] r358284 - Fix compiler warning introduced by r358261

Author: labath Date: Fri Apr 12 06:48:01 2019 New Revision: 358284 URL: http://llvm.org/viewvc/llvm-project?rev=358284&view=rev Log: Fix compiler warning introduced by r358261 Add a virtual destructor to the class with virtual methods. Modified: lldb/trunk/source/Plugins/SymbolFile/NativePD

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

clayborg added a comment. Just thought of 1 additional way to allow us to pull in fewer var declarations: get a list of all of the member variable names in the current class when stopped in a class method and only add ones that match local variables. If we are in a static member variable then s

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor updated this revision to Diff 194895. teemperor added a comment. - Added more documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59537/new/ https://reviews.llvm.org/D59537 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbol/ClangASTImporte

Re: [Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

This won't be complete, since we also get collisions between local variables and namespaces, and that wouldn't be detected by your heuristic. I think the trick that Fred used in https://reviews.llvm.org/D46551 is actually pretty complete. An expression is never going to need to look up a variab

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

clayborg added a comment. Jim Ingham said: > This won't be complete, since we also get collisions between local variables > and namespaces, and that wouldn't be detected by your heuristic. > > I think the trick that Fred used in https://reviews.llvm.org/D46551 is > actually pretty complete. A