[Lldb-commits] [lldb] r353149 - [Expressions] Add support of expressions evaluation in some object's context

Author: aleksandr.urakov Date: Tue Feb 5 01:14:36 2019 New Revision: 353149 URL: http://llvm.org/viewvc/llvm-project?rev=353149&view=rev Log: [Expressions] Add support of expressions evaluation in some object's context Summary: This patch adds support of expression evaluation in a context of som

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

This revision was automatically updated to reflect the committed changes. Closed by commit rL353149: [Expressions] Add support of expressions evaluation in some object's context (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. C

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Thank you! I've updated the comments in the commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. If Greg is happy, then LGTM from me too. Comment at: source/Target/PathMappingList.cpp:223 + + if (prefix_ref == ".") { +prefix_is_relative = true; ---

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the reply! It seems that after your hint I've figured it out. It's the environment variable `VCINSTALLDIR`. I've added it to the `defaultenv` list of the `_get_visual_studio_environment` function and the test passes now. What do you think about this

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. OK, sounds good to me then. Just please make sure the update the test decorators before committing this (I expect you'll need to remove @xfailwindows from TestQuoting and add it to the `dir c:

[Lldb-commits] [PATCH] D57714: [Reproducers] Instrumentation Framework: Serialization

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. Comment at: unittests/Utility/ReproducerInstrumentationTest.cpp:1 +//===-- ReproducerTest.cpp *- C++ -*-===// +// O

[Lldb-commits] [PATCH] D57742: [Expressions] Fix -Wreorder warning from r353149

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353161: [Expressions] Fix -Wreorder warning from r353149 (authored by krasimir, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

labath added a comment. Do we need both this and the `enable-jit-breakpoint` setting? My impression was that the latter was meant to be used for disabling the gdb jit feature. Is the gdb plugin useful for anything if it does not set the breakpoint (i.e. enable = on, but enable-jit-bkpt = off).

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: jasonmolenda, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, abidh. This patch makes `x86AssemblyInspectionEngine` to process zero value of the `B` field of the `REX` prefix in a cor

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. Thank you. I like the new test, but see my comment about avoiding duplicating macros in the test. Besides returning objects, I can think of a couple of more interesting scenarios to cover: - recursive calls (to exercise the g_global_boundary thingy) - having two objects

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added inline comments. Comment at: unittests/Utility/ReproducerInstrumentationTest.cpp:399-404 + EXPECT_EQ(foo.g_a, 100); + EXPECT_EQ(foo.g_b, 200); + EXPECT_TRUE(Equals(foo.g_c, c)); + EXPECT_EQ(foo.g_d, "bar"); + EXPECT_TRUE(Equals(foo.g_e, e)); + EXPECT_EQ(foo.g_f

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

labath added a comment. The change makes sense, but I'd just create a new test with the instructions you're interested in instead of modifying an existing one. The comment above the code claims this assembly was produced by clang, which is clearly not true after your modifications. Repository

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185296. aleksandr.urakov added a comment. Yes, you are right, thank you! I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 Files: source/Plugins/Unw

[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

delcypher created this revision. delcypher added reviewers: sgraenitz, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. If we forget to build `libcxx` then previously the CMake configure would have errors like: CMake Error at /Users/dan/data/dev/llvm/upstream_mo

[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

delcypher added a comment. Wow phabricator has made a right mess of displaying this patch. It's easier to look at as. diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt index fdd84a6e7b7..6b26adb3383 100644 --- a/lldb/CMakeLists.txt +++ b/lldb/CMakeLists.txt @@ -111,7 +111,11 @@ if

[Lldb-commits] [lldb] r353174 - Update Xcode project after r353047

Author: stefan.graenitz Date: Tue Feb 5 06:41:26 2019 New Revision: 353174 URL: http://llvm.org/viewvc/llvm-project?rev=353174&view=rev Log: Update Xcode project after r353047 Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http:

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

labath created this revision. labath added reviewers: clayborg, lemo, amccarth. The reason this wasn't working was that ProcessMinidump was creating odd object-file-less modules, and SymbolFileBreakpad required the module to have an associated object file because it needed to get its base address.

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. I don't expect Jason to have any problems with this, but it might be nice to wait a day or two to give him a chance to prove me wrong. :) Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath added a comment. Greg, what do you think about the new approach in this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56595/new/ https://reviews.llvm.org/D56595 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

clayborg added a comment. I like the way you did the compile units and the line tables and support file list. It would be nice to change this to do things more lazily. Right now we are parsing all compile unit data into CompUnitData structures and then passing their info along to the lldb_priva

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

Yes, clang tries to find the visual studio installation, because that is how it can find headers and libs. Can you make a separate patch with the changes to build.py and upload that? On Tue, Feb 5, 2019 at 2:34 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.ur

[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

sgraenitz added a comment. Not sure if we want to change the behavior this way. The purpose of this code was to make the dependency to libc++ explicit because it's specific to macOS and it's missed quite often. In my experience warnings like the proposed one are hard to recognize in the load of

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath marked 11 inline comments as done. labath added a comment. Thanks for the review Greg. See my responses inline. I'm going to try incorporating the changes tomorrow. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:279 + llvm::Optional func; + for

[Lldb-commits] [PATCH] D57402: build: remove custom variables

sgraenitz added a comment. Herald added a project: LLDB. Hey sorry for the late reply, didn't see this earlier. Personally, I think the move away from the llvm-config approach is good, but I have no strong opinion about the solution. Pro Zachary's proposal: - It's good to have fewer ways to do

[Lldb-commits] [lldb] r353191 - [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.

Author: davide Date: Tue Feb 5 09:30:53 2019 New Revision: 353191 URL: http://llvm.org/viewvc/llvm-project?rev=353191&view=rev Log: [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter. Type punning through a union -> no good. double to uint64 to double again -> no good either.

Re: [Lldb-commits] [lldb] r353191 - [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.

Shafik, Zachary, I think you reported this a bit ago, but now I got around to fix it (also because it was breaking something real). Thanks, -- Davide On Tue, Feb 5, 2019 at 9:30 AM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Tue Feb 5 09:30:53 2019 > New Revision: 353191

Re: [Lldb-commits] [lldb] r353191 - [Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.

To clarify, for those listening at home, it was the second UB (overflow) that exposed a real bug. Type punning was innocuous here, but given it's technically UB, I fixed it anyway. On Tue, Feb 5, 2019 at 9:33 AM Davide Italiano wrote: > > Shafik, Zachary, I think you reported this a bit ago, but

[Lldb-commits] [lldb] r353195 - [Reproducers] Instrumentation Framework: Serialization

Author: jdevlieghere Date: Tue Feb 5 10:46:36 2019 New Revision: 353195 URL: http://llvm.org/viewvc/llvm-project?rev=353195&view=rev Log: [Reproducers] Instrumentation Framework: Serialization This is the is serialization/deserialization part of the reproducer instrumentation framework. For all

[Lldb-commits] [lldb] r353196 - [unittests] Fix warning

Author: jdevlieghere Date: Tue Feb 5 10:46:37 2019 New Revision: 353196 URL: http://llvm.org/viewvc/llvm-project?rev=353196&view=rev Log: [unittests] Fix warning warning: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Wsign-compare] Modified: lldb/trunk/

[Lldb-commits] [PATCH] D57714: [Reproducers] Instrumentation Framework: Serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL353195: [Reproducers] Instrumentation Framework: Serialization (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Agreed with Stefan, I don't think this should be a warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57750/new/ https

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57751/new/ https://reviews.llvm.org/D57751 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

clayborg added a comment. Check the comment about m_platform_file Comment at: include/lldb/Core/Module.h:176-177 + +// Also update the module FileSpec. +module_sp->m_file = module_sp->m_objfile_sp->GetFileSpec(); +return std::move(module_sp); Why do

[Lldb-commits] [PATCH] D57402: build: remove custom variables

xiaobai added a comment. In D57402#1385422 , @sgraenitz wrote: > Pro Saleem's proposal: > > - It's good to have fewer ways to do things. The docs describe how to use > `LLVM_DIR` to build against LLVM. If that's sufficient LLDB should do the > same. http

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

lemo accepted this revision. lemo added a comment. This revision is now accepted and ready to land. The latest version looks good to me. Please update the description (it still says it uses the one CU per symbols file) Comment at: include/lldb/Core/FileSpecList.h:72 + /// Mov

[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

lemo accepted this revision. lemo added a comment. Looks good - a few comments inline. Comment at: include/lldb/Core/Module.h:178 +module_sp->m_file = module_sp->m_objfile_sp->GetFileSpec(); +return std::move(module_sp); } nit: return std::move(x) is

[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

zturner created this revision. zturner added a reviewer: labath. Herald added a reviewer: jfb. This file lives in Target, which makes sense since it is supposed to represent the various types of signals that can occur on any platform (since you might be remote debugging a platform with different

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

clayborg accepted this revision. clayborg added a comment. Thanks for the answers. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D57781: Fix strlen() of unbound array undefined behavior

jankratochvil created this revision. jankratochvil added a project: LLDB. Herald added subscribers: abidh, aprantl. LLDB testsuite fails when built by GCC8 on: LLDB :: SymbolFile/DWARF/find-basic-namespace.cpp This is because this code in LLDB codebase has undefined behavior: #include #i

[Lldb-commits] [PATCH] D57781: Fix strlen() of unbound array undefined behavior

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57781/new/ https://reviews.llvm.org/D57781 ___ lldb-co

[Lldb-commits] [lldb] r353226 - [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.

Author: davide Date: Tue Feb 5 14:24:53 2019 New Revision: 353226 URL: http://llvm.org/viewvc/llvm-project?rev=353226&view=rev Log: [Py3/TestAppleOSSimulator] Another byte<->str interoperability issue. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorO

[Lldb-commits] [lldb] r353239 - Remove accidentally commited file in xcshareddata

Author: jdevlieghere Date: Tue Feb 5 15:35:01 2019 New Revision: 353239 URL: http://llvm.org/viewvc/llvm-project?rev=353239&view=rev Log: Remove accidentally commited file in xcshareddata Removed: lldb/trunk/lldb.xcworkspace/xcshareddata/ ___ lldb

[Lldb-commits] [lldb] r353243 - Fix PathMappingList::FindFile to handle relative incoming FileSpecs.

Author: jingham Date: Tue Feb 5 15:48:10 2019 New Revision: 353243 URL: http://llvm.org/viewvc/llvm-project?rev=353243&view=rev Log: Fix PathMappingList::FindFile to handle relative incoming FileSpecs. An equivalent change was made to RemapPaths, but it needed to be made here as well. Also add

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

This revision was automatically updated to reflect the committed changes. Closed by commit rL353243: Fix PathMappingList::FindFile to handle relative incoming FileSpecs. (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 185431. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h include/lldb/Utility/ReproducerInstrumentation.h source/API/CMakeLists.txt source/API/SBReproducer.cp

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere updated this revision to Diff 185432. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 Files: source/API/SBAddress.cpp source/API/SBAttachInfo.cpp source/API/SBBlock.cpp source/API/SBBreakpoint.cpp source/API/SBBreakpointLoca

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

jasonmolenda accepted this revision. jasonmolenda added a comment. The change looks good to me, thanks for fixing this. I'm not sure you're testing what you meant to test in TestPopRBPWithREX because you're pushing/popping r13. You could get the unwind state at byte offset 2 (after the push r

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 185434. JDevlieghere added a comment. - Use new LLDB_ prefix - Insert two newlines at the end of the macro, so clang-format fixes it up consistently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Fil

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

stella.stamenova added a comment. This is failing on the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1379 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552

Re: [Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

I don't have the ability to debug this and the test output isn't very helpful. There's very little chance what this is testing was working on Windows before this patch, as the relative case was unhandled... So I don't think this patch makes things worse. If somebody who has a windows machine

[Lldb-commits] [lldb] r353251 - Add the source directory for https://reviews.llvm.org/D57552.

Author: jingham Date: Tue Feb 5 16:52:04 2019 New Revision: 353251 URL: http://llvm.org/viewvc/llvm-project?rev=353251&view=rev Log: Add the source directory for https://reviews.llvm.org/D57552. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/source-map/Trivial/ lldb/t

Re: [Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

Oh, wait. I forgot to svn add the directory in which I was hiding the source file. I did that in r353251. Let's see if that works any better! Jim > On Feb 5, 2019, at 4:42 PM, Jim Ingham wrote: > > I don't have the ability to debug this and the test output isn't very > helpful. There's

[Lldb-commits] [lldb] r353257 - Little more cleanup on https://reviews.llvm.org/D57552

Author: jingham Date: Tue Feb 5 17:27:45 2019 New Revision: 353257 URL: http://llvm.org/viewvc/llvm-project?rev=353257&view=rev Log: Little more cleanup on https://reviews.llvm.org/D57552 Thanks Jonas... One more early continue and using a range where we had an iterator. NFC Modified: lldb

[Lldb-commits] [lldb] r353258 - Sort Xcode project

Author: jdevlieghere Date: Tue Feb 5 17:30:45 2019 New Revision: 353258 URL: http://llvm.org/viewvc/llvm-project?rev=353258&view=rev Log: Sort Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/l

[Lldb-commits] [lldb] r353259 - [Reproducers] Add instrumentation to Xcode project

Author: jdevlieghere Date: Tue Feb 5 17:31:00 2019 New Revision: 353259 URL: http://llvm.org/viewvc/llvm-project?rev=353259&view=rev Log: [Reproducers] Add instrumentation to Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro

Re: [Lldb-commits] [lldb] r353257 - Little more cleanup on https://reviews.llvm.org/D57552

Thanks Jim! On Tue, Feb 5, 2019 at 5:27 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Tue Feb 5 17:27:45 2019 > New Revision: 353257 > > URL: http://llvm.org/viewvc/llvm-project?rev=353257&view=rev > Log: > Little more cleanup on https://reviews.l

[Lldb-commits] [lldb] r353268 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Tue Feb 5 19:51:00 2019 New Revision: 353268 URL: http://llvm.org/viewvc/llvm-project?rev=353268&view=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang and

[Lldb-commits] [lldb] r353269 - Add a warning to GDBRemoteRegisterContext (if packet logging enabled)

Author: jmolenda Date: Tue Feb 5 20:08:09 2019 New Revision: 353269 URL: http://llvm.org/viewvc/llvm-project?rev=353269&view=rev Log: Add a warning to GDBRemoteRegisterContext (if packet logging enabled) if the size of the g packet response was smaller than expected and is going to be ignored.

[Lldb-commits] [lldb] r353271 - [Reproducers] lldb-instr: tool to generate instrumentation macros.

Author: jdevlieghere Date: Tue Feb 5 20:33:14 2019 New Revision: 353271 URL: http://llvm.org/viewvc/llvm-project?rev=353271&view=rev Log: [Reproducers] lldb-instr: tool to generate instrumentation macros. This patch introduces a new tool called 'lldb-instr'. It automates the workflow of insertin

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353271: [Reproducers] lldb-instr: tool to generate instrumentation macros. (authored by JDevlieghere, committed by ). Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Changed p