[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

2018-12-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D56126#1342114 , @zturner wrote: > > This info is contained in the Symbols stream, not in the TPI stream. As far > > as I understand, we can't find in a simple way the link between a > > LF_ONEMETHOD record and a corresponding

Re: [Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

2018-12-31 Thread Pavel Labath via lldb-commits
BTW, the flakiness decorators have no effect when using lit as the test runner. They relied on passing a message from the test to the test framework, which caused the latter to re-run the test. Of course, lit has no idea what to do with these messages. On 30/12/2018 17:24, Davide Italiano via

[Lldb-commits] [PATCH] D56170: RangeMap.h: merge RangeDataArray and RangeDataVector

2018-12-31 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, teemperor, tberghammer. Herald added subscribers: JDevlieghere, mgorny. The main difference between the classes was supposed to be the fact that one is backed by llvm::SmallVector, and the other by std::vector. However, over the years

[Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

2018-12-31 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner, lemo, markmentovai, amccarth. Herald added a subscriber: mgorny. This commit adds the glue code necessary to integrate the SymbolFileBreakpad into the plugin system. Most of the methods are stubbed out. The only method implem

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

2018-12-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I've uploaded D56173 to demonstrate how I intend to use the sections created here. The latter patch still requires some changes I only have locally (needed to make base address available to it), but the part about handling the sections

[Lldb-commits] [PATCH] D56174: ProcessLaunchInfo: remove Debugger reference

2018-12-31 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: zturner, jingham, teemperor. The Debuffer object was being used in "GetListenerForProcess" to provide a default listener object if one was not specified in the launch_info object. Since all the callers of this function immediately passed the r

[Lldb-commits] [lldb] r350177 - [DWARFUnit] Remove commented out code. NFCI.

2018-12-31 Thread Davide Italiano via lldb-commits
Author: davide Date: Mon Dec 31 10:45:30 2018 New Revision: 350177 URL: http://llvm.org/viewvc/llvm-project?rev=350177&view=rev Log: [DWARFUnit] Remove commented out code. NFCI. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/