[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 178353. jankratochvil added a comment. Updated against trunk due to new `getSectionType` from rL348936 . Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51578/new/ https://reviews.llv

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

labath added a comment. +1 for tests. Other than that, the code seems fairly straight-forward, though it could be brought closer to llvm style (e.g., by using more StringRefs in favour of raw c strings). Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:709-714 +

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

labath created this revision. labath added reviewers: stella.stamenova, zturner. This should enable the compiler to find the system linker for the link step. https://reviews.llvm.org/D55736 Files: lit/helper/build.py Index: lit/helper/build.py ===

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

labath added a comment. Stella, could you please try whether this solves the problem you reported in D55430 ? I think this should do the trick, but I can't be sure because (for whatever reason), things seem to work for me even without this patch. CHANGES SINCE

[Lldb-commits] [lldb] r349267 - Remove /proc/pid/maps parsing code from NativeProcessLinux

Author: labath Date: Sat Dec 15 05:38:16 2018 New Revision: 349267 URL: http://llvm.org/viewvc/llvm-project?rev=349267&view=rev Log: Remove /proc/pid/maps parsing code from NativeProcessLinux A utility function doing this was added in r349182, so use that instead. Modified: lldb/trunk/source

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

labath added a comment. Kamil, Joerg: most of this is fairly lldb-specific and boring. I just added you for the .symtab thingy, just in case you know of anyone using SHT_SYMTAB sections which are not called .symtab (or conversely, using the name .symtab for non-symbol-table-related things). C

[Lldb-commits] [lldb] r349268 - ELF: more section creation cleanup

Author: labath Date: Sat Dec 15 05:45:38 2018 New Revision: 349268 URL: http://llvm.org/viewvc/llvm-project?rev=349268&view=rev Log: ELF: more section creation cleanup Summary: This patch attempts to move as much code as possible out of the CreateSections function to make room for future improvem

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349268: ELF: more section creation cleanup (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D55706?vs=178231&id=178360#toc Rep

[Lldb-commits] [PATCH] D55597: lldb-test: Improve newline handling

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349269: lldb-test: Improve newline handling (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D55597?vs=177841&id=178362#toc Re

[Lldb-commits] [lldb] r349269 - lldb-test: Improve newline handling

Author: labath Date: Sat Dec 15 05:49:25 2018 New Revision: 349269 URL: http://llvm.org/viewvc/llvm-project?rev=349269&view=rev Log: lldb-test: Improve newline handling Summary: Previously lldb-test's LinePrinter would output the indentation spaces even on completely empty lines. This is not nice

[Lldb-commits] [lldb] r349282 - Update the vFile:open: description to note that the flags

Author: jmolenda Date: Sat Dec 15 10:40:38 2018 New Revision: 349282 URL: http://llvm.org/viewvc/llvm-project?rev=349282&view=rev Log: Update the vFile:open: description to note that the flags in the packet are lldb enum values, not the open(2) oflags -- forgot about that wrinkle. Also added a c

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 178375. aprantl added a comment. Fixed the reported problems with the regexes and added testcases with example lines. I used the funny test setup to avoid burdening the installed crashlog.py script with unit test code that would need to be parsed every time.