[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added a comment. Sorry for editing this again, but D55328 brought up an important change request (see https://reviews.llvm.org/D55328#anchor-1322655) and I only realized this side-effect afterwards: adding LLDB to a LLVM build tree (all with default

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 177486. sgraenitz added a comment. Avoid force-overwriting of LLVM_CODESIGNING_IDENTITY CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz marked 9 inline comments as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:141 if(TARGET debugserver) -if(NOT CMAKE_HOST_APPLE OR LLDB_CODESIGN_IDENTITY) - list(APPEND LLDB_TEST_DEPS debugserver) -endif() +list(APPEND LLDB_TEST_DEP

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz updated this revision to Diff 177512. sgraenitz added a comment. Rename function to setup rpaths and extend comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

labath accepted this revision. labath added a comment. This looks much better. Thanks. Comment at: tools/debugserver/source/CMakeLists.txt:104 +if(LLDB_CODESIGN_IDENTITY) + set(LLDB_CODESIGN_IDENTITY_USED ${LLDB_CODESIGN_IDENTITY} CACHE STRING "" FORCE) +elseif(LLVM_CODESIGNI

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz updated this revision to Diff 177516. sgraenitz added a comment. Account for changes in parent revision to keep individual commits compiling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55332/new/ https://reviews.llvm.org/D55332 Files: CMakeLists.txt scripts/CMakeLists.

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz updated this revision to Diff 177533. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Address feedback and minor improvements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55332/new/ https://reviews.llvm.org/D55332 Files: CMakeLists.txt scripts/CMak

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:134 --srcRoot=${LLDB_SOURCE_DIR} - --targetDir=${LLDB_PYTHON_TARGET_DIR} - --cfgBldDir=${LLDB_PYTHON_TARGET_DIR} + --t

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

labath added a comment. Woohoo for speedups. However, I noticed that you are modifying the signatures of SB functions, which I don't believe will be acceptable for lldb. Comment at: include/lldb/API/SBMemoryRegionInfo.h:105 - SBMemoryRegionInfo(const lldb_private::MemoryRe

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

labath added a comment. In D55384#1323464 , @zturner wrote: > I considered this, and we actually have a test that does (see > `s_constant.s`). The reason I didn't do it here because my experience > writing `s_constant.s` taught me just how difficult it

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. In D55330#1323525 , @xiaobai wrote: > Looks good to me overall. You also probably probably also invoke > `lldb_setup_rpaths_framework` for the tools included in the framework > (argdu

[Lldb-commits] [lldb] r348773 - Re-commit "Introduce ObjectFileBreakpad"

Author: labath Date: Mon Dec 10 09:16:38 2018 New Revision: 348773 URL: http://llvm.org/viewvc/llvm-project?rev=348773&view=rev Log: Re-commit "Introduce ObjectFileBreakpad" This re-commits r348592, which was reverted due to a failing test on macos. The issue was that I was passing a null pointe

[Lldb-commits] [lldb] r348775 - Do not use PATH_MAX with SmallString

Author: stella.stamenova Date: Mon Dec 10 09:23:28 2018 New Revision: 348775 URL: http://llvm.org/viewvc/llvm-project?rev=348775&view=rev Log: Do not use PATH_MAX with SmallString Summary: Instead use a more reasonable value to start and rely on the fact that SmallString will resize if necessary

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348775: Do not use PATH_MAX with SmallString (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55457/new/ https://reviews.l

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I am going to stop making comments as I have been working on a similar patch that does more than this one. I will post it today and we can decide which approach we want to use.

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

zturner added inline comments. Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31 - bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo ®ion_info); + void Reserve(size_t capacity); clayborg wrote: > This you can add, but std::vector implement

[Lldb-commits] [PATCH] D55522: Cache memory regions and use the linux maps as the source of the information if available.

clayborg created this revision. clayborg added reviewers: labath, markmentovai, zturner, tatyana-krasnukha. Herald added a subscriber: mgrang. Breakpad creates minidump files that sometimes have: - linux maps textual content - no MemoryInfoList Right now unless the file has a MemoryInfoList we g

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

clayborg added a comment. See my patch: https://reviews.llvm.org/D55522 Let me know what you think Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55472/new/ https://reviews.llvm.org/D55472 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. In D55434#1323912 , @clayborg wrote: > If you plan on not making the breakpad file ever stand alone, then you will > need to take any addresses and look them up in the module section list and > use the other sections. I don't see

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177554. sgraenitz marked an inline comment as done and an inline comment as not done. sgraenitz added a comment. Move code sign changes to D55328 , minor improvements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg updated this revision to Diff 177555. clayborg added a comment. Add sorting functions needed for MemoryRegionInfo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522 Files: include/lldb/Target/MemoryRegionInfo.h source/Plugins/Process/m

[Lldb-commits] [lldb] r348780 - Fix r348773

Author: labath Date: Mon Dec 10 10:17:53 2018 New Revision: 348780 URL: http://llvm.org/viewvc/llvm-project?rev=348780&view=rev Log: Fix r348773 It's not sufficient to implement the CreateMemoryInstance function, one has to use it too. Modified: lldb/trunk/source/Plugins/ObjectFile/Breakpad/

[Lldb-commits] [lldb] r348779 - [Host] Use FileSystem wrapper

Author: jdevlieghere Date: Mon Dec 10 10:17:39 2018 New Revision: 348779 URL: http://llvm.org/viewvc/llvm-project?rev=348779&view=rev Log: [Host] Use FileSystem wrapper Fixes Host.mm to use the FileSystem class instead of making native calls to check if a file exists. Modified: lldb/trunk/so

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added inline comments. Comment at: resources/LLDB-Info.plist.in:18 + CFBundleSignature + + CFBundleVersion Just out of curiosity: Why this? Is this expected to be replaced after code signing? CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + labath wrote: > sgraenitz wrote: > > sgraenitz wrote: > > >

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. In D55434#1325739 , @labath wrote: > In D55434#1323912 , @clayborg wrote: > > > If you plan on not making the breakpad file ever stand alone, then you will > > need to take any addresses a

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: resources/LLDB-Info.plist.in:18 + CFBundleSignature + + CFBundleVersion aprantl wrote: > Just out of curiosity: Why this? Is this expected to be replac

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

clayborg added a comment. BTW: check my changes in: https://reviews.llvm.org/D55522 It will be interesting to you since it parses the linux maps info if it is available in breakpad generated minidump files. This will give us enough info to create correct sections for object files when we have no

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:409 +return false; + llvm::StringRef text((const char *)data.data(), data.size()); + llvm::StringRef line; You can write this as `auto text = llvm::toStringRef(dat

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

clayborg added inline comments. Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31 - bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo ®ion_info); + void Reserve(size_t capacity); zturner wrote: > clayborg wrote: > > This you can add, but s

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

labath added a comment. This patch certainly provides a more comprehensive treatment of memory region information in minidump. However, there might be some value in removing the excessive shared_ptrs in the other patch. I think that should be evaluated separately. I was going to write some add

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. In D55434#1325782 , @clayborg wrote: > Ok. Check out my changes that parse region info: > https://reviews.llvm.org/D55522 > > It parses the memory region info from the linux maps info if it is available. > In breakpad generated mi

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg updated this revision to Diff 177567. clayborg added a comment. Removed Xcode scheme changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522 Files: include/lldb/Target/MemoryRegionInfo.h source/Plugins/Process/minidump/MinidumpPars

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg updated this revision to Diff 177566. clayborg marked 2 inline comments as done. clayborg added a comment. Fixed Zach's issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522 Files: include/lldb/Target/MemoryRegionInfo.h lldb.xcode

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg marked 6 inline comments as done. clayborg added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:412 + constexpr const auto yes = MemoryRegionInfo::eYes; + constexpr const auto no = MemoryRegionInfo::eNo; + while (!text.empty()) { -

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg added a comment. In D55522#1325839 , @labath wrote: > This patch certainly provides a more comprehensive treatment of memory region > information in minidump. However, there might be some value in removing the > excessive shared_ptrs in the othe

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

tatyana-krasnukha added a comment. Without overriding Process::GetMemoryRegions still does a lot of unnecessary job (FindMemoryRegion for each element in the vector). With these changes, it may just return m_regions (if not empty), doesn't it? Comment at: source/Plugins/Proces

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> BTW: check my changes in: https://reviews.llvm.org/D55522 > It will be interesting to you since it parses the linux maps info if it is available in breakpad generated minidump files. This will give us enough info to create correct sections for object files when we have no ELF file or no symbol fi

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

labath added a comment. This looks fine to me. The test is a bit more coarse-grained than I'd like, though I can't think of a substantially better approach right now. One of the pdb folks should ok this too. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:386

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz updated this revision to Diff 177570. sgraenitz added a comment. Also remove code sign configuration as it moved back into debugserver in D55013 . With this, debugserverConfig became really small (for the moment), but I still think it's good to have it

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

sgraenitz updated this revision to Diff 177572. sgraenitz added a comment. Remove old option LLDB_USE_ENTITLEMENTS here and not in D55328 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55317/new/ https://reviews.llvm.org/D55317 Files: CMakeLists.txt

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo updated this revision to Diff 177576. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 Files: lit/Minidump/Windows/Sigsegv/Inputs/sigsegv.cpp lit/Minidump/Windows/Sigsegv/Inputs/sigsegv.dmp lit/Minidump/Windows/Sigsegv/Inputs/sigsegv.lld

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 177577. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Turn LLDB_CODESIGN_IDENTITY_USED variable from STRING into INTERNAL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: C

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added a comment. How large is the PDB file here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

tatyana-krasnukha added a comment. Don't you mind to take overridden GetMemoryRegions in this patch so that I can remove all minidump-related changes from D55472 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> How large is the PDB file here? 100Kb On Mon, Dec 10, 2018 at 11:48 AM Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a comment. > > How large is the PDB file here? > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D55142/new/ > > https://reviews.ll

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha added a comment. Thanks to all for comments! As I wrote in inline comments, 'non-const' -> 'const' changes don't seem to break anything, I'd like to leave it here. Correct me, if I'm wrong. The second question is whether it is allowed to change private member functions of SBX

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg added a comment. In D55522#1326035 , @tatyana-krasnukha wrote: > Don't you mind to take overridden GetMemoryRegions in this patch so that I > can remove all minidump-related changes from D55472 > ? That is fin

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg updated this revision to Diff 177592. clayborg added a comment. Add reserve and shrink to fit when parsing memory regions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522 Files: include/lldb/Target/MemoryRegionInfo.h source/Plugins/

[Lldb-commits] [lldb] r348805 - Reflow a multi-line string and add a newline

Author: friss Date: Mon Dec 10 14:30:19 2018 New Revision: 348805 URL: http://llvm.org/viewvc/llvm-project?rev=348805&view=rev Log: Reflow a multi-line string and add a newline Modified: lldb/trunk/source/Target/StopInfo.cpp Modified: lldb/trunk/source/Target/StopInfo.cpp URL: http://llvm.o

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> On Dec 10, 2018, at 11:23 AM, Leonard Mosescu wrote: > > > BTW: check my changes in: https://reviews.llvm.org/D55522 > > > > It will be interesting to you since it parses the linux maps info if it is > > available in breakpad generated minidump files. This

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

JDevlieghere updated this revision to Diff 177598. JDevlieghere added a comment. - Rebase - Copy over permissions - Fix path when launching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 Files: include/lldb/Host/FileSystem.h include/lldb/U

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

clayborg added a comment. FYI: my approach to getting symbols to load was a bit different. I always let a simple PlaceholderModule be created, but I played some tricks in the GetObjectFile() method if someone had setting symbols for the module with "target symbols add ..". I will attach my Plac

[Lldb-commits] [lldb] r348808 - Rewrite pexpect-based test in LIT/FileCheck.

Author: adrian Date: Mon Dec 10 14:57:47 2018 New Revision: 348808 URL: http://llvm.org/viewvc/llvm-project?rev=348808&view=rev Log: Rewrite pexpect-based test in LIT/FileCheck. pexecpt-based tests are flakey because they involve timeouts and this test is eprfectly serializable. Added: lldb/

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

I can see how this works for the PDB, no-module-binary case. What about the PDB & module-binary case? Maybe I missed the rationale, but I think that modeling the general case: module and symbols are separate files, is a better foundation for the particular case where the symbols are embedded in th

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo added a comment. > How large is the PDB file here? ~100kb CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] r348810 - [DataFormatters] Fixes to libc++ std::function formatter to deal with ABI change see

Author: shafik Date: Mon Dec 10 15:26:38 2018 New Revision: 348810 URL: http://llvm.org/viewvc/llvm-project?rev=348810&view=rev Log: [DataFormatters] Fixes to libc++ std::function formatter to deal with ABI change see https://reviews.llvm.org/D55045 Modified: lldb/trunk/source/Target/CP

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> On Dec 10, 2018, at 3:11 PM, Leonard Mosescu wrote: > > I can see how this works for the PDB, no-module-binary case. What about the > PDB & module-binary case? That would work fine because the symbol vendor will make an object file from the m_symfile_spec and use both the original binary +

[Lldb-commits] [lldb] r348813 - Fix undefined behavior in Variable.h

Author: zturner Date: Mon Dec 10 16:15:03 2018 New Revision: 348813 URL: http://llvm.org/viewvc/llvm-project?rev=348813&view=rev Log: Fix undefined behavior in Variable.h m_loc_is_constant_data was uninitialized, so unless someone explicitly called SetLocIsConstantData(), this would be UB. I thi