JDevlieghere created this revision.
JDevlieghere added a reviewer: zturner.
JDevlieghere added a project: LLDB.
Herald added subscribers: jfb, mgorny.
Alternative to https://reviews.llvm.org/D54682.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54692
Files:
tools/driver/CMakeLists.txt
JDevlieghere added a comment.
In https://reviews.llvm.org/D54682#1302448, @zturner wrote:
> Lib option definitely does, as its entire purpose is to be powerful and
> flexible enough to mimic arbitrary command line tools.
I created https://reviews.llvm.org/D54692 to show what the driver would l
Author: d0k
Date: Mon Nov 19 02:59:12 2018
New Revision: 347188
URL: http://llvm.org/viewvc/llvm-project?rev=347188&view=rev
Log:
Remove unused variable. NFC.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
URL:
http://
labath added a comment.
If by //"it would cause errors to no longer appear in the same order as
specified by the user, but in an arbitrary order specified by the driver
implementation"//, you mean that now for a command line like:
$ new/lldb -S /tmp/sadg --file /tmp/qwr
I get
error: file
labath added inline comments.
Comment at: include/lldb/Utility/Reproducer.h:59-64
+ void InitializeFileInfo(llvm::StringRef name,
+ llvm::ArrayRef files) {
+m_info.name = name;
+for (auto file : files)
+ m_info.files.push_back(file);
+ }
--
labath added a comment.
In https://reviews.llvm.org/D54617#1302376, @JDevlieghere wrote:
> In https://reviews.llvm.org/D54617#1302366, @labath wrote:
>
> > I am confused by differing scopes of various objects that are interacting
> > here. It seems you are implementing capture/replay as somethin
On 17/11/2018 02:27, Adrian Prantl via lldb-commits wrote:
Author: adrian
Date: Fri Nov 16 17:27:47 2018
New Revision: 347125
URL: http://llvm.org/viewvc/llvm-project?rev=347125&view=rev
Log:
Just don't even attempt to invoke sed on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347213: Don't use -O in lit tests. (authored by
zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54680?vs=174549&id=174609#toc
Reposi
Author: zturner
Date: Mon Nov 19 07:06:10 2018
New Revision: 347213
URL: http://llvm.org/viewvc/llvm-project?rev=347213&view=rev
Log:
Don't use -O in lit tests.
Because of different shell quoting rules, and the fact that LLDB
commands often contain spaces, -O is not portable for writing command
l
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347216: Fix some issues with LLDB's lit configuration
files. (authored by zturner, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D54567?vs=174
Author: zturner
Date: Mon Nov 19 07:12:34 2018
New Revision: 347216
URL: http://llvm.org/viewvc/llvm-project?rev=347216&view=rev
Log:
Fix some issues with LLDB's lit configuration files.
Recently I tried to port LLDB's lit configuration files over to use a
on the surface, but broke some cases tha
Author: zturner
Date: Mon Nov 19 08:41:31 2018
New Revision: 347223
URL: http://llvm.org/viewvc/llvm-project?rev=347223&view=rev
Log:
Remove non-ASCII characters at the beginning of file.
It's not clear how these ended up in the file, but this fixes it.
Modified:
lldb/trunk/lit/helper/toolch
Author: zturner
Date: Mon Nov 19 08:47:06 2018
New Revision: 347224
URL: http://llvm.org/viewvc/llvm-project?rev=347224&view=rev
Log:
[lit] On Windows, don't error if MSVC is not in PATH.
We had some logic backwards, and as a result if MSVC was not found
in PATH we would throw a string concatenat
stella.stamenova created this revision.
stella.stamenova added reviewers: aprantl, zturner.
Herald added subscribers: lldb-commits, teemperor.
In order to invoke sed on Windows, we need to quote the command correctly.
Since we already have commands which do that, move the definitions at the
begi
Author: stella.stamenova
Date: Mon Nov 19 10:41:33 2018
New Revision: 347243
URL: http://llvm.org/viewvc/llvm-project?rev=347243&view=rev
Log:
[lldbsuite] Invoke sed on Windows to determine the cache dir for clang
Summary: In order to invoke sed on Windows, we need to quote the command
correctly
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347243: [lldbsuite] Invoke sed on Windows to determine the
cache dir for clang (authored by stella.stamenova, committed by
Author: rnk
Date: Mon Nov 19 11:36:28 2018
New Revision: 347254
URL: http://llvm.org/viewvc/llvm-project?rev=347254&view=rev
Log:
Fix clang test suite on Windows by reverting part of r347216
Otherwise, the clang analyzer tests fail on Windows when attempting to
unpickle AnalyzerTest objects in th
zturner created this revision.
zturner added reviewers: labath, stella.stamenova, davide, rnk, aprantl, friss.
Herald added a subscriber: delcypher.
Currently lit supports running shell commands through the use of the `RUN: `
prefix. This patch allows individual test suites to install their own
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
LGTM as long as the tests are all still passing :)
https://reviews.llvm.org/D54731
___
lldb-commits mailing list
lldb-commits
zturner added a comment.
Can you post a short snippet of old help and new help output?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: jdevlieghere
Date: Mon Nov 19 17:18:49 2018
New Revision: 347283
URL: http://llvm.org/viewvc/llvm-project?rev=347283&view=rev
Log:
Skip TestTargetCreateDeps
Skip this test because Windows deals differently with shared libraries.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/fu
21 matches
Mail list logo
