aleksandr.urakov added a comment.
LGTM too, thanks!
https://reviews.llvm.org/D54452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sgraenitz added inline comments.
Comment at: cmake/modules/AddLLVM.cmake:795
- llvm_codesign(${name})
+ llvm_codesign(TARGET ${name} ENTITLEMENTS ${ARG_ENTITLEMENTS} FORCE)
endmacro(add_llvm_executable name)
beanz wrote:
> sgraenitz wrote:
> > Would we want
sgraenitz added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:50
+ if(LLDB_USE_ENTITLEMENTS AND NOT IOS)
+# Same entitlements file as used for lldb-server
+set(entitlements
${LLDB_SOURCE_DIR}/resources/debugserver-macosx-entitlements.plist)
-
sgraenitz updated this revision to Diff 173849.
sgraenitz added a comment.
unset not necessary, fix comment, globally set LLVM_CODESIGNING_IDENTITY from
LLDB_CODESIGN_IDENTITY
https://reviews.llvm.org/D5
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
tools/lldb-server/CMakeLists.t
sgraenitz updated this revision to Diff 173851.
sgraenitz added a comment.
Remove FORCE parameter from llvm_codesign and instead add global option
LLVM_CODESIGNING_FORCE
Repository:
rL LLVM
https://reviews.llvm.org/D54443
Files:
CMakeLists.txt
cmake/modules/AddLLVM.cmake
Index: cmake/
sgraenitz added inline comments.
Comment at: CMakeLists.txt:403
+set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING
+ "Sign executables and dylibs with the given identity or skip if empty
(Darwin Only)")
+
Identity should be a string right?
Commen
sgraenitz created this revision.
sgraenitz added reviewers: xiaobai, beanz, vsk, JDevlieghere.
Herald added a subscriber: mgorny.
Use llvm_codesign to sign debugserver with entitlements. Make individual cases
more explicit:
- default: build debugserver and sign with entitlements
- LLDB_NO_DEBUGS
sgraenitz abandoned this revision.
sgraenitz added a comment.
Finally, debugserver with llvm_codesign: https://reviews.llvm.org/D54476
https://reviews.llvm.org/D54352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
shafik added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329
+std::pair GetIntegralTypeInfo(TypeIndex ti, TpiStream &tpi) {
+ if (ti.isSimple()) {
lemo wrote:
> Just a suggestion: I'm not a big fan of returning
JDevlieghere added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:101
+option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't
try to codesign it" OFF)
+option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver.
Use the
Author: jingham
Date: Tue Nov 13 10:18:32 2018
New Revision: 346775
URL: http://llvm.org/viewvc/llvm-project?rev=346775&view=rev
Log:
Since ABI's now hold a process WP, they should be handed
out one per process rather than keeping a single global instance.
Differential Revision: https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346775: Since ABI's now hold a process WP, they should
be handed (authored by jingham, committed by ).
Herald added subscribers: llvm-commits, jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346775: Since ABI's now hold a process WP, they
should be handed (authored by jingham, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54460
Files:
source/Plugins/ABI/MacOSX-arm/
xiaobai added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:128-133
+# TODO: Following the old behavior, DEBUGSERVER_PATH still points to the
+# original system binary, even if we copy it over. Keep this?
+set(DEBUGSERVER_PATH
"${lldb_framework
Author: jdevlieghere
Date: Tue Nov 13 11:18:16 2018
New Revision: 346780
URL: http://llvm.org/viewvc/llvm-project?rev=346780&view=rev
Log:
Add GDB remote packet reproducer.
Added:
lldb/trunk/include/lldb/Utility/Reproducer.h
lldb/trunk/packages/Python/lldbsuite/test/functionalities/reprod
jingham added a comment.
Okay, I think I'll keep what Jason did and just make them per-process. As Greg
said, they are very cheap to make, since they just take a Process SP and get
the weak pointer from it. None of them have any other state.
Repository:
rLLDB LLDB
https://reviews.llvm.org
Author: davide
Date: Tue Nov 13 11:43:43 2018
New Revision: 346783
URL: http://llvm.org/viewvc/llvm-project?rev=346783&view=rev
Log:
[Cocoa] Implement formatter for the new NSDate representation.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/trunk/source/Plugin
jingham added a comment.
As for testing, Jason was careful to use a WP, so nothing crashes. The
process's SP doesn't resolve and then you get the default setting of any
process specific setting that uses the ABI. Since there aren't any of those
yet - this currently has no observable consequen
sgraenitz added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:101
+option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't
try to codesign it" OFF)
+option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver.
Use the sy
Author: zturner
Date: Tue Nov 13 12:07:57 2018
New Revision: 346787
URL: http://llvm.org/viewvc/llvm-project?rev=346787&view=rev
Log:
[NativePDB] Add support for S_CONSTANT records.
clang-cl does not emit these, but MSVC does, so we need to be able to
handle them.
Because clang-cl does not gener
Author: zturner
Date: Tue Nov 13 12:07:32 2018
New Revision: 346786
URL: http://llvm.org/viewvc/llvm-project?rev=346786&view=rev
Log:
[NativePDB] Improved support for nested type reconstruction.
In a previous patch, we pre-processed the TPI stream in order to build
the reverse mapping from nested
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346786: [NativePDB] Improved support for nested type
reconstruction. (authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D543
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346787: [NativePDB] Add support for S_CONSTANT records.
(authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54452?vs=173775&
JDevlieghere added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:118
+ OUTPUT_VARIABLE xcode_dev_dir)
+string(STRIP ${xcode_dev_dir} xcode_dev_dir)
+
sgraenitz wrote:
> JDevlieghere wrote:
> > Why did you make this variable name lo
JDevlieghere added a comment.
I think we can close this after https://reviews.llvm.org/rL344945?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
beanz added inline comments.
Comment at: CMakeLists.txt:403
+set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING
+ "Sign executables and dylibs with the given identity or skip if empty
(Darwin Only)")
+
sgraenitz wrote:
> Identity should be a string right?
Yep, makes
I think it must be related to setting up the environment in which to run
clang. In all other projects we call llvm_config.use_clang() which is in
llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path
of a clang we are trying to use, we skip this function in LLDB's lit
configura
zturner added a comment.
I think it must be related to setting up the environment in which to run
clang. In all other projects we call llvm_config.use_clang() which is in
llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path
of a clang we are trying to use, we skip this functi
clayborg added a comment.
yep
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: adrian
Date: Tue Nov 13 15:14:37 2018
New Revision: 346812
URL: http://llvm.org/viewvc/llvm-project?rev=346812&view=rev
Log:
Fix a bug in the parsing of the LC_BUILD_VERSION Mach-O load command.
LC_BUILD_VERSION records are of variable length. The original code
would use uninitialized mem
I took a brief look and I have a question about the usage of clang (rather than
clang-cl).
In general I would agree that we have an exact path of clang (or gcc) that we
are trying to use and they’re specified by using %cc and %cxx in the test
files, but there are a number of test files that sim
Thanks!
On Tue, Nov 13, 2018 at 3:17 PM Adrian Prantl via lldb-commits
wrote:
>
> Author: adrian
> Date: Tue Nov 13 15:14:37 2018
> New Revision: 346812
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346812&view=rev
> Log:
> Fix a bug in the parsing of the LC_BUILD_VERSION Mach-O load command.
>
I believe that is correct, and perhaps part of the problem. In other
projects we call llvm_config.use_clang(), and that actually explicitly
creates a substitution so that if someone writes "clang" they'll get an
error that says "use %clang instead". Because we have the exact path, that
isn't happ
I am not sure if that’s the right solution for a couple of reasons:
1. As far as I can tell only clang calls use_clang (and only lld calls
use_lld), while the other projects such as lld and llvm rely on the environment
to be setup correctly
2. Lld also has tests that invoke clang-cl and th
Actually, I take 2) back. Lld doesn’t call use_clang, but it only references
clang-cl, it doesn’t expect it to execute.
From: Stella Stamenova
Sent: Tuesday, November 13, 2018 3:47 PM
To: 'Zachary Turner'
Cc: reviews+d54009+public+0e164460da8f1...@reviews.llvm.org; pa...@labath.sk;
chris.biene.
On Tue, Nov 13, 2018 at 3:47 PM Stella Stamenova
wrote:
> I am not sure if that’s the right solution for a couple of reasons:
>
>1. As far as I can tell only clang calls use_clang (and only lld calls
>use_lld), while the other projects such as lld and llvm rely on the
>environment to
Ok so for dotest, it seems to be ignoring the config.cc and config.cxx
entirely. So we can theoretically do whatever we want with it, or change
around the directory structure so that it's more like:
lldb
* lit
* * Dotest
* * Unit
* * Tests
and put the config.cc / config.cxx logic under Tests. T
The plan for the lit tests sounds reasonable to me. I would also remove
LLDB_TEST_C/CXX_COMPILER entirely so that we can reduce confusion since they’re
only used for the lit tests, right?
My only concern is that I’ve been told that there are people who will build
lldb with a different compiler
use_clang() already will fall back on searching the environment variable
'CLANG' to find a path to it.
self.config.clang = self.use_llvm_tool(
'clang', search_env='CLANG', required=required)
But we could make this environment variable a parameter to use_clang() if
we wanted to
39 matches
Mail list logo
