[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.

labath added a comment. In https://reviews.llvm.org/D54221#1290638, @JDevlieghere wrote: > In https://reviews.llvm.org/D54221#1290572, @labath wrote: > > > I recall something about linux on arm having a magic unmodifiable (even by > > ptrace) page of memory, so this could be useful there too. Ho

[Lldb-commits] [PATCH] D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, sorry for that! https://reviews.llvm.org/D54335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D54272: Extract construction of DataBufferLLVM into FileSystem

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me, I'd just ask you to consider shortening the method names a bit. Comment at: include/lldb/Host/FileSystem.h:119-122 + CreateDataBufferFromPath(const llvm::

Re: [Lldb-commits] [lldb] r346466 - Revert "[FileSystem] Make use of FS in TildeExpressionResolver"

I think the right way to resolve this would be to move "StandardTildeExpressionResolver" into the host module. The non-standard TildeExpressionResolver is just an abstract class, so it does not need the filesystem. This way, anyone wanting to use the resolver can just depend on the interface, and t

[Lldb-commits] [lldb] r346598 - Extract construction of DataBufferLLVM into FileSystem

Author: jdevlieghere Date: Sat Nov 10 14:44:06 2018 New Revision: 346598 URL: http://llvm.org/viewvc/llvm-project?rev=346598&view=rev Log: Extract construction of DataBufferLLVM into FileSystem This moves construction of data buffers into the FileSystem class. Like some of the previous refactorin

[Lldb-commits] [PATCH] D54272: Extract construction of DataBufferLLVM into FileSystem

This revision was automatically updated to reflect the committed changes. Closed by commit rL346598: Extract construction of DataBufferLLVM into FileSystem (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5427

[Lldb-commits] [lldb] r346599 - Add missing include

Author: jdevlieghere Date: Sat Nov 10 14:54:44 2018 New Revision: 346599 URL: http://llvm.org/viewvc/llvm-project?rev=346599&view=rev Log: Add missing include Modified: lldb/trunk/source/Host/linux/Host.cpp Modified: lldb/trunk/source/Host/linux/Host.cpp URL: http://llvm.org/viewvc/llvm-pro

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 173533. jankratochvil edited the summary of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. There is a `_dwarf` -> `_dwarf_type_units` regression for: `-f TestCppTypeLookup.test_namespace_only_dwarf_type_units` ./bin/clang -o 1 ../llvm-git/tools/lldb/packages/Python/lldbsuite/test/lang/cpp/type_lookup/mai

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 173535. jankratochvil marked 2 inline comments as done. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules pa

[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

vsk accepted this revision as: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rLLDB LLDB https://reviews.llvm.org/D54385 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.