labath added a comment.
Why did you change the function name? I think it would be nice to keep
"executable" or something to that effect in the name (e.g. the llvm function
has "program"), given that the underlying function checks for the executable
bit, and so it cannot be used for general sear
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for bearing with me. I am very happy with how this turned out in the
end. I have more suggestion on how to clean up the initialization, which you
can incorporate if you like it, but I d
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1281742, @zturner wrote:
> What do you think?
Yes, it's a really cool idea! When I was starting the implementation of the
parser from this patch, I thought that it would be good to have mangled names
instead - then we could
Author: grimar
Date: Wed Oct 31 03:14:03 2018
New Revision: 345706
URL: http://llvm.org/viewvc/llvm-project?rev=345706&view=rev
Log:
[LLDB] - Add support for DW_FORM_addrx[1-4]? forms.
This adds the support for DW_FORM_addrx, DW_FORM_addrx1,
DW_FORM_addrx2, DW_FORM_addrx3, DW_FORM_addrx4 forms.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345706: [LLDB] - Add support for DW_FORM_addrx[1-4]? forms.
(authored by grimar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53813?vs=1715
Author: smeenai
Date: Wed Oct 31 03:41:12 2018
New Revision: 345711
URL: http://llvm.org/viewvc/llvm-project?rev=345711&view=rev
Log:
[lldb] Fix race condition in framework installation
We need the install-liblldb-stripped target to depend on the
lldb-framework target in order for the installatio
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345711: [lldb] Fix race condition in framework
installation (authored by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53917?vs=171854&id=171884#toc
Repository:
rLLDB
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added a subscriber: JDevlieghere.
This adds support for DW_RLE_base_addressx, DW_RLE_startx_endx,
DW_RLE_startx_length, DW_FORM_rnglistx.
https://reviews.llvm.org/D53929
Files:
lit/Breakpoint/Inputs/debug_rnglistx_rl
xbolva00 added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:163
+ uint64_t length = data.GetU32(&offset);
+ bool isDwarf64 = false;
+ if (length == 0x) {
variable is not used anywhere
Repository:
rL L
Author: grimar
Date: Wed Oct 31 06:49:31 2018
New Revision: 345720
URL: http://llvm.org/viewvc/llvm-project?rev=345720&view=rev
Log:
[LLDB] - Removed unused variable. NFC.
Introduced in r344119.
Thanks to Dávid Bolvanský fo reporting.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWA
grimar added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:163
+ uint64_t length = data.GetU32(&offset);
+ bool isDwarf64 = false;
+ if (length == 0x) {
xbolva00 wrote:
> variable is not used anywhere
Remo
Author: grimar
Date: Wed Oct 31 09:12:29 2018
New Revision: 345733
URL: http://llvm.org/viewvc/llvm-project?rev=345733&view=rev
Log:
[LLDB] - Regroup the switch entries in DWARFFormValue::ExtractValue. NFC.
This is NFC to clean up the `DWARFFormValue::ExtractValue`.
It groups similar `DW_FORM_*`
Author: adrian
Date: Wed Oct 31 12:42:02 2018
New Revision: 345768
URL: http://llvm.org/viewvc/llvm-project?rev=345768&view=rev
Log:
Makefile.rules: Don't use code signing on macOS; it isn't necessary.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/tru
clayborg added a comment.
Just one question about extracting the value for DW_AT_ranges. It would be nice
if we just took care of extracting the value so the form value was more useful
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1072-1079
+ if (at_rang
zturner created this revision.
zturner added reviewers: aleksandr.urakov, lemo.
This adds basic support for getting function signature types
into LLDB's type system, including into clang's AST. There are
a few edge cases which are not correctly handled, mostly dealing
with nested classes,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345783: [FileSystem] Extend file system and have it use the
VFS. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53
Author: jdevlieghere
Date: Wed Oct 31 14:49:27 2018
New Revision: 345783
URL: http://llvm.org/viewvc/llvm-project?rev=345783&view=rev
Log:
[FileSystem] Extend file system and have it use the VFS.
This patch extends the FileSystem class with a bunch of functions that
are currently implemented as m
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345783: [FileSystem] Extend file system and have it use
the VFS. (authored by JDevlieghere, committed by ).
Herald added subscribers: teemperor, abidh.
Changed prior to commit:
https://reviews.llvm.o
Author: jdevlieghere
Date: Wed Oct 31 15:09:58 2018
New Revision: 345787
URL: http://llvm.org/viewvc/llvm-project?rev=345787&view=rev
Log:
[FileSystem] Remove EnumerateDirectory
The new implementation of EnumerateDirectory relies on `::no_push()`
being implemented for the VFS recursive directory
Author: jdevlieghere
Date: Wed Oct 31 17:26:09 2018
New Revision: 345799
URL: http://llvm.org/viewvc/llvm-project?rev=345799&view=rev
Log:
[FileSystem] Re-add EnumerateDirectory
Re-enable EnumerateDirectory now that no_push is available in llvm (r345793).
Modified:
lldb/trunk/include/lldb/Ho
Author: jdevlieghere
Date: Wed Oct 31 17:33:27 2018
New Revision: 345800
URL: http://llvm.org/viewvc/llvm-project?rev=345800&view=rev
Log:
[FileSystem] Move EnumerateDirectory from FileSpec to FileSystem.
This patch moves the EnumerateDirectory functionality and related enum
and typedef from File
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345800: [FileSystem] Move EnumerateDirectory from FileSpec
to FileSystem. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
aprantl added a comment.
I now spent (way too much :-) time experimenting with alternative
implementations of this patch. In https://reviews.llvm.org/D53961 there is a
version that changes GetNumChildren() to take an execution context. I don't
think that doing it this way is a good solution eit
Author: jdevlieghere
Date: Wed Oct 31 21:45:28 2018
New Revision: 345812
URL: http://llvm.org/viewvc/llvm-project?rev=345812&view=rev
Log:
[FileSystem] Remove GetByteSize() from FileSpec
This patch removes the GetByteSize method from FileSpec and updates its
uses with calls to the FileSystem.
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345812: [FileSystem] Remove GetByteSize() from FileSpec
(authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53788?vs=17
25 matches
Mail list logo
