This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB341746: Check if a terminal supports colors on Windows
properly (authored by xbolva00, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D51772
Files:
source/Core/Debugger.cpp
source
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341746: Check if a terminal supports colors on Windows
properly (authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51772?v
Hi Pavel,
OK to revert it? It completely broke testsuite on Linux.
Jan Kratochvil
On Wed, 05 Sep 2018 20:08:56 +0200, Pavel Labath via lldb-commits wrote:
> Author: labath
> Date: Wed Sep 5 11:08:56 2018
> New Revision: 341487
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341487&view=rev
On Sat, 08 Sep 2018 10:25:11 +0200, Jan Kratochvil wrote:
> OK to revert it? It completely broke testsuite on Linux.
BTW it regressed when LLDB is built by clang-6.0.1-1.fc28.x86_64.
When I build LLDB by gcc-8.1.1-5.fc28.x86_64 it still works.
Jan
___
Author: labath
Date: Sat Sep 8 03:33:14 2018
New Revision: 341747
URL: http://llvm.org/viewvc/llvm-project?rev=341747&view=rev
Log:
Revert "Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode"
This reverts commit r341487. Jan Kratochvil reports it breaks LLDB when
compiling with cla
kristina added subscribers: clayborg, kristina.
kristina added a reviewer: clayborg.
kristina added a comment.
Please add code reviewers to your differentials when you make them especially
when they're this big, at the very least the code owner for that particular
project should be added. I adde
asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D51162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: labath
Date: Sat Sep 8 23:01:12 2018
New Revision: 341758
URL: http://llvm.org/viewvc/llvm-project?rev=341758&view=rev
Log:
Re-commit "Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode"
This recommits r341487, which was reverted due to failing tests with
clang. It turned o