[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

2018-09-02 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 163646. tatyana-krasnukha added a comment. %feature("nothreadallow") looks more appropriate in this case. GetDescription method is quite cheap, no need to handle the GIL. Repository: rLLDB LLDB https://reviews.llvm.org/D51569 Files: scripts/

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

2018-09-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, davide. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl, mgorny. Tried to address Greg Clayton's performance concerns here: Rebased

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-09-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D32167#1215821, @clayborg wrote: > I have stalled on this due to performance. Anything I do will ruin the > performance of 99% of the DWARF consumers for .debug_types which is rarely > used by our clients. I have tried to implement it

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

2018-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Do we have a test case for different target byte orders that could be used as a test template here? Otherwise I would just merge this in as the previous behavior of this function was clearly wrong. Repository: rLLDB LLDB https://reviews.llvm.org/D48704

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

2018-09-02 Thread Enrico Granata via Phabricator via lldb-commits
granata.enrico resigned from this revision. granata.enrico added a comment. I don't work on LLDB anymore. I am sure Greg will do a fine job reviewing! Repository: rLLDB LLDB https://reviews.llvm.org/D51569 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

2018-09-02 Thread Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits
ramana-nvr added a comment. Sorry, I don't have a test case for this and I am yet to understand lldb test suite to create one. Repository: rLLDB LLDB https://reviews.llvm.org/D48704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http: