Author: labath
Date: Fri Aug 31 01:31:27 2018
New Revision: 341186
URL: http://llvm.org/viewvc/llvm-project?rev=341186&view=rev
Log:
XFail one more VSCode test which fails under heavy load
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunction
aleksandr.urakov updated this revision to Diff 163528.
aleksandr.urakov added a comment.
Drop a scope part of a class member function name.
https://reviews.llvm.org/D51162
Files:
include/lldb/Symbol/ClangASTContext.h
lit/SymbolFile/PDB/class-layout.test
lit/SymbolFile/PDB/func-symbols.tes
I don’t think I’m really a good person to look at AST stuff. I can look for
general style comments, obvious flaws, and test coverage. but you may be
the best person regarding on the content of the patch. Does that sound ok?
On Fri, Aug 31, 2018 at 7:20 AM Aleksandr Urakov via Phabricator <
revi...@
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
I don’t think I’m really a good person to look at AST stuff. I can look for
general style comments, obvious flaws, and test coverage. but you may be
the best person regarding on the content of the patch. Does that sound ok?
h
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks! I assume there is a whole bunch of other enums for which we should be
doing the same thing now?
Also there might be some 1-based ones for which we also need to check the lower
bound.
aleksandr.urakov added a comment.
Thanks :) Let's also wait for what Aaron will say? Because the patch is big
enough.
As for testing, what do you think if I'll add complex tests for the expressions
evaluation, when it will be ready? I have no other idea how to test the changes
in this patch...
zturner added a comment.
I think in clang they have a method to dump the AST. Could we add something
like that to `lldb-test`? We're using the `symbols` subcommand, maybe it would
be worth it to add a `--dump-ast` flag to that subcommand? That seems like a
generally useful testing feature.
aleksandr.urakov added a comment.
Yes, I'll try to implement that, thanks for the idea!
https://reviews.llvm.org/D51162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nealsid updated this revision to Diff 163548.
nealsid added a comment.
Fix 80 char line length violations
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50299
Files:
include/lldb/Core/IOHandler.h
include/lldb/Host/Editline.h
source/Core/IOHandler.cpp
source/Host/common/Editline.cpp
zturner added a comment.
In https://reviews.llvm.org/D50299#1220983, @nealsid wrote:
> Fix 80 char line length violations
Just curious, how did you fix them? Was it by running clang-format, or
manually?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50299
___
nealsid updated this revision to Diff 163559.
nealsid added a comment.
Ran clang-format
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50299
Files:
include/lldb/Core/IOHandler.h
include/lldb/Host/Editline.h
source/Core/IOHandler.cpp
source/Host/common/Editline.cpp
unittests/Editl
jingham added a comment.
In https://reviews.llvm.org/D51445#1220905, @aprantl wrote:
> Thanks! I assume there is a whole bunch of other enums for which we should be
> doing the same thing now?
> Also there might be some 1-based ones for which we also need to check the
> lower bound.
Be caref
Author: friss
Date: Fri Aug 31 11:14:53 2018
New Revision: 341233
URL: http://llvm.org/viewvc/llvm-project?rev=341233&view=rev
Log:
Fix a comment to use the correct variable name.
Modified:
lldb/trunk/include/lldb/API/SBProcess.h
Modified: lldb/trunk/include/lldb/API/SBProcess.h
URL:
http:/
Author: labath
Date: Fri Aug 31 11:25:01 2018
New Revision: 341235
URL: http://llvm.org/viewvc/llvm-project?rev=341235&view=rev
Log:
Avoid using short identifiers in some tests
This applies the same workaround as r321271 to other tests. The root
problem is that lldb finds an internal symbol with
teemperor created this revision.
teemperor added a reviewer: davide.
Herald added subscribers: lldb-commits, abidh, JDevlieghere, mgorny.
This patch introduces a LazyMember template that allows specifying member
variables
which values will be computed once they are read the first time. This is
s
davide added inline comments.
Comment at: include/lldb/DataFormatters/ValueObjectPrinter.h:146
+
+#define LLDB_VOP ValueObjectPrinter
+ LazyBoolMember m_should_print;
can you typedef?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51557
___
zturner added a comment.
I think we should put this in `llvm/ADT` as it does not seem specific to
debugging, and could be useful for others.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51557
___
lldb-commits mailing list
lldb-commits@lists.
davide added a comment.
I agree.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Also I think it doesn't need to be specific to member variables. We could just
have
template class Lazy {
std::function Update;
Optional Value;
public:
LazyValue(std::function Update) : Update(std::move(Update)) {}
};
Then, to get the same member fun
shafik added inline comments.
Comment at: include/lldb/DataFormatters/ValueObjectPrinter.h:146
+
+#define LLDB_VOP ValueObjectPrinter
+ LazyBoolMember m_should_print;
davide wrote:
> can you typedef?
I feel like using ... = is cleaner
Repository:
rLLDB LLDB
Author: friss
Date: Fri Aug 31 16:03:28 2018
New Revision: 341268
URL: http://llvm.org/viewvc/llvm-project?rev=341268&view=rev
Log:
File completion bugfix
If you tried to complete somwthing like ~/., lldb would come up with a lot
of non-existent filenames by concatenating every exisitng file in t
21 matches
Mail list logo
