[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. Just to clarify - I guess `DWARFConcatenatingDataExtractor` should replace all uses of `DWARFDataExtractor` in the `DWARF/` subdirectory, whenever `lldb::offset_t offset` is used, right? As the other option would be to remap just `lldb::user_id_t` but that would no

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

aleksandr.urakov added a comment. Herald added a subscriber: teemperor. Ping! Can you review this, please? Repository: rLLDB LLDB https://reviews.llvm.org/D51162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [lldb] r341078 - Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

Author: adrian Date: Thu Aug 30 08:11:00 2018 New Revision: 341078 URL: http://llvm.org/viewvc/llvm-project?rev=341078&view=rev Log: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI. This patch extends the SBAPI to allow for setting a breakpoint not only at a specific line, but a

[Lldb-commits] [PATCH] D51461: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341078: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [lldb] r341080 - Remove redundant initialization

Author: adrian Date: Thu Aug 30 08:39:08 2018 New Revision: 341080 URL: http://llvm.org/viewvc/llvm-project?rev=341080&view=rev Log: Remove redundant initialization Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/Expre

[Lldb-commits] [PATCH] D50384: Move Predicate.h from Host to Utility

labath added a comment. Also, to answer Zachary's question: A lot of the existing uses of Predicate class could be replaced by `std::future` (often `future`). The one in the Event class is in this category. However, there are some uses (these tend to be hacks of various magnitudes), which are

Re: [Lldb-commits] [lldb] r341080 - Remove redundant initialization

Just curious, what prompted this change? (compiler diagnostic? forcing value initialization in the member initializer list is harmless in this case) Also, if we want to do this kind of cleanup, m_compiler initialization is also redundant. On Thu, Aug 30, 2018 at 8:39 AM, Adrian Prantl via lldb-co

Re: [Lldb-commits] [lldb] r341080 - Remove redundant initialization

> On Aug 30, 2018, at 9:43 AM, Leonard Mosescu wrote: > > Just curious, what prompted this change? (compiler diagnostic? forcing value > initialization in the member initializer list is harmless in this case) This particular change was (for whatever reason) in the swift.org

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 163366. teemperor added a comment. - Rebased patch. https://reviews.llvm.org/D48465 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/UserExpression.h packages/Python/lldbsuite/test/expression_command/completion/.categories

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. (Just pressing the green button for Jim) https://reviews.llvm.org/D48465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [lldb] r341086 - Added initial code completion support for the `expr` command

Author: teemperor Date: Thu Aug 30 10:29:37 2018 New Revision: 341086 URL: http://llvm.org/viewvc/llvm-project?rev=341086&view=rev Log: Added initial code completion support for the `expr` command Summary: This patch adds initial code completion support for the `expr` command. We now have a comp

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

This revision was automatically updated to reflect the committed changes. Closed by commit rL341086: Added initial code completion support for the `expr` command (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[Lldb-commits] [lldb] r341089 - Move Predicate.h from Host to Utility

Author: teemperor Date: Thu Aug 30 10:51:10 2018 New Revision: 341089 URL: http://llvm.org/viewvc/llvm-project?rev=341089&view=rev Log: Move Predicate.h from Host to Utility Summary: This class was initially in Host because its implementation used to be very OS-specific. However, with C++11, it h

[Lldb-commits] [PATCH] D50384: Move Predicate.h from Host to Utility

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB341089: Move Predicate.h from Host to Utility (authored by teemperor, committed by ). Herald added a subscriber: jfb. Changed prior to commit: https://reviews.llvm.org/D50384?vs=159649&id=163371#toc

[Lldb-commits] [PATCH] D50802: Expression autocompletion with variables and symbols

teemperor added a comment. @acoomans https://reviews.llvm.org/D48465 has landed, so feel free to file bugs for any completions that are not provided by this. Thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D50802 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

friss marked 2 inline comments as done. friss added inline comments. Comment at: include/lldb/Symbol/ClangASTContext.h:284 + ((bool)pack_name == (bool)packed_args) && + (!packed_args || !packed_args->args.empty()); } friss wrote: > sh

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

friss added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:7664 + + assert(args.size() && + "We shouldn't have a template specialization without any args"); friss wrote: > shafik wrote: > > The asset before we do math making this assumpti

[Lldb-commits] [lldb] r341096 - Fix deadlock in gdb-client tests

Author: labath Date: Thu Aug 30 12:14:02 2018 New Revision: 341096 URL: http://llvm.org/viewvc/llvm-project?rev=341096&view=rev Log: Fix deadlock in gdb-client tests Using a listen queue of length 0 caused a deadlock on my machine in the gdb-client tests while attempting to establish the loopback

[Lldb-commits] [lldb] r341105 - Fixed code style for the CodeCompletion members [NFC]

Author: teemperor Date: Thu Aug 30 12:47:53 2018 New Revision: 341105 URL: http://llvm.org/viewvc/llvm-project?rev=341105&view=rev Log: Fixed code style for the CodeCompletion members [NFC] This code is in LLDB, so it should also follow the LLDB code style and use the m_ prefix for members. Modi

[Lldb-commits] [lldb] r341109 - Added missing include to for 'std::isalnum'

Author: teemperor Date: Thu Aug 30 13:14:22 2018 New Revision: 341109 URL: http://llvm.org/viewvc/llvm-project?rev=341109&view=rev Log: Added missing include to for 'std::isalnum' Should fix the failing Windows bots. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpression

[Lldb-commits] [lldb] r341112 - Adjusting some comments in ClangExpressionParser.cpp

Author: teemperor Date: Thu Aug 30 13:19:57 2018 New Revision: 341112 URL: http://llvm.org/viewvc/llvm-project?rev=341112&view=rev Log: Adjusting some comments in ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/tr

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

friss updated this revision to Diff 163399. friss added a comment. Address feedback https://reviews.llvm.org/D51387 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerType.h include/lldb/Symbol/TypeSystem.h packages/Python/lldbsuite/test/lang/cpp/class-template-pa

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good to me. Jim should take a look as well. https://reviews.llvm.org/D51387 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] r341121 - Move NoBuiltin=true closer to the other LangOpts code [NFC]

Author: teemperor Date: Thu Aug 30 13:56:58 2018 New Revision: 341121 URL: http://llvm.org/viewvc/llvm-project?rev=341121&view=rev Log: Move NoBuiltin=true closer to the other LangOpts code [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified:

[Lldb-commits] [lldb] r341124 - Use a CompletionRequest in the expression command completion [NFC]

Author: teemperor Date: Thu Aug 30 14:26:32 2018 New Revision: 341124 URL: http://llvm.org/viewvc/llvm-project?rev=341124&view=rev Log: Use a CompletionRequest in the expression command completion [NFC] The patch was originally written before we had a CompletionRequest, so it still used a StringL

[Lldb-commits] [lldb] r341126 - Fixed comment for UserExpression::Complete [NFC]

Author: teemperor Date: Thu Aug 30 14:31:04 2018 New Revision: 341126 URL: http://llvm.org/viewvc/llvm-project?rev=341126&view=rev Log: Fixed comment for UserExpression::Complete [NFC] Modified: lldb/trunk/include/lldb/Expression/UserExpression.h Modified: lldb/trunk/include/lldb/Expression/

[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

shafik created this revision. shafik added reviewers: jingham, davide. Herald added subscribers: christof, mgorny. Herald added a reviewer: EricWF. Adding data formatter for libc++ std::variant and appropriate tests https://reviews.llvm.org/D51520 Files: lldb.xcodeproj/project.pbxproj pack

[Lldb-commits] [PATCH] D51445: Remove undefined behavior around the use of StateType

shafik marked 3 inline comments as done. shafik added a comment. @jingham I am switching to the @aprantl suggestions which feels cleaner and removes this issue. Comment at: include/lldb/lldb-enumerations.h:60 ///< or threads get the chance to run. + kNumSt

[Lldb-commits] [PATCH] D51445: Remove undefined behavior around the use of StateType

shafik updated this revision to Diff 163450. shafik marked an inline comment as done. shafik added a comment. Switching enum guard to kLastStateType which references the last valid enum which lead to cleaner code instead of inventing a new value which does not have a good meaning in many cases.

[Lldb-commits] [lldb] r341157 - Fixed missing sidebars on the website

Author: teemperor Date: Thu Aug 30 19:07:05 2018 New Revision: 341157 URL: http://llvm.org/viewvc/llvm-project?rev=341157&view=rev Log: Fixed missing sidebars on the website We didn't mark these HTML files as executable, which means that the SSI includes for including the sidebar didn't work. Mo

[Lldb-commits] [lldb] r341163 - Silence some "control reaches end of non-void function" warnings with gcc

Author: labath Date: Thu Aug 30 22:18:11 2018 New Revision: 341163 URL: http://llvm.org/viewvc/llvm-project?rev=341163&view=rev Log: Silence some "control reaches end of non-void function" warnings with gcc Modified: lldb/trunk/source/Core/Mangled.cpp lldb/trunk/source/Core/RichManglingCo

[Lldb-commits] [lldb] r341164 - Increase qHostInfo packet timeout

Author: labath Date: Thu Aug 30 22:34:03 2018 New Revision: 341164 URL: http://llvm.org/viewvc/llvm-project?rev=341164&view=rev Log: Increase qHostInfo packet timeout Host info computation can involve DNS traffic (to compute the remote host name). On very unreliable networks (such as free WiFi on

[Lldb-commits] [lldb] r341167 - Fix a typo in mac SIP workaround

Author: labath Date: Thu Aug 30 23:01:02 2018 New Revision: 341167 URL: http://llvm.org/viewvc/llvm-project?rev=341167&view=rev Log: Fix a typo in mac SIP workaround presumably the or subexpression was meant to be evaluated first. The way it is now means that we apply the workaround for any pytho