[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1212783, @jankratochvil wrote: > Just a ping, that `ConcatenatingDataExtractor` is still not coded, even as > some draft patch? Just checking to prevent duplicating some existing work. > FYI providing a rebase with few simple conflict

[Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

clayborg added a comment. In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote: > >> But if LLDB has different performance characteristics, or the default > >> should be different for other reasons - I'm fine with that. I think I left > >> it on for Apple so as not to mess with their stu

[Lldb-commits] [lldb] r340835 - Use a RAII guard to control access to DisassemblerLLVMC.

Author: teemperor Date: Tue Aug 28 08:31:01 2018 New Revision: 340835 URL: http://llvm.org/viewvc/llvm-project?rev=340835&view=rev Log: Use a RAII guard to control access to DisassemblerLLVMC. Summary: This patch replaces the manual lock/unlock calls for gaining exclusive access to the disassemb

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340835: Use a RAII guard to control access to DisassemblerLLVMC. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51319

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

teemperor added inline comments. Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:176 bool got_op = false; -std::shared_ptr disasm_sp(GetDisassembler()); -if (disasm_sp) { - const ArchSpec &arch = disasm_sp->GetArchitecture(); +Disassembler

[Lldb-commits] [lldb] r340841 - Respect platform sysroot when loading core files

Author: labath Date: Tue Aug 28 09:32:46 2018 New Revision: 340841 URL: http://llvm.org/viewvc/llvm-project?rev=340841&view=rev Log: Respect platform sysroot when loading core files Patch by Eugene Birukov Differential Revision: https://reviews.llvm.org/D49685 Modified: lldb/trunk/packages

Re: [Lldb-commits] [PATCH] D51208: [DWARF] Fix dwarf5-index-is-used.cpp

On Tue, Aug 28, 2018 at 7:33 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In https://reviews.llvm.org/D51208#1214743, @dblaikie wrote: > > > >> But if LLDB has different performance characteristics, or the default > should be different for othe

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

smeenai created this revision. smeenai added reviewers: beanz, davide, xiaobai. GNU sed and BSD sed have a different command-line syntax for in-place editing, and the current form of the script would only work with BSD sed. The easiest way to get cross-platform behavior is to specify a backup suff

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194 +# of the test build dir is the LLVM build dir. +llvm_build_dir = os.

[Lldb-commits] [lldb] r340876 - [lldb] Fix lldb build on musl

Author: teemperor Date: Tue Aug 28 15:17:28 2018 New Revision: 340876 URL: http://llvm.org/viewvc/llvm-project?rev=340876&view=rev Log: [lldb] Fix lldb build on musl Summary: limits.h is needed for getting PATH_MAX definition, this comes to fore with musl libc where limits.h is not included indir

[Lldb-commits] [PATCH] D31275: [lldb] Fix lldb build on musl

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340876: [lldb] Fix lldb build on musl (authored by teemperor, committed by ). Herald added subscribers: lldb-commits, abidh. Changed prior to commit: https://reviews.llvm.org/D31275?vs=143455&id=1629

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

stella.stamenova added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194 +# of the test build dir is the LLVM build dir. +llvm_build_dir = os.path.dirname(os.path.abspath(test_build_dir)) +assert os.path.lexists(llvm_build_d

[Lldb-commits] [lldb] r340877 - Remove unnecessary entitlement in debugserver for iOS.

Author: jmolenda Date: Tue Aug 28 15:28:34 2018 New Revision: 340877 URL: http://llvm.org/viewvc/llvm-project?rev=340877&view=rev Log: Remove unnecessary entitlement in debugserver for iOS. Modified: lldb/trunk/tools/debugserver/source/debugserver-entitlements.plist Modified: lldb/trunk/to

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

friss created this revision. friss added reviewers: jingham, clayborg. Herald added a subscriber: JDevlieghere. When looking at template arguments in LLDB, we usually care about what the user passed in his code, not whether some of those arguments where passed as a variadic parameter pack. This p

[Lldb-commits] [lldb] r340880 - Allow IRInterpreter to deal with non-power-of-2 sized types to support some bitfield accesses.

Author: friss Date: Tue Aug 28 15:50:01 2018 New Revision: 340880 URL: http://llvm.org/viewvc/llvm-project?rev=340880&view=rev Log: Allow IRInterpreter to deal with non-power-of-2 sized types to support some bitfield accesses. Summary: For some bitfield patterns (like the one added by this commi

[Lldb-commits] [PATCH] D51245: Allow IRInterpreter to deal with non-power-of-2 sized types to support some bitfield accesses.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340880: Allow IRInterpreter to deal with non-power-of-2 sized types to support some… (authored by friss, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D51245: Allow IRInterpreter to deal with non-power-of-2 sized types to support some bitfield accesses.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340880: Allow IRInterpreter to deal with non-power-of-2 sized types to support some… (authored by friss, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

xiaobai accepted this revision. xiaobai added a comment. Regardless of compatibility, the man page for sed on OSX recommends not having a zero length extension while editing the file in place. LGTM. https://reviews.llvm.org/D51374 ___ lldb-commits

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340885: [LLDB] Fix script to work with GNU sed (authored by smeenai, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D51374?vs=162928&id=162988#toc

[Lldb-commits] [lldb] r340885 - [LLDB] Fix script to work with GNU sed

Author: smeenai Date: Tue Aug 28 16:47:22 2018 New Revision: 340885 URL: http://llvm.org/viewvc/llvm-project?rev=340885&view=rev Log: [LLDB] Fix script to work with GNU sed GNU sed and BSD sed have a different command-line syntax for in-place editing, and the current form of the script would only

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

davide added a comment. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D51374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51104: [PDB] Resolve a symbol context block info correctly

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D51104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg