[Lldb-commits] [PATCH] D50293: Added unit test for StringList

teemperor created this revision. Herald added a subscriber: mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D50293 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringListTest.cpp Index: unittests/Utility/StringListTest.cpp =

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3400-3403 +GetModule()->ReportWarning( +"Unable to initialize decompressor for section '%s'", +section->GetName().GetCString()); +return 0; You have

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

clayborg added a comment. LGTM after Pavel's inline comments are addressed. Repository: rLLDB LLDB https://reviews.llvm.org/D50274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r338961 - Added unit test for StringList

Author: teemperor Date: Sat Aug 4 10:28:21 2018 New Revision: 338961 URL: http://llvm.org/viewvc/llvm-project?rev=338961&view=rev Log: Added unit test for StringList Reviewers: labath Reviewed By: labath Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D50293

[Lldb-commits] [PATCH] D50293: Added unit test for StringList

This revision was automatically updated to reflect the committed changes. Closed by commit rL338961: Added unit test for StringList (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50293?vs=159165&id=159185#toc

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

labath added a comment. In https://reviews.llvm.org/D49740#1188055, @jingham wrote: > First off, I'm fine with Zachary's suggestion that we let the dust settle a > bit before we try to organize things better. We'll probably do a better job > then. Thanks. I agree this can wait, but I also do

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

labath added a comment. In https://reviews.llvm.org/D49740#1188079, @teemperor wrote: > > CompletionRequest - this sounds like it could go next to the command > > interpreter > > Yeah, makes sense. Even though Utility classes then can either not offer > completion methods (currently only ArchSp

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

teemperor created this revision. teemperor added a reviewer: labath. Herald added a subscriber: mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D50298 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringLexerTest.cpp Index: unittests/Utility/StringLexerTest.cpp ===

[Lldb-commits] [PATCH] D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs

jankratochvil updated this revision to Diff 159192. Repository: rLLDB LLDB https://reviews.llvm.org/D49969 Files: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h source/Plugins/SymbolFile/DWARF/NameToDIE.cpp source/Plugins/SymbolF

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

jloser added inline comments. Comment at: unittests/Utility/StringLexerTest.cpp:25 + +TEST(StringLexerTest, HasAtLest) { + StringLexer l("foo"); Nit: typo in the test case name. Repository: rLLDB LLDB https://reviews.llvm.org/D50298

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

teemperor updated this revision to Diff 159193. teemperor added a comment. - Fixed typo (Thanks Joe!) https://reviews.llvm.org/D50298 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringLexerTest.cpp Index: unittests/Utility/StringLexerTest.cpp =