[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

2018-07-21 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, labath. Herald added a subscriber: ki.stfu. Now this function uses SB API instead of HandleCommand. https://reviews.llvm.org/D49632 Files: tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp Index: tools/lldb-mi/MICm

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

2018-07-21 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp:963 +sbProcess.GetDescription(streamOut); +for (uint32_t i = 0, e = sbProcess.GetNumThreads(); i < e; ++i) { + const lldb::SBThread thread = sbProcess.GetThreadAtIndex(i); --

[Lldb-commits] [PATCH] D49632: [WIP] Re-implement MI HandleProcessEventStateSuspended.

2018-07-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So with CMICmnLLDBDebuggerHandleEvents::HandleProcessEventStateSuspended() it will report a bunch of text back through the MI interface with this each time? Why would it do that? I would assume that the MI interface would handle this programmatically? ==

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

2018-07-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. We do need to test the performance of this as demangling is a hot spot when we parse any object file. If it is faster, then we should just replace it and not add any options to be able to switch. Also we should compare demangled names between the two to ensure there ar

[Lldb-commits] [PATCH] D49632: [WIP] Re-implement MI HandleProcessEventStateSuspended.

2018-07-21 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added a comment. In https://reviews.llvm.org/D49632#1171024, @clayborg wrote: > So with CMICmnLLDBDebuggerHandleEvents::HandleProcessEventStateSuspended() it > will report a bunch of text back through the MI interface with this each > time? Why would it do that? I would assume that th