[Lldb-commits] [PATCH] D48976: Replaced more boilerplate code with CompletionRequest (NFC)

teemperor created this revision. teemperor added a reviewer: jingham. As suggested in https://reviews.llvm.org/D48796, this patch replaces even more internal calls that were using the old completion API style with a single CompletionRequest. In some cases we also pass an option vector/index, but

[Lldb-commits] [PATCH] D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a subscriber: mgorny. It seems we both have the HAVE_LIBCOMPRESSION define in the config header and in the source files definitions of some files. This causes that the Config.h header emits the following warning whe

[Lldb-commits] [PATCH] D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks like a safe change to make. https://reviews.llvm.org/D48977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

jingham added a comment. Sorry, I wasn't clear. Suppose that the `m_thread_idx` coming into DoExecute is LLDB_INVALID_THREAD_ID. That's what happens if you don't select a thread id on the command line, for instance. Then the code around 1164 will set `thread` to be the default thread. But `

[Lldb-commits] [PATCH] D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES

This revision was automatically updated to reflect the committed changes. Closed by commit rL336377: Fixed redefinition warnings with LLVM_ENABLE_MODULES (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48977?vs=

[Lldb-commits] [PATCH] D48993: [CMake] Give Python module install command a component name

xiaobai created this revision. xiaobai added reviewers: sas, smeenai, labath, davide. Herald added a subscriber: mgorny. This install command is used to install all the python modules and python bindings. Currently the only way to install it is this: `cmake -P build/tools/lldb/tools/scripts/cmake_

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor updated this revision to Diff 154318. teemperor added a comment. - Client now has to explicitly allow the acceptance of exit codes. - Moved logic to the CommandInterpreter. - Added more tests. Thanks for the feedback Jim and Greg, very much appreciated! https://reviews.llvm.org/D48659

[Lldb-commits] [PATCH] D48993: [CMake] Give Python module install command a component name

xiaobai planned changes to this revision. xiaobai added a comment. This isn't quite doing what I want yet. I intend on adding an install target. https://reviews.llvm.org/D48993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [lldb] r336395 - [CMake] Simplify a few framework build rules

Author: xiaobai Date: Thu Jul 5 15:16:15 2018 New Revision: 336395 URL: http://llvm.org/viewvc/llvm-project?rev=336395&view=rev Log: [CMake] Simplify a few framework build rules Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake URL

[Lldb-commits] [lldb] r336397 - Don't muck with _LIBCPP_INLINE_VISIBILITY just to get predictable line table entries.

Author: jingham Date: Thu Jul 5 16:11:27 2018 New Revision: 336397 URL: http://llvm.org/viewvc/llvm-project?rev=336397&view=rev Log: Don't muck with _LIBCPP_INLINE_VISIBILITY just to get predictable line table entries. This test was trying to stop at a variety of std::vector calls. It looks li

[Lldb-commits] [lldb] r336398 - Address a few post facto review comments from Adrian.

Author: jingham Date: Thu Jul 5 16:23:06 2018 New Revision: 336398 URL: http://llvm.org/viewvc/llvm-project?rev=336398&view=rev Log: Address a few post facto review comments from Adrian. Thanks, Adrian! Modified: lldb/trunk/include/lldb/Target/Platform.h lldb/trunk/source/Plugins/Platfo

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

jingham accepted this revision. jingham added a comment. That seems reasonable to me. https://reviews.llvm.org/D48659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48993: [CMake] Give Python module install command a component name

xiaobai abandoned this revision. xiaobai added a comment. Gonna take some time to rethink and better understand this. https://reviews.llvm.org/D48993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r336403 - Remove a bunch more references to _LIBCPP_INLINE_VISIBILITY

Author: jingham Date: Thu Jul 5 17:16:21 2018 New Revision: 336403 URL: http://llvm.org/viewvc/llvm-project?rev=336403&view=rev Log: Remove a bunch more references to _LIBCPP_INLINE_VISIBILITY and adjust the tests that needed it to set their breakpoints more robustly. Modified: lldb/trunk