[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

ramana-nvr created this revision. ramana-nvr added a reviewer: labath. For the 'thread until' command, the selected thread ID, to perform the operation on, could be of the current thread or the specified thread. https://reviews.llvm.org/D48865 Files: source/Commands/CommandObjectThread.cpp

[Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

ramana-nvr created this revision. ramana-nvr added a reviewer: labath. The function ProcessGDBRemote::UpdateThreadIDsFromStopReplyThreadsValue(), which is being called after the thread PCs are updated, is clearing the thread PC list and that is wrong. https://reviews.llvm.org/D48868 Files:

[Lldb-commits] [lldb] r336200 - Add new API to SBTarget and SBModule classes.

Author: apolyakov Date: Tue Jul 3 07:22:44 2018 New Revision: 336200 URL: http://llvm.org/viewvc/llvm-project?rev=336200&view=rev Log: Add new API to SBTarget and SBModule classes. Summary: The new API allows to find a list of compile units related to target/module. Reviewers: aprantl, claybor

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336200: Add new API to SBTarget and SBModule classes. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48801?vs=153846&

[Lldb-commits] [lldb] r336206 - [lldb-mi] Re-implement symbol-list-lines command.

Author: apolyakov Date: Tue Jul 3 08:40:20 2018 New Revision: 336206 URL: http://llvm.org/viewvc/llvm-project?rev=336206&view=rev Log: [lldb-mi] Re-implement symbol-list-lines command. Summary: Now this command uses SB API instead of HandleCommand. Reviewers: aprantl, clayborg Reviewed By: apr

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336206: [lldb-mi] Re-implement symbol-list-lines command. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48802?vs=153

[Lldb-commits] [lldb] r336212 - Fix MSVC2015 compilation failure after r336206 patch.

Author: apolyakov Date: Tue Jul 3 09:07:30 2018 New Revision: 336212 URL: http://llvm.org/viewvc/llvm-project?rev=336212&view=rev Log: Fix MSVC2015 compilation failure after r336206 patch. Added missing headers. Modified: lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp Modified: lldb/trunk/too

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

jingham added a comment. This is correct, thanks for catching it! There are a few other places that use m_thread_idx above this change. Everything after the: if (thread == nullptr) { check should also use thread->GetID not m_options.m_thread_idx. This is all error reporting, so it's not a

[Lldb-commits] [PATCH] D40475: DWZ 06/07: DWZ test mode

jankratochvil updated this revision to Diff 153941. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/lldbinline.py packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/

[Lldb-commits] [PATCH] D40475: DWZ 06/07: DWZ test mode

jankratochvil updated this revision to Diff 153942. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/lldbinline.py packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil added a comment. The DWZ-testmode Makefile.rules part. The DWZ-mode is written as another test matrix dimension. Compared to this DWP-mode it autodetects if all the tools are available on the host for that testsuite m

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:520 $(EXE) : $(OBJECTS) $(ARCHIVE_NAME) $(DYLIB_FILENAME) $(LD) $(OBJECTS) $(ARCHIVE_NAME) -L. -l$(DYLIB_NAME) $(LDFLAGS) -o "$(EXE)" else Shouldn't be

[Lldb-commits] [lldb] r336235 - Ammend "Fix MSVC2015 compilation failure after r336206 patch".

Author: apolyakov Date: Tue Jul 3 15:51:01 2018 New Revision: 336235 URL: http://llvm.org/viewvc/llvm-project?rev=336235&view=rev Log: Ammend "Fix MSVC2015 compilation failure after r336206 patch". Modified: lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp Modified: lldb/trunk/tools/lldb-mi/MICm