[Lldb-commits] [lldb] r334697 - Fix includes in PlatformAppleSimulator.h

2018-06-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 14 02:08:54 2018 New Revision: 334697 URL: http://llvm.org/viewvc/llvm-project?rev=334697&view=rev Log: Fix includes in PlatformAppleSimulator.h This unbreaks the cmake build. Other plugins also use the include paths starting with Plugins/..., so I am hoping this will

[Lldb-commits] [lldb] r334702 - Fix PathMappingListTest on windows

2018-06-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 14 03:31:06 2018 New Revision: 334702 URL: http://llvm.org/viewvc/llvm-project?rev=334702&view=rev Log: Fix PathMappingListTest on windows r334615 changed the the value of FileSpec.IsRelative("/") for windows path syntax. We previously considered it absolute but now i

[Lldb-commits] [PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0

2018-06-14 Thread Carlo Kok via Phabricator via lldb-commits
carlokok abandoned this revision. carlokok added a comment. Herald added a subscriber: llvm-commits. This is from 2016; the code doesn't exist anaymore in this form. Repository: rL LLVM https://reviews.llvm.org/D24960 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] r334717 - DebugNamesDWARFIndex: fix handling of compressed sections

2018-06-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 14 07:41:30 2018 New Revision: 334717 URL: http://llvm.org/viewvc/llvm-project?rev=334717&view=rev Log: DebugNamesDWARFIndex: fix handling of compressed sections This fixes a silly bug where we were accidentally freeing the memory used to store the decompressed .debug

[Lldb-commits] [PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0

2018-06-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. shouldn't these be returning -1 for some of these? Zero usually means no error. You would need to check each unix function and return the right error code for failure. Repository: rL LLVM https://reviews.llvm.org/D24960 __

[Lldb-commits] [PATCH] D48177: Suppress SIGSEGV on Android when the program will recover

2018-06-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added a reviewer: labath. Herald added a subscriber: srhines. SIGSEGV signals are sent to Android processes when a NULL dereference happens in Java code that is being run as native code in dex, odex and oat files. In this patch I modified the Platforms to

[Lldb-commits] [lldb] r334743 - Add a script to setup codesigning on macOS.

2018-06-14 Thread Frederic Riss via lldb-commits
Author: friss Date: Thu Jun 14 11:04:13 2018 New Revision: 334743 URL: http://llvm.org/viewvc/llvm-project?rev=334743&view=rev Log: Add a script to setup codesigning on macOS. I've been using this script on a couple machines and it seems to work so I'm putting it out there, maybe other people wil

Re: [Lldb-commits] [lldb] r334743 - Add a script to setup codesigning on macOS.

2018-06-14 Thread Greg Clayton via lldb-commits
Nice! I never took the time to get this working from the command line. Thanks for this. > On Jun 14, 2018, at 11:04 AM, Frederic Riss via lldb-commits > wrote: > > Author: friss > Date: Thu Jun 14 11:04:13 2018 > New Revision: 334743 > > URL: http://llvm.org/viewvc/llvm-project?rev=334743&vi

[Lldb-commits] [lldb] r334755 - One ShortFract ought to be enough for everyone.

2018-06-14 Thread Benjamin Kramer via lldb-commits
Author: d0k Date: Thu Jun 14 12:20:48 2018 New Revision: 334755 URL: http://llvm.org/viewvc/llvm-project?rev=334755&view=rev Log: One ShortFract ought to be enough for everyone. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [PATCH] D48177: Suppress SIGSEGV on Android when the program will recover

2018-06-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. If you can get the address of the bad access from the signal, you could also check that it was 0x0 and only suppress the SIGSEGV if it is? Also, do you want to put in a setting to turn this behavior off? If the code in any of the files of this type were to crash for so

Re: [Lldb-commits] [lldb] r334743 - Add a script to setup codesigning on macOS.

2018-06-14 Thread Davide Italiano via lldb-commits
On Thu, Jun 14, 2018 at 11:04 AM, Frederic Riss via lldb-commits wrote: > Author: friss > Date: Thu Jun 14 11:04:13 2018 > New Revision: 334743 > > URL: http://llvm.org/viewvc/llvm-project?rev=334743&view=rev > Log: > Add a script to setup codesigning on macOS. > > I've been using this script on a

[Lldb-commits] [lldb] r334772 - Add an entitlement to debugserver

2018-06-14 Thread Frederic Riss via lldb-commits
Author: friss Date: Thu Jun 14 14:17:59 2018 New Revision: 334772 URL: http://llvm.org/viewvc/llvm-project?rev=334772&view=rev Log: Add an entitlement to debugserver On macOS 10.14, debugserver needs to have an entitlement do be allowed to debug processes. Adding this to both the Xcode and cmake

[Lldb-commits] [lldb] r334783 - Change TestExec.py from creating an i386+x86_64 fat binary

2018-06-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jun 14 17:55:53 2018 New Revision: 334783 URL: http://llvm.org/viewvc/llvm-project?rev=334783&view=rev Log: Change TestExec.py from creating an i386+x86_64 fat binary on darwin systems and re-execing itself, to creating two separate test programs; lldb runs the first pro

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

2018-06-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This is going as I imagined it should, looks great! We probably want to turn this on by default for "frame var" or no one will ever discover it. The IDE folks can decide on their own what to do from the SB API's. Since you are doing module filtering and this only trig

[Lldb-commits] [lldb] r334784 - Add support for PLATFORM_*SIMULATOR

2018-06-14 Thread Frederic Riss via lldb-commits
Author: friss Date: Thu Jun 14 19:50:45 2018 New Revision: 334784 URL: http://llvm.org/viewvc/llvm-project?rev=334784&view=rev Log: Add support for PLATFORM_*SIMULATOR The toolchain in Xcode 10 uses a new LC_BUILD_VERSION entry to identify simulator binaries. Add support for reading those to debu