labath added a comment.
Looks fine to me, just make the path computation windows-compatible.
Comment at: packages/Python/lldbsuite/test/dotest.py:386
+if is_exe(lldbtest_config.lldbExec):
+lldbtest_config.dotestWrapper = "{}-dotest".format(
+ os
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good. I don't know if anyone else has an opinion on how should we treat
"" for mapping purposes, but treating it as "." seems fine to me.
Comment at: unittests/Utility
Author: labath
Date: Mon May 21 02:27:16 2018
New Revision: 332831
URL: http://llvm.org/viewvc/llvm-project?rev=332831&view=rev
Log:
Add some apple-tables lookup tests
Summary:
Now that we are able to parse MachO files everywhere, we can write some
cross-platform tests for handling of apple accel
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332831: Add some apple-tables lookup tests (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47064
Files:
lldb/trunk/lit/Sym
Author: labath
Date: Mon May 21 03:09:22 2018
New Revision: 332833
URL: http://llvm.org/viewvc/llvm-project?rev=332833&view=rev
Log:
Improve coverage of the apple-tables test
After closer examination, it turns out we mis-classify one of the
methods only if two of the structs have the same name. S
labath created this revision.
labath added reviewers: JDevlieghere, jasonmolenda.
Herald added a subscriber: mgorny.
The plugin already builds fine on other platforms (linux, at least). All
that was necessary was to revitalize the hack in PlatformDarwinKernel
(not a very pretty hack, but it gets u
clayborg accepted this revision.
clayborg added a comment.
Looks fine, just move the option parsing code down by the others instead of
having it before the checking for file args.
Comment at: tools/lldb-mi/MIDriver.cpp:441-444
+ if (strArg.compare("--synchronous") == 0) {
Author: labath
Date: Mon May 21 07:12:52 2018
New Revision: 332841
URL: http://llvm.org/viewvc/llvm-project?rev=332841&view=rev
Log:
Reland "[DWARF] Extract indexing code into a separate class hierarchy"
After this commit, the xcode project will need to be updated to include
the new files added h
Author: gclayton
Date: Mon May 21 07:14:36 2018
New Revision: 332842
URL: http://llvm.org/viewvc/llvm-project?rev=332842&view=rev
Log:
Fix PathMappingList for relative and empty paths after recent FileSpec
normalization changes
PathMappingList was broken for relative and empty paths after normal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332842: Fix PathMappingList for relative and empty paths
after recent FileSpec… (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47133
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
JDevlieghere updated this revision to Diff 147787.
JDevlieghere added a comment.
Herald added a subscriber: mgorny.
Make this work for Windows
https://reviews.llvm.org/D47062
Files:
packages/Python/lldbsuite/test/dosep.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/
labath created this revision.
labath added reviewers: JDevlieghere, clayborg.
Herald added a subscriber: aprantl.
This extracts the common bits out of the two implementations back into
the SymbolFileDWARF class. The goal was to make the function as similar
as possible to the other DWARFIndex metho
polyakov.alex updated this revision to Diff 147806.
polyakov.alex added a comment.
Moved the option parsing code down by the others.
Repository:
rL LLVM
https://reviews.llvm.org/D47110
Files:
tools/lldb-mi/MICmnResources.cpp
tools/lldb-mi/MICmnResources.h
tools/lldb-mi/MIDriver.cpp
t
Author: zturner
Date: Mon May 21 12:47:45 2018
New Revision: 332877
URL: http://llvm.org/viewvc/llvm-project?rev=332877&view=rev
Log:
Enable Python API for OpenBSD.
Patch by David Carlier
Modified:
lldb/trunk/scripts/utilsOsType.py
Modified: lldb/trunk/scripts/utilsOsType.py
URL:
http://ll
clayborg added a comment.
Before I look too closely, we can probably add a DWARFDIE accessor function
like:
bool DWARFDIE::IsClassMethod() const;
Then this would allow each DWARFIndex to just check and we might be able to get
rid of the 3 lists in GetFunctionsByBaseOrMethodName? Seems like i
compnerd added inline comments.
Comment at: cmake/modules/FindLibEdit.cmake:53-54
+set(libedit_VERSION_STRING
"${libedit_major_version}.${libedit_minor_version}")
+unset(libedit_major_version)
+unset(libedit_minor_version)
+ endif()
labath wrote:
>
compnerd updated this revision to Diff 147874.
compnerd added a comment.
fix regex
https://reviews.llvm.org/D46726
Files:
CMakeLists.txt
cmake/modules/FindLibEdit.cmake
scripts/Python/modules/readline/CMakeLists.txt
Index: scripts/Python/modules/readline/CMakeLists.txt
=
Author: jingham
Date: Mon May 21 15:41:28 2018
New Revision: 332914
URL: http://llvm.org/viewvc/llvm-project?rev=332914&view=rev
Log:
Fix the Xcode project for the refactoring of the
DWARF reader.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project
Author: jingham
Date: Mon May 21 17:06:55 2018
New Revision: 332922
URL: http://llvm.org/viewvc/llvm-project?rev=332922&view=rev
Log:
Work around some odd instruction single-step behavior on macOS.
We've seen some cases on macOS where you go to instruction single
step (over a breakpoint), and sin
20 matches
Mail list logo
