labath added a comment.
My main question would be whether it is possible to specify all the lldb-mi
commands up-front, which is kinda required for this approach. I was against
this for the lldb-server tests, because there we often deal with values which
are not sufficiently deterministic (for e
aprantl added a comment.
Can you give an example of what you mean by "specifying the lldb-mi commands
up-front"? it's not immediately obvious to me how that would look like.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
___
lldb-commits ma
clayborg updated this revision to Diff 145969.
clayborg added a comment.
Broke up with patch further by submitting:
[PATH] https://reviews.llvm.org/D46529: Add support to object files for
accessing the .debug_types section
https://reviews.llvm.org/D46529
[PATCH] https://reviews.llvm.org/D46606:
labath added a comment.
In https://reviews.llvm.org/D46588#1093267, @aprantl wrote:
> Can you give an example of what you mean by "specifying the lldb-mi commands
> up-front"? it's not immediately obvious to me how that would look like.
In your example `lldb-mi-demo.input` is static text, righ
Author: stella.stamenova
Date: Wed May 9 12:58:51 2018
New Revision: 331914
URL: http://llvm.org/viewvc/llvm-project?rev=331914&view=rev
Log:
[cmake, unittests] Fix the CMake file for the LLDB unittests to support
multiple configurations
Summary: The current setup for the unit tests only works
aprantl added a comment.
Got it. We certainly do have dependent checks in our current tests:
# Test that -data-info-line works for address
self.runCmd("-data-info-line *%#x" % addr)
self.expect(
"\^done,start=\"0x0*%x\",end=\"0x[0-9a-f]+\",file=\".+?main.cpp\",line=\"%d\"" %
(a
aprantl added a comment.
Actually, the example I posted was not a good one. I'm fairly certain that that
was de facto static information or otherwise not particularly important
information.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
__
aprantl created this revision.
aprantl added a reviewer: jasonmolenda.
Herald added a subscriber: mgorny.
Getting the deployment target can be significant information when rebuilding
clang modules since availability information could depend on it. The unittest
is cargo-culted from the ELF unit t
labath added a comment.
In https://reviews.llvm.org/D46576#1091548, @clayborg wrote:
> Before adding the DWARF 5 index support, we should virtualize this searching
> and indexing into a base class. Then we make 1 class for manual DWARF
> indexing, one for Apple indexes, and one for DWARF5. Then
labath added a comment.
Looks great. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D46529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I think we should fix lldb to reconstruct the full name based on the
information from the dwarf. Right now, it seems both clang and gcc provide
enough information to do this. If we start doing that, then it should also
be fairly easy to implement some kind of fancy formatting (like we spoke
about i
labath added a comment.
This looks fine to me. I am not clicking accept yet, so other debug info folks
can take a look at this too.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:28
// Out of memory?
- if (cu_sp.get() == NULL)
+ if (!cu_sp)
return n
Author: labath
Date: Wed May 9 01:21:25 2018
New Revision: 331855
URL: http://llvm.org/viewvc/llvm-project?rev=331855&view=rev
Log:
[DWARF] Align non-accelerated function fullname searching with the apple-tables
path
Summary:
Before this patch the two paths were doing very different things
- th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331855: [DWARF] Align non-accelerated function fullname
searching with the apple-tables… (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
On Tue, 8 May 2018 at 18:27, via lldb-commits
wrote:
> Clang can control the emission of or not in the name, using the
"debugger tuning" feature. It sounds like neither LLDB nor PS4 will mind
losing the in the name, and it makes the indexing simpler. If the
tuning is set for GDB then we can s
polyakov.alex updated this revision to Diff 145909.
polyakov.alex retitled this revision from "[WIP][LLDB-MI] Add possibility to
set breakpoints without selecting a target." to "[LLDB][lldb-mi] Add
possibility to set breakpoints without selecting a target.".
polyakov.alex edited the summary of th
labath added a comment.
Out of curiosity, are there any plans to improve the lldb-mi test reliability
situation? As it stands now, most of the lldb-mi tests are disabled one way or
another due to them being flaky.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
__
Author: labath
Date: Wed May 9 07:29:30 2018
New Revision: 331880
URL: http://llvm.org/viewvc/llvm-project?rev=331880&view=rev
Log:
Modernize and clean-up the Predicate class
Summary:
The comments on this class were out of date with the implementation, and
the implementation itself was inconsist
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331880: Modernize and clean-up the Predicate class (authored
by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46580?vs=145682&id=145
Author: labath
Date: Wed May 9 07:49:43 2018
New Revision: 331882
URL: http://llvm.org/viewvc/llvm-project?rev=331882&view=rev
Log:
Fix Windows build for the Predicate.h refactor in r331880
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/DebuggerThread.cpp
Modified: lldb/trunk/so
clayborg updated this revision to Diff 145926.
clayborg added a comment.
Remove check for NULL cu_sp shared pointer as Pavel noted.
https://reviews.llvm.org/D46606
Files:
include/lldb/lldb-forward.h
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
source/Plugins/SymbolFile/DWARF/DW
Author: stella.stamenova
Date: Wed May 9 08:35:19 2018
New Revision: 331886
URL: http://llvm.org/viewvc/llvm-project?rev=331886&view=rev
Log:
[lit, lldbsuite] Add a bug reference to the failing TestLinuxCore and fix an
undefined property in dotest.py
Summary:
1) In TestLinuxCore rather than ski
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Looks like this is bringing the interface a *little* closer to the llvm one.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:40
+ //
aprantl added a comment.
In https://reviews.llvm.org/D46588#1092884, @labath wrote:
> Out of curiosity, are there any plans to improve the lldb-mi test reliability
> situation? As it stands now, most of the lldb-mi tests are disabled one way
> or another due to them being flaky.
Thanks for br
alur updated this revision to Diff 145939.
alur retitled this revision from "[LLDB] Support compressed debug info sections
(.zdebug*)" to "[LLDB] Support GNU-style compressed debug sections (.zdebug)".
alur added a comment.
Updated the diff to be against head, again.
https://reviews.llvm.org/D4
alur added a comment.
Friendly ping on this again. I re-merged the patch against head.
https://reviews.llvm.org/D45628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
In https://reviews.llvm.org/D46588#1093054, @aprantl wrote:
> In https://reviews.llvm.org/D46588#1092884, @labath wrote:
>
> > Out of curiosity, are there any plans to improve the lldb-mi test
> > reliability situation? As it stands now, most of the lldb-mi tests are
> >
aprantl added a comment.
Okay, that's no good. What would you think about writing tests using lit &
FileCheck? The lldb-mi tests should not be in the debuginfo category anyway,
since they only test the alternative driver.
$ cat lldb-mi-demo.input
-file-exec-and-symbols a.out
-break-insert
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331892: General cleanup to minimize the .debug_types patch
(authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46606?vs=145
Author: gclayton
Date: Wed May 9 09:42:53 2018
New Revision: 331892
URL: http://llvm.org/viewvc/llvm-project?rev=331892&view=rev
Log:
General cleanup to minimize the .debug_types patch
This cleanup is designed to make the https://reviews.llvm.org/D32167 patch
smaller and easier to read.
Cleanu
30 matches
Mail list logo
