Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

On Fri, 6 Apr 2018 at 23:36, Jason Molenda wrote: > > > > On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > labath added inline comments. > > > > > > > > Comment at: > packages/Python/lldbsuite/test/settings/TestSettings.py:544-

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

I generally try to stay away from debug info, but since I ended up working on the accelerator tables, and I am about to embark on the lldb part of that project I figure I should chime in. I am mostly speaking to the "using llvm libraries for parsing" part of the discussion, I don't have an opinions

[Lldb-commits] [PATCH] D45332: [LIT] Add new LLDB test format

JDevlieghere abandoned this revision. JDevlieghere added a comment. In https://reviews.llvm.org/D45332#1059429, @labath wrote: > In https://reviews.llvm.org/D45332#1058976, @JDevlieghere wrote: > > > In https://reviews.llvm.org/D45332#1058970, @zturner wrote: > > > > > I don't think `sys.path` is

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

JDevlieghere updated this revision to Diff 141608. JDevlieghere added a comment. - Have lldb test format live in lldb repo https://reviews.llvm.org/D45333 Files: lit/Suite/lit.cfg lit/Suite/lit.site.cfg.in lit/Suite/lldbtest.py test/CMakeLists.txt Index: test/CMakeLists.txt ===

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

On Mon, 09 Apr 2018 11:52:28 +0200, Pavel Labath wrote: > I'm hoping that I can stay clear of > the ongoing work on dwz&type units, as all of this happens in > SymbolFileDWARF, which you don't seem to touch that much. With excluded mass renaming ( https://reviews.llvm.org/D40467 ) and testcases (h

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

labath added a comment. In https://reviews.llvm.org/D45333#1058916, @JDevlieghere wrote: > This isn't meant to be checked-in as is, however I'm looking for feedback as > early as possible. > > There are currently two problems with the current diff: > > - `./bin/llvm-lit ../llvm/tools/lldb/lit/Su

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

labath added a comment. Jim, judging by the comment in https://reviews.llvm.org/D44306#1037587 you were fine with this patch except the naming part. Now that that's fixed, I hope this should be fine. Unless I hear from you, I am going to commit this so I can continue with re-layering the `Args`

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added inline comments. Herald added a reviewer: espindola. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:595 + uint64_t debug_info_size = get_debug_info_data().GetByteSize(); + data_segment.m_data.OffsetData(debug_info_size); +} -

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, with your updated naming, I am fine with this. https://reviews.llvm.org/D44306 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. Is there a link to some documentation that explains what DWZ does? I found a bunch of blurbs and man pages, but nothing useful. Nothing is found when I look for "DWZ" in either the DWARF 4 or DWARF 5 spec. Comment at: source/Plugins/SymbolFile/DWARF/

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. Found the DWZ stuff: http://www.dwarfstd.org/ShowIssue.php?issue=120604.1&type=open https://reviews.llvm.org/D32167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. For DWZ files, it seems types can be contained in external DWARF files and are referred to using new forms. The right way to fix this in LLDB it to load each of these external files as a separate DWZ file (no changes needed to anything) and then teach the SymbolFileDWA