andreadb added a comment.
If this patch is to unbreak the buildbots, then I think you should just commit
it.
We don't want to leave the buildbots in a failing state for too long.
If instead you don't feel confortable about this fix, then you should revert
r327219.
Repository:
rL LLVM
https
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327224: [lldb] Unbreak lldb builds due to r327219 (authored
by mgrang, committed by ).
Changed prior to commit:
https:/
timotheecour updated this revision to Diff 137927.
timotheecour marked 4 inline comments as done.
timotheecour edited the summary of this revision.
timotheecour added a comment.
- format
- format
- fixup
https://reviews.llvm.org/D44321
Files:
include/lldb/Core/Mangled.h
source/Core/CMakeLis
timotheecour added inline comments.
Comment at: source/Plugins/Language/D/DLanguage.cpp:108
+
+auto fun0=lib2->getFun("d_initialize");
+(*fun0)();
johanengelen wrote:
> Would it help to initialize druntime using a static module constructor in the
> lldbd
timotheecour updated this revision to Diff 137930.
timotheecour added a comment.
- use llvm::sys::DynamicLibrary
- format
https://reviews.llvm.org/D44321
Files:
include/lldb/Core/Mangled.h
source/Core/CMakeLists.txt
source/Core/Mangled.cpp
source/Plugins/Language/CMakeLists.txt
source
timotheecour marked an inline comment as done.
timotheecour added inline comments.
Comment at: source/Plugins/Language/D/DLanguage.cpp:24
+// TODO:MOVE
+struct SharedLib{
+ void* handle;
johanengelen wrote:
> Did you look into using llvm/Support/DynamicLibrary.h
RKSimon added a comment.
(post) LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D44354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
timotheecour added a comment.
In https://reviews.llvm.org/D44321#1033325, @davide wrote:
> This patch has no testcase. It shouldn't be particularly hard to write one,
> you can take inspiration from the one in `lit/`.
>
> Thanks!
5d29d3f0aa2f540c277a67eac5873feca8c62d51 (Support for OCaml nati
davide added a comment.
In https://reviews.llvm.org/D44321#1034043, @timotheecour wrote:
> In https://reviews.llvm.org/D44321#1033325, @davide wrote:
>
> > This patch has no testcase. It shouldn't be particularly hard to write one,
> > you can take inspiration from the one in `lit/`.
> >
> > Tha
timotheecour updated this revision to Diff 137940.
timotheecour added a comment.
- format
- use llvm::sys::DynamicLibrary
- added DLanguageProperties
https://reviews.llvm.org/D44321
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/PluginManager.h
source/API/SystemInitializerFull.cpp
timotheecour added a comment.
update: we can now set lldbdplugin in .lldbinit via `settings set
plugin.language.D.pluginfile` so this avoids hardcoding that file
https://reviews.llvm.org/D44321
___
lldb-commits mailing list
lldb-commits@lists.llvm.
timotheecour updated this revision to Diff 137942.
timotheecour added a comment.
- added doc
https://reviews.llvm.org/D44321
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/PluginManager.h
source/API/SystemInitializerFull.cpp
source/Core/CMakeLists.txt
source/Core/Mangled.cpp
s
timotheecour added a comment.
> It's a little more complicated for D because it's an out-of-tree compiler so
> it poses interesting challenges.
the demangling itself is thoroughly tested in
https://github.com/dlang/druntime/blob/master/src/core/demangle.d
https://reviews.llvm.org/D44321
__
timotheecour added a comment.
Note that the D plugin is not loaded by default (so default behavior is not
affected) ; it's only loaded if user adds to his .lldbinit:
settings set plugin.language.D.pluginfile "path_to/liblldbdplugin.dylib"
https://reviews.llvm.org/D44321
_
14 matches
Mail list logo
