Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for foobár - > between the two implementations. So if you build with an older clang, and > test with a new lldb, the type lookup fa

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3500-3518 + // Create a list of write entries from loadable segments, + // using physical addresses if they aren't all null + size_t header_count = ParseProgramHeaders(); + bool should_u

[Lldb-commits] [PATCH] D44166: [SymbolFilePDB] Add missing Char16 and Char32 types in a few places

zturner added a subscriber: asmith. zturner added a comment. Lgtm Repository: rL LLVM https://reviews.llvm.org/D44166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43837: Move option parsing out of the Args class

labath added a comment. Is there anything else you wanted me to do here? https://reviews.llvm.org/D43837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r327013 - [LLDB][PPC64] Fix single step and LldbGdbServer tests

Author: labath Date: Thu Mar 8 07:41:13 2018 New Revision: 327013 URL: http://llvm.org/viewvc/llvm-project?rev=327013&view=rev Log: [LLDB][PPC64] Fix single step and LldbGdbServer tests Summary: On PPC64, the tested functions were being entered through their local entry point, while the tests e

[Lldb-commits] [lldb] r327016 - Install lldb's SB headers (pr36630)

Author: labath Date: Thu Mar 8 07:52:46 2018 New Revision: 327016 URL: http://llvm.org/viewvc/llvm-project?rev=327016&view=rev Log: Install lldb's SB headers (pr36630) These were removed in r309021 in what looks like an accidentally committed change. This brings them back. I also rename the hea

[Lldb-commits] [lldb] r327017 - Fix std unique pointer pretty-printer for new stl versions

Author: labath Date: Thu Mar 8 08:03:09 2018 New Revision: 327017 URL: http://llvm.org/viewvc/llvm-project?rev=327017&view=rev Log: Fix std unique pointer pretty-printer for new stl versions Summary: The unique pointer layout was changed in libstdc++ 6.0.23. Reviewers: labath, clayborg Reviewe

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327017: Fix std unique pointer pretty-printer for new stl versions (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44015 Fil

[Lldb-commits] [PATCH] D44253: [SymbolFilePDB] Rewrite ParseTypes method

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. The types for the compiland's children are parsed when parsing types for a PDB compiland. Global types also need to be parsed but unfortunately PDBs do not have compiland in

[Lldb-commits] [PATCH] D44157: [elf] Remove one copy of the section merging code

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Yes, it should be the same I think; some notes of mine: Module::GetSectionList()->obj_file->CreateSections(*GetUnifiedSectionList()); Module::GetUnifiedSectionList()->

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1026779, @davide wrote: > In https://reviews.llvm.org/D32167#1026762, @jankratochvil wrote: > > > In https://reviews.llvm.org/D32167#1024546, @labath wrote: > > > > > I personally don't think having a new debug info flavour is a good id

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw updated this revision to Diff 137598. owenpshaw added a comment. - Share some common code in LoadInMemory The DoLoadInMemory implementations call target.CalculateProcess() again, but passing Process or Process::WriteEntries to DoLoadInMemory would require either moving the Process.h i

[Lldb-commits] [PATCH] D43837: Move option parsing out of the Args class

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Nope. https://reviews.llvm.org/D43837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for foobár - > > between the two implementations. So if you buil

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote: > > >> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >> >> >> >> >> On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: >> On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: >> > The hashing algorithm gives different values - at least for foob

[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files

jankratochvil updated this revision to Diff 137622. https://reviews.llvm.org/D43512 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/linux/buildidsymlink/Makefile packages/Python/lldbsuite/test/linux/buildidsymlink/TestTargetSymbolsBuildidSymlink.py pack

[Lldb-commits] [lldb] r327052 - [test] Skip a test when using an out-of-tree debugserver

Author: vedantk Date: Thu Mar 8 11:46:39 2018 New Revision: 327052 URL: http://llvm.org/viewvc/llvm-project?rev=327052&view=rev Log: [test] Skip a test when using an out-of-tree debugserver The test "test_fp_special_purpose_register_read" in TestRegisters.py fails on Darwin machines configured t

[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

jankratochvil added a comment. In https://reviews.llvm.org/D40475#1018951, @davide wrote: > fwiw, you don't need unit tests or python tests to implement this. > If I understand the feature correctly you can probably extend `lldb-test` > (which is run as part of `check-lldb-lit`). I do not und

[Lldb-commits] [lldb] r327084 - Three little cleanups in the debugserver xcode project file.

Author: jmolenda Date: Thu Mar 8 16:17:22 2018 New Revision: 327084 URL: http://llvm.org/viewvc/llvm-project?rev=327084&view=rev Log: Three little cleanups in the debugserver xcode project file. 1. Link against libpmenergy and pmsample unconditionally. It is available on macOS 10.10 ("Yosemite

[Lldb-commits] [lldb] r327085 - Fixed two more sdk inconsistencies with the pmenergy stuff.

Author: jmolenda Date: Thu Mar 8 16:23:29 2018 New Revision: 327085 URL: http://llvm.org/viewvc/llvm-project?rev=327085&view=rev Log: Fixed two more sdk inconsistencies with the pmenergy stuff. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: lldb/trunk

[Lldb-commits] [lldb] r327087 - Remove the explicit dependency on libpmenergy and libpmsample.

Author: jmolenda Date: Thu Mar 8 16:28:51 2018 New Revision: 327087 URL: http://llvm.org/viewvc/llvm-project?rev=327087&view=rev Log: Remove the explicit dependency on libpmenergy and libpmsample. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: lldb/tr

[Lldb-commits] [lldb] r327088 - Remove unneeded per-arch sdk specifications from debugserver xcode project file.

Author: jmolenda Date: Thu Mar 8 16:32:56 2018 New Revision: 327088 URL: http://llvm.org/viewvc/llvm-project?rev=327088&view=rev Log: Remove unneeded per-arch sdk specifications from debugserver xcode project file. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r327089 - [test] Skip a test which sporadically fails in its dsym variant

Author: vedantk Date: Thu Mar 8 16:34:43 2018 New Revision: 327089 URL: http://llvm.org/viewvc/llvm-project?rev=327089&view=rev Log: [test] Skip a test which sporadically fails in its dsym variant There is a mailing list discussion re: r325927 about why this test fails in the dsym variant. I've

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

I've gone ahead and skipped this test for the dsym variant until this is resolved. r327089. vedant > On Mar 8, 2018, at 10:49 AM, Davide Italiano via lldb-commits > wrote: > > On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote: >> >> >>> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >>>

[Lldb-commits] [lldb] r327095 - More cleanups of debugserver project file and the libpmenergy/libpmsample

Author: jmolenda Date: Thu Mar 8 17:37:37 2018 New Revision: 327095 URL: http://llvm.org/viewvc/llvm-project?rev=327095&view=rev Log: More cleanups of debugserver project file and the libpmenergy/libpmsample stuff. Activate it when an internal SDK is selected. Update the name of the LDFLAGS to

[Lldb-commits] [lldb] r327097 - I added CFLAGS etc to one part of the project file I should not have.

Author: jmolenda Date: Thu Mar 8 17:43:18 2018 New Revision: 327097 URL: http://llvm.org/viewvc/llvm-project?rev=327097&view=rev Log: I added CFLAGS etc to one part of the project file I should not have. Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: