[Lldb-commits] [PATCH] D43857: Speed up TestWatchpointMultipleThreads

clayborg added a comment. very nice! https://reviews.llvm.org/D43857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. Ping for my last comment https://reviews.llvm.org/D32167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r326449 - Make TestDynamicValueSameBase gcc-compatible

Author: labath Date: Thu Mar 1 08:56:28 2018 New Revision: 326449 URL: http://llvm.org/viewvc/llvm-project?rev=326449&view=rev Log: Make TestDynamicValueSameBase gcc-compatible gcc will say that the type of "this" is "T * const", clang "T *". Compare the unqualified type names to erase the diffe

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

jingham added a comment. Asking the person trying to catch a bad CompilerType to understand how the error mechanism works to effect this goal seems a little much, especially 'cause they are going to be focused on the return which your macro would make tantalizingly out of my reach. OTOH, if yo

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

zturner added a comment. I'm also ok with not having the macro fwiw, just an idea to reduce boilerplate. https://reviews.llvm.org/D43912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

jingham added a comment. For tests that run processes I don't think lit has any advantages over the dotest tests. For tests of a facility that's explicitly going to provide SB API's, testing them with dotest.py which is set up to be convenient to do SB API testing seems the correct thing to do

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

I have no general objections to macros, and reducing boiler-plate is good. They do get in the way of debugging because of the weird C rule that a macro has to pretend that it is all one source line, so if they contain code you are interested in stopping at, there needs to be some other way to d

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: > > I have no general objections to macros, and reducing boiler-plate is good. > They do get in the way of debugging because of the weird C rule that a macro > has to pretend that it is all one source line, so if they contain code you > are in

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. > This seems like it is two patches, one fixing the NSCallStackArray data > formatter, and one extracting fields from NSException. Is that right. I'm > more asking to make sure I'm not missing something about this patch. I'll split the patch. There's actually proba

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

jingham added inline comments. Comment at: source/Plugins/Language/ObjC/NSException.cpp:57-64 + auto name = process_sp->ReadPointerFromMemory(ptr + 1 * ptr_size, error); + if (error.Fail() || name == LLDB_INVALID_ADDRESS) return false; + auto reason = process_sp->ReadPointerFr

Re: [Lldb-commits] [lldb] r326449 - Make TestDynamicValueSameBase gcc-compatible

Thanks! Jim > On Mar 1, 2018, at 8:56 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Mar 1 08:56:28 2018 > New Revision: 326449 > > URL: http://llvm.org/viewvc/llvm-project?rev=326449&view=rev > Log: > Make TestDynamicValueSameBase gcc-compatible > > gcc will say

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

On 1 March 2018 at 10:34, Adrian Prantl wrote: > >> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: >> >> I have no general objections to macros, and reducing boiler-plate is good. >> They do get in the way of debugging because of the weird C rule that a macro >> has to pretend that it is all o

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

> On Mar 1, 2018, at 10:44 AM, Pavel Labath wrote: > > On 1 March 2018 at 10:34, Adrian Prantl wrote: >> >>> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: >>> >>> I have no general objections to macros, and reducing boiler-plate is good. >>> They do get in the way of debugging because of

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

jingham added a comment. I have a couple of structural questions. First, it would be good to stop a bit and think about how to make the StackFrameRecognizer's return data more flexible. At some point, for instance, it would be great to be able to add a StackFrameRecognizerPython and then let

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. Sorry, I've been waiting to give others (Davide?) a chance to express their opinion. I personally don't think having a new debug info flavour is a good idea. Tests written specifically to test this functionality will be easier to maintain and debug when they break. And k

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. As already pointed out, I think this feature should be thought again & have more focused testing. We can have a meeting/discussion about this, and I need to think about it more. But

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jasonmolenda added a comment. I think we're being a little hasty here. Greg's last suggestion is worth investigation -- how many tests would actually be run for this new variant? Greg, maybe you could remove the make clean targets from packages/Python/lldbsuite/test/plugins/builder_base.py (I

[Lldb-commits] [lldb] r326514 - Speed up TestWatchpointMultipleThreads

Author: labath Date: Thu Mar 1 16:17:05 2018 New Revision: 326514 URL: http://llvm.org/viewvc/llvm-project?rev=326514&view=rev Log: Speed up TestWatchpointMultipleThreads Summary: The inferior was sleeping before doing any interesting work. I remove that to make the test faster. While looking a

[Lldb-commits] [PATCH] D43857: Speed up TestWatchpointMultipleThreads

This revision was automatically updated to reflect the committed changes. Closed by commit rL326514: Speed up TestWatchpointMultipleThreads (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43857 Files: lldb/trunk/pa

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

aprantl created this revision. aprantl added a reviewer: jingham. It turns out that setting the clang module cache after LLDB has a Target can be too late. In particular, the Swift language plugin needs to know the setting without having access to a Target. This patch moves the setting into the

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

vsk updated this revision to Diff 136640. vsk retitled this revision from "[Symbol] Add InvalidType, a force-checked recoverable error" to "[Symbol] Add InvalidTypeError, a force-checked recoverable error". vsk added a comment. - While playing around with InvalidTypeError, I found that it's usef

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

labath added inline comments. Comment at: include/lldb/Utility/Log.h:259-260 +// +// For convenience, log may either be a Log instance or an unsigned value +// specifying log categories. +// The thing to remember here is that we have multiple log channels. So the

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

vsk updated this revision to Diff 136656. vsk added a comment. - Clarify that the log_categories macro argument is for logging to the "lldb" channel. https://reviews.llvm.org/D43912 Files: include/lldb/Symbol/CompilerType.h include/lldb/Utility/Log.h source/Plugins/ExpressionParser/Clang

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

jingham added a comment. This looks fine. Did you have a way to test it? https://reviews.llvm.org/D43984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

aprantl added a comment. The entire testsuite depends on being able to set this option (see the change in `packages/Python/lldbsuite/test/lldbtest.py`), but we don't verify that the directory is being used. I'll see if I can come up with a dedicated test. https://reviews.llvm.org/D43984 ___