clayborg added a comment.
In https://reviews.llvm.org/D32167#1020032, @labath wrote:
> In https://reviews.llvm.org/D32167#1019702, @clayborg wrote:
>
> > I am afraid of the opposite: we test what we think we need to test and our
> > simple tests cases don't adequately test the feature we are add
clayborg added a comment.
I agree with Pavel, thanks for taking the time to get this done right and
listening to the feedback that was offered. The patch is better for it.
https://reviews.llvm.org/D42145
___
lldb-commits mailing list
lldb-commits@l
On 27 February 2018 at 07:11, Greg Clayton via Phabricator
wrote:
> clayborg added a comment.
>
> In https://reviews.llvm.org/D32167#1020032, @labath wrote:
>
>> In https://reviews.llvm.org/D32167#1019702, @clayborg wrote:
>>
>> > I am afraid of the opposite: we test what we think we need to test
clayborg added a comment.
Would everyone be ok with a solution where we leave the .debug_types tests in
as a flavor, but we check the binary after creating it to ensure it has a
.debug_types section. If it doesn't, then we skip the test (or pass it?), and
if it does, then we go ahead and test i
Author: hanming
Date: Tue Feb 27 09:53:38 2018
New Revision: 326213
URL: http://llvm.org/viewvc/llvm-project?rev=326213&view=rev
Log:
Got rid of weak imports of libpenergy and libpsample because we are already
requiring a modern macOS (at least 10.11)
Reviewer: Jason Molenda
Modified:
lldb/
Author: hanming
Date: Tue Feb 27 10:02:15 2018
New Revision: 326214
URL: http://llvm.org/viewvc/llvm-project?rev=326214&view=rev
Log:
Removed accidentally committed code from previous commit.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachTask.mm
Modified: lldb/trunk/tools/debugser
Author: labath
Date: Tue Feb 27 10:07:53 2018
New Revision: 326218
URL: http://llvm.org/viewvc/llvm-project?rev=326218&view=rev
Log:
Move TestGdbRemoteExitCode next to the other llgs tests
This test contained a copy of the inferior used by most of llgs test.
This was done to enable better paralel
Author: labath
Date: Tue Feb 27 10:42:46 2018
New Revision: 326224
URL: http://llvm.org/viewvc/llvm-project?rev=326224&view=rev
Log:
[LLDB] Initial version of PPC64 InstEmulation
Summary: Supports common prologue/epilogue instructions.
Reviewers: clayborg, labath
Reviewed By: clayborg, labath
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326261: [lldb] Use vFlash commands when writing to
target's flash memory regions (authored by labath, committed by ).
Hera
Author: labath
Date: Tue Feb 27 14:14:33 2018
New Revision: 326261
URL: http://llvm.org/viewvc/llvm-project?rev=326261&view=rev
Log:
[lldb] Use vFlash commands when writing to target's flash memory regions
Summary:
When writing an object file over gdb-remote, use the vFlashErase, vFlashWrite,
an
Author: labath
Date: Tue Feb 27 14:45:49 2018
New Revision: 326264
URL: http://llvm.org/viewvc/llvm-project?rev=326264&view=rev
Log:
Fix lldbinline tests for remote targets
r326140 exposed the fact that we are not actually running inline tests on
remote targets. The tests fail to launch the infer
labath created this revision.
labath added reviewers: davide, jingham, zturner.
The args class is used in plenty of places (a lot of them in the lower lldb
layers) for representing a list of arguments, and most of these places don't
care about option parsing. Moving the option parsing out of the c
labath added a comment.
It seems this messed up the computation of load addresses for symbols in the
androids vdso:
Symtab, num_symbols = 5:
Debug symbol
|Synthetic symbol
||Externally Visible
|||
Index UserID DSX Type
labath added a comment.
Ok, so this is what seems to be happening:
The vdso "file" has the following program headers:
Program Headers:
Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align
LOAD 0x00 0xe000 0x 0x00434 0x00434 R E 0x1000
DYN
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:814
value = value - header->p_vaddr;
found_offset = true;
Ok so the issue is that here we use the virtual address to compute the load
bia
Author: jmolenda
Date: Tue Feb 27 20:11:37 2018
New Revision: 326302
URL: http://llvm.org/viewvc/llvm-project?rev=326302&view=rev
Log:
Add EmulateInstructionPPC64.cpp to xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro
labath created this revision.
labath added reviewers: davide, jingham.
Herald added a subscriber: aprantl.
The inferior was sleeping before doing any interesting work. I remove that
to make the test faster.
While looking at the purpose of the test (to check that watchpoints are
propagated to all
owenpshaw added inline comments.
Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:814
value = value - header->p_vaddr;
found_offset = true;
labath wrote:
> Ok so the issue is that here we use the virtual address to co
18 matches
Mail list logo
