labath added a comment.
In https://reviews.llvm.org/D43506#1013276, @aprantl wrote:
> Thanks!
>
> By the way, just in case you are motivated :-), one outstanding task is also
> to replace all uses of the `clean` target in the makefiles with simply
> removing the test build directory.
I think
Author: labath
Date: Wed Feb 21 07:33:53 2018
New Revision: 325690
URL: http://llvm.org/viewvc/llvm-project?rev=325690&view=rev
Log:
Fix a couple of more tests to not create files in the source tree
Summary:
These were not being flaky, but they're still making the tree dirty.
These tests were us
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325690: Fix a couple of more tests to not create files in
the source tree (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
friss created this revision.
friss added a reviewer: vsk.
Herald added a subscriber: kubamracek.
Potentially due to the recent testuite refactorings, this test now reports
a full absolute path but expect just the filename. For some reason this
test is skipped on GreenDragon so we've never seen the
amccarth added a comment.
By unconditional, do you mean allowing any value for `out_num_locations` in
these cases? I'm happy to do that, but I'm not sure if I've understood you
correctly.
https://reviews.llvm.org/D43419
___
lldb-commits mailing l
labath added a comment.
Yes, regardless of the target platform, if you specify num_locations = -2, then
we just don't check the number of locations.
https://reviews.llvm.org/D43419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
labath added inline comments.
Comment at: source/Host/common/Symbols.cpp:288-290
if (llvm::sys::fs::equivalent(file_spec.GetPath(),
module_file_spec.GetPath()))
continue;
Do we need to check the equivalen
labath added a comment.
Greg, with my last comment in mind, how do you feel about this patch?
https://reviews.llvm.org/D42955
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth updated this revision to Diff 135272.
amccarth added a comment.
Per Pavel's suggestion, change special value to mean don't check the number of
locations found.
https://reviews.llvm.org/D43419
Files:
lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/T
davide added a comment.
I wonder whether we could use something like
>>> import os
>>> os.path.basename('/patatino/ino/main.c')
'main.c'
to make this slightly more robust against files which end in `main.c` but we
don't want to really match, e.g. `blahmain.c`.
https://reviews.llvm.org/D
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: source/Core/Module.cpp:1286
+if (SymbolVendor *vendor = GetSymbolVendor())
+ vendor->CreateSections(*GetUnifiedSectionList());
}
---
Author: labath
Date: Wed Feb 21 09:38:38 2018
New Revision: 325701
URL: http://llvm.org/viewvc/llvm-project?rev=325701&view=rev
Log:
llgs-tests: Fix r325511 for debugserver
Debugserver sends the thread-pcs field with leading zeroes omitted. Teach
parseRegisterValue to pad these as necessary.
Mod
Author: labath
Date: Wed Feb 21 09:55:22 2018
New Revision: 325702
URL: http://llvm.org/viewvc/llvm-project?rev=325702&view=rev
Log:
Fix remote tests broken by r325690
The patch added an extra argument to the append_to_process_working_directory
function. I have somehow missed updating this test,
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325704: Fix TestBreakpointInGlobalConstructor for Windows
(authored by amccarth, committed by ).
Herald added a subscriber
Author: amccarth
Date: Wed Feb 21 10:08:23 2018
New Revision: 325704
URL: http://llvm.org/viewvc/llvm-project?rev=325704&view=rev
Log:
Fix TestBreakpointInGlobalConstructor for Windows
Summary:
This test was failing on Windows because it expected the breakpoint in the
dynamic library to be resolv
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
I'd be fine with this version of the patch, or one which uses path.basename to
be more stringent.
This test is skipped on green dragon because I have not upstreamed the debugger
integration for ubs
Author: davide
Date: Wed Feb 21 11:18:49 2018
New Revision: 325708
URL: http://llvm.org/viewvc/llvm-project?rev=325708&view=rev
Log:
[testsuite/decorators] Get rid of some `expectFlakey` variants.
These seem to be pretty much dead.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorato
On Tue, Feb 20, 2018 at 10:20 PM, Frederic Riss via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: friss
> Date: Tue Feb 20 22:20:03 2018
> New Revision: 325666
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325666&view=rev
> Log:
> Fix TestAppleTypesIsProduced after r324226
>
> Th
davide created this revision.
davide added reviewers: friss, vsk, JDevlieghere, labath, zturner.
Herald added a subscriber: mgorny.
Also, fix a missing dependency, as lit requires `llvm-config` to run.
This is becoming more and more important as we write more FileCheck style tests
(see Jonas' las
friss created this revision.
friss added a reviewer: clayborg.
Herald added subscribers: JDevlieghere, aprantl.
The modified test would just crash without the code change. The reason is that
we would try to extend the Foo type imported from the PCH debug info when
adding the
Foo::Bar definitiion
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
Author: davide
Date: Wed Feb 21 13:10:44 2018
New Revision: 325719
URL: http://llvm.org/viewvc/llvm-project?rev=325719&view=rev
Log:
[testsuite] Run lit tests as part of `check-lldb`.
Also, fix a missing dependency, as lit requires llvm-config
to run. This is becoming more and more important as w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325719: [testsuite] Run lit tests as part of `check-lldb`.
(authored by davide, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43591?vs=13531
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
The LLDB_DEBUGSERVER_PATH is the "official" way to force a debugserver path in
lldb. So unless you want to change the implementation in
GDBRemoteCommunication, I don't think there is anything
Author: labath
Date: Wed Feb 21 13:56:18 2018
New Revision: 325728
URL: http://llvm.org/viewvc/llvm-project?rev=325728&view=rev
Log:
[LLDB][PPC64] Fixed next blocked forever at same line
Summary:
The PC corresponding to the breakpoint was being calculated wrongly,
which was causing LLDB to never
labath created this revision.
labath added reviewers: aprantl, davide.
Herald added a subscriber: JDevlieghere.
The llvm function is equivalent to this one. Where possible I tried to
replace const char* with llvm::StringRef to avoid extra strlen
computations. In most places, I was able to track th
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: include/lldb/Core/MappedHash.h:156
- template
- class ExportTable {
- public:
Yeah this looks like it was a dead end dating back to 201
davide accepted this revision.
davide added a comment.
Thanks.
https://reviews.llvm.org/D43596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth created this revision.
amccarth added a reviewer: zturner.
Herald added a subscriber: sanjoy.
This test uses the SB API to set and read back bytes of data, and it works fine
when Python 2 is the scripting language. On Windows, however, Python 3 is the
default.
Note this line from the tes
amccarth created this revision.
amccarth added a reviewer: zturner.
Herald added a subscriber: sanjoy.
The header file for the DLL tried to declare inline functions and a local
function as dllexport which broke the compile and link. Removing the bad
declarations solves the problem, and the test p
amccarth abandoned this revision.
amccarth added a comment.
Please ignore. I'm still trying to figure out arc.
https://reviews.llvm.org/D43599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
31 matches
Mail list logo
