[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

2018-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This adds a special case to "long double" logic, which is already a special case compared to "float" and "double" cases. This was written this way (see http://reviews.llvm.org/D8417) because the x86 long double type is special, but if I understand this correctly, for the

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

2018-01-16 Thread Leandro Lupori via Phabricator via lldb-commits
luporl added a comment. @labath, the change you suggested really looks better, by reducing the number of special cases. I tested it on PPC64 and it also fixes the issue, as expected. I'll update the diff. Thanks! Repository: rL LLVM https://reviews.llvm.org/D42083 __

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

2018-01-16 Thread Leandro Lupori via Phabricator via lldb-commits
luporl updated this revision to Diff 129939. luporl added a comment. Changed implementation to make only x87DoubleExtended a special case. https://reviews.llvm.org/D42083 Files: source/Core/DumpDataExtractor.cpp Index: source/Core/DumpDataExtractor.cpp ==

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

2018-01-16 Thread Owen Shaw via Phabricator via lldb-commits
owenpshaw created this revision. owenpshaw added reviewers: clayborg, labath. Herald added subscribers: mgorny, emaste. When writing an object file over gdb-remote, use the vFlashErase, vFlashWrite, and vFlashDone commands if the write address is in a flash memory region. A bare metal target ma

[Lldb-commits] [lldb] r322603 - Remove the hardcoded macos deployment targets altogether

2018-01-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jan 16 16:22:27 2018 New Revision: 322603 URL: http://llvm.org/viewvc/llvm-project?rev=322603&view=rev Log: Remove the hardcoded macos deployment targets altogether from the xcode project files. We'll build for the current OS only, by default. Modified: lldb/tru

Re: [Lldb-commits] [lldb] r322603 - Remove the hardcoded macos deployment targets altogether

2018-01-16 Thread Davide Italiano via lldb-commits
This is great, thanks Jason! On Tue, Jan 16, 2018 at 4:22 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Tue Jan 16 16:22:27 2018 > New Revision: 322603 > > URL: http://llvm.org/viewvc/llvm-project?rev=322603&view=rev > Log: > Remove the hardcoded macos deployment targets al

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

2018-01-16 Thread Aaron Smith via Phabricator via lldb-commits
asmith updated this revision to Diff 130088. asmith retitled this revision from "Fix crash when parsing the type of a function without any arguments" to "Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'". asmith edited the summary of this revision. Herald add

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

2018-01-16 Thread Aaron Smith via Phabricator via lldb-commits
asmith added a comment. The test is added and this is ready to go. Let me know if there are any other changes. Thanks! Repository: rL LLVM https://reviews.llvm.org/D41427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D41427: Fix crash when parsing the type of a function without any arguments, i.e. 'int main()'

2018-01-16 Thread Aaron Smith via Phabricator via lldb-commits
asmith updated this revision to Diff 130089. Repository: rL LLVM https://reviews.llvm.org/D41427 Files: lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp lit/SymbolFile/PDB/enums-layout.test lit/SymbolFile/PDB/typedefs.test source/Plugins/SymbolFile/PDB/PDBASTParser.cpp source/Plugins/Sy