Re: [Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex to use FindTypesByRegex instead of FindTypes

2017-12-27 Thread Zachary Turner via lldb-commits
Sorry I missed this, lgtm On Fri, Dec 22, 2017 at 7:55 PM Aaron Smith via Phabricator < revi...@reviews.llvm.org> wrote: > asmith created this revision. > asmith added reviewers: zturner, lldb-commits, labath, clayborg. > > https://reviews.llvm.org/D41086 fixed an exception in > FindTypes()/FindTy

[Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex

2017-12-27 Thread Aaron Smith via Phabricator via lldb-commits
asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. From Zachary Turner [6:46 PM (3 hours ago)] Sorry I missed this, lgtm Repository: rL LLVM https://reviews.llvm.org/D41550 ___ lldb-commits ma

[Lldb-commits] [PATCH] D41550: Update failing PDB unit tests that are searching for symbols by regex

2017-12-27 Thread Aaron Smith via Phabricator via lldb-commits
asmith updated this revision to Diff 128258. asmith added a comment. Formatting; NFC Repository: rL LLVM https://reviews.llvm.org/D41550 Files: source/Plugins/SymbolFile/PDB/SymbolFilePDB.h unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Index: unittests/SymbolFile/PDB/SymbolFilePDBTes