Author: labath
Date: Thu Dec 14 06:56:29 2017
New Revision: 320704
URL: http://llvm.org/viewvc/llvm-project?rev=320704&view=rev
Log:
Remove stderr message from GDBRemoteCommunicationServerLLGS
A similar error message is printed again in lldb-gdbserver.cpp, so the
user will see the message twice.
Author: labath
Date: Thu Dec 14 06:56:45 2017
New Revision: 320705
URL: http://llvm.org/viewvc/llvm-project?rev=320705&view=rev
Log:
ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion
Summary:
These two functions were calling each other, while handling different
branches of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320705: ObjectFile: remove
ReadSectionData/MemoryMapSectionData mutual recursion (authored by labath,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41169?vs=126723&id=126949#toc
R
labath updated this revision to Diff 126975.
labath added a comment.
The version where Section::GetFileSize reports the on-disk (compressed) size. I
also like the idea of renaming Section::GetByteSize to something more
descriptive, and I'll make a follow-up patch to do that.
https://reviews.llvm
labath created this revision.
labath added reviewers: clayborg, krytarowski.
Herald added a subscriber: emaste.
The x86 FPR struct (which does not store just floating point registers)
was defined as a struct containing a union between two members: XSAVE
and FXSAVE. The initial layout of these two
krytarowski added a comment.
Personally I prefer the original code as it looks easier to implement FSAVE.
https://reviews.llvm.org/D41245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
krytarowski added a comment.
In https://reviews.llvm.org/D41245#955462, @krytarowski wrote:
> Personally I prefer the original code as it looks easier to implement FSAVE.
Also naming FPR is more logical, reusing the XSAVE name for 32-bit x86 looks
wrong to me.
https://reviews.llvm.org/D41245
clayborg accepted this revision.
clayborg added a comment.
Move #include of "llvm/Object/Decompressor.h" into CPP file and this is good to
go.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.h:24
#include "lldb/lldb-private.h"
+#include "llvm/Object/Decompressor.h"
labath added a comment.
In https://reviews.llvm.org/D41245#955462, @krytarowski wrote:
> Personally I prefer the original code as it looks easier to implement FSAVE.
Maybe we could delete at least one layer then (make FPR a union which contains
fxsave and xsave members)?
Also, I am curious: i
krytarowski added a comment.
I want to support x86 CPUs in 32-bit mode starting from 486. At least to read
core dumps.
This is the current bare minimum and tested setup by the releng team in NetBSD.
OpenBSD used to support 80386 with MMU, but not sure if this is still true
after migration to Cl
Author: davide
Date: Thu Dec 14 15:03:35 2017
New Revision: 320759
URL: http://llvm.org/viewvc/llvm-project?rev=320759&view=rev
Log:
[ClangASTContext] Remove dead stuff found fixing something else.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/Clan
Author: davide
Date: Thu Dec 14 15:11:15 2017
New Revision: 320761
URL: http://llvm.org/viewvc/llvm-project?rev=320761&view=rev
Log:
[ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.
Clang recently switched to C++14 (with GNU extensions) as the default
dialect, but LLDB
Author: davide
Date: Thu Dec 14 16:00:17 2017
New Revision: 320769
URL: http://llvm.org/viewvc/llvm-project?rev=320769&view=rev
Log:
[ExpressionParser] Rollback C++98 as the standard for evaluating.
Some ubuntu bots are failing with this patch in, let me unblock
while I investigate.
Modified:
Author: davide
Date: Thu Dec 14 16:50:43 2017
New Revision: 320778
URL: http://llvm.org/viewvc/llvm-project?rev=320778&view=rev
Log:
[ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.
Clang recently switched to C++14 (with GNU extensions) as the default
dialect, but LLDB
14 matches
Mail list logo