[Lldb-commits] [lldb] r320704 - Remove stderr message from GDBRemoteCommunicationServerLLGS

2017-12-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Dec 14 06:56:29 2017 New Revision: 320704 URL: http://llvm.org/viewvc/llvm-project?rev=320704&view=rev Log: Remove stderr message from GDBRemoteCommunicationServerLLGS A similar error message is printed again in lldb-gdbserver.cpp, so the user will see the message twice.

[Lldb-commits] [lldb] r320705 - ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion

2017-12-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Dec 14 06:56:45 2017 New Revision: 320705 URL: http://llvm.org/viewvc/llvm-project?rev=320705&view=rev Log: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion Summary: These two functions were calling each other, while handling different branches of

[Lldb-commits] [PATCH] D41169: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion

2017-12-14 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320705: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D41169?vs=126723&id=126949#toc R

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-14 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 126975. labath added a comment. The version where Section::GetFileSize reports the on-disk (compressed) size. I also like the idea of renaming Section::GetByteSize to something more descriptive, and I'll make a follow-up patch to do that. https://reviews.llvm

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, krytarowski. Herald added a subscriber: emaste. The x86 FPR struct (which does not store just floating point registers) was defined as a struct containing a union between two members: XSAVE and FXSAVE. The initial layout of these two

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-14 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Personally I prefer the original code as it looks easier to implement FSAVE. https://reviews.llvm.org/D41245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-14 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D41245#955462, @krytarowski wrote: > Personally I prefer the original code as it looks easier to implement FSAVE. Also naming FPR is more logical, reusing the XSAVE name for 32-bit x86 looks wrong to me. https://reviews.llvm.org/D41245

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Move #include of "llvm/Object/Decompressor.h" into CPP file and this is good to go. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.h:24 #include "lldb/lldb-private.h" +#include "llvm/Object/Decompressor.h"

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D41245#955462, @krytarowski wrote: > Personally I prefer the original code as it looks easier to implement FSAVE. Maybe we could delete at least one layer then (make FPR a union which contains fxsave and xsave members)? Also, I am curious: i

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-14 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. I want to support x86 CPUs in 32-bit mode starting from 486. At least to read core dumps. This is the current bare minimum and tested setup by the releng team in NetBSD. OpenBSD used to support 80386 with MMU, but not sure if this is still true after migration to Cl

[Lldb-commits] [lldb] r320759 - [ClangASTContext] Remove dead stuff found fixing something else.

2017-12-14 Thread Davide Italiano via lldb-commits
Author: davide Date: Thu Dec 14 15:03:35 2017 New Revision: 320759 URL: http://llvm.org/viewvc/llvm-project?rev=320759&view=rev Log: [ClangASTContext] Remove dead stuff found fixing something else. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/Clan

[Lldb-commits] [lldb] r320761 - [ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.

2017-12-14 Thread Davide Italiano via lldb-commits
Author: davide Date: Thu Dec 14 15:11:15 2017 New Revision: 320761 URL: http://llvm.org/viewvc/llvm-project?rev=320761&view=rev Log: [ExpressionParser] Fix evaluation failures due to mismatch in C++ versions. Clang recently switched to C++14 (with GNU extensions) as the default dialect, but LLDB

[Lldb-commits] [lldb] r320769 - [ExpressionParser] Rollback C++98 as the standard for evaluating.

2017-12-14 Thread Davide Italiano via lldb-commits
Author: davide Date: Thu Dec 14 16:00:17 2017 New Revision: 320769 URL: http://llvm.org/viewvc/llvm-project?rev=320769&view=rev Log: [ExpressionParser] Rollback C++98 as the standard for evaluating. Some ubuntu bots are failing with this patch in, let me unblock while I investigate. Modified:

[Lldb-commits] [lldb] r320778 - [ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.

2017-12-14 Thread Davide Italiano via lldb-commits
Author: davide Date: Thu Dec 14 16:50:43 2017 New Revision: 320778 URL: http://llvm.org/viewvc/llvm-project?rev=320778&view=rev Log: [ExpressionParser] Fix evaluation failures due to mismatch in C++ versions. Clang recently switched to C++14 (with GNU extensions) as the default dialect, but LLDB